fix(deps): override browserslist to 4.28.7+ (GHSA-c83g-rgw3-j3cx) - #170
Merged
Merged
Conversation
Two newly published HIGH advisories against browserslist <= 4.28.6 (unbounded memory growth from an unevicted query-result cache, plus a crash/prototype-write via untrusted browserslist-stats.json), patched in 4.28.7. Reached transitively via babel, so no direct dependency to bump. Overridden at the workspace root (apps/mobile is a workspace member, so its pnpm.overrides field has no effect there per pnpm's own warning -- added anyway for documentation/defense since apps/mobile also ships a standalone-looking package.json, but the root override is what actually governs). The nested packages/ clone (gitignored, cloned fresh at install time per CI) was refreshed from nself-org/packages main before regenerating, picking up its eslint/typescript-eslint devDependency addition to @nself/tailwind-brand as a side effect. Verified by the resolved lockfile version rather than the config: browserslist now resolves to 4.28.8. CI=true pnpm install --frozen-lockfile exits 0 at the workspace root. pnpm audit --audit-level=high still exits non-zero (2 pre-existing HIGH findings via metro>image-size, unrelated to this advisory). Discovery (not fixed here, out of scope): apps/mobile/pnpm-lock.yaml appears to be a dead file -- running pnpm install from within apps/mobile still resolves against the root pnpm-workspace.yaml (pnpm walks up to find it) and never touches apps/mobile's own lockfile, so the CI step that installs there is actually exercising the root lockfile already fixed by this change.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserslist-stats.json), patched in 4.28.7. Reached transitively via babel; overridden at the workspace root.packages/clone (nself-org/packages, refreshed at install time) was pulled fresh from main first.Verification
grep -oE 'browserslist@[0-9.]+' pnpm-lock.yaml->browserslist@4.28.8.CI=true pnpm install --frozen-lockfileexits 0 at the workspace root.pnpm audit --audit-level=highstill exits non-zero (2 pre-existing HIGH findings viametro>image-size, unrelated to this advisory).Discovery (out of scope, flagging only)
apps/mobile/pnpm-lock.yamllooks like a dead file: runningpnpm installfrom insideapps/mobilestill resolves against the rootpnpm-workspace.yaml(pnpm walks up to find it) and never touchesapps/mobile's own lockfile. The "Install mobile dependencies" CI step is therefore already exercising the root lockfile this PR fixes. Added the override toapps/mobile/package.jsontoo for documentation, though pnpm warns it has no effect there.Test plan