ci(web): wire the existing eslint config into CI as a blocking gate - #171
Merged
Merged
Conversation
P6-E11-W2-S4-T25: ntask/web/eslint.config.mjs and web/package.json's "lint": "eslint ." script have worked locally the whole time but were never invoked in CI (grep for eslint/lint across all 20 workflow files returned zero matches). Fixed the actual reason the config was unusable standalone: eslint.config.mjs imports eslint-plugin-react-hooks, which was missing from web/package.json devDependencies (import failed with ERR_MODULE_NOT_FOUND). Added it, confirmed `pnpm --filter ntask lint` now runs clean (0 errors, 1 pre-existing warning) before wiring it as a blocking CI step.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint.config.mjsandlintscript that were never invoked in CI. Root cause:eslint.config.mjsimportseslint-plugin-react-hooks, which was missing fromweb/package.jsondevDependencies (ERR_MODULE_NOT_FOUNDon any lint attempt). Added the missing dependency, then wiredpnpm --filter ntask lintintoci.yml'sweb-testjob as a blocking step.Test plan
pnpm --filter ntask lintrun locally before wiring the CI step: 0 errors, 1 pre-existing warning (react-hooks/exhaustive-depsinListsPage.tsx, not touched by this PR) -- confirmed safe to make blocking.actionlinton the changed workflow -- only a pre-existing, unrelated warning elsewhere in the file.