fix(deps): bump nodemailer to 9.1.1 in backend/functions - #175
Merged
Merged
Conversation
Three open Dependabot high alerts against backend/functions, all on nodemailer and all fixed by 9.1.1: GHSA-2x7j-588g-ccc2 resolveContent() on a MailMessage bypasses disableFileAccess/disableUrlAccess via the legacy signature addressparser quadratic O(n^2) time, remote DoS via a crafted address list IDN/Punycode domain allow-list bypass, delivery to an attacker-controlled domain The declared range was already ^9.0.5, which permits 9.1.1, but package-lock.json pinned 9.0.5 and CI installs with npm ci — so the range alone fixed nothing. Raising the floor to ^9.1.1 as well so it cannot silently regress to a vulnerable patch. backend/functions is npm-managed (CI runs npm ci); left as npm rather than converted. Verified: npm ci exits 0, npm run typecheck clean, npm test 95 pass 0 fail.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three open Dependabot high alerts against
backend/functions, all onnodemailer,all fixed by 9.1.1:
resolveContent()on aMailMessagebypassesdisableFileAccess/disableUrlAccesswhen called with the legacy signatureWhy the existing range didn't protect us
package.jsonalready declared^9.0.5, which permits 9.1.1. Butpackage-lock.jsonpinned9.0.5, and CI installs withnpm ci— which installs thelock exactly and ignores what the range would allow. So the permissive range fixed
nothing on its own.
This is the same shape as the
pnpm.overridesproblem fixed in #174: a declarationthat reads correctly while the lockfile — the artifact the installer and the scanners
actually consume — still carries the vulnerable version.
Raising the declared floor to
^9.1.1as well, so a future lock regeneration cannotquietly resolve back to a vulnerable 9.0.x.
Tooling note
backend/functionsis npm-managed and its CI job runsnpm ci. Left as npm ratherthan converted — that is a separate decision, not something to smuggle into a security
bump.
Verification
Remaining open highs after this
Only the two
image-sizeadvisories, which are already documentedIgnoredVulnsinapps/mobile/osv-scanner.tomlwith the justification that no fixed version has beenpublished upstream and the package is build-time only, not in the shipped bundle.