fix(ci): drop permanently-unmatchable JSON-findings pathspec from add-paths - #90
Merged
Merged
Conversation
…-paths Same fix as the sibling plugins (PR #33), cli (PR #215), and admin repos: the AI-tooling config directory this org keeps out of git (per repo .gitignore) is gitignored repo-wide. git add's pathspec matching does not count gitignored files as a match even when they exist on disk with fresh content, so the findings-JSON pattern in add-paths would abort the whole git add call the moment any real .md change needs staging -- confirmed live in plugins run 31958209014. No functional loss: the JSON report is already preserved via the 'Upload JSON report' actions/upload-artifact step and fed into the PR body directly via body-path, independent of git staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #89 — the real, complete root cause. The AI-tooling config directory this org keeps out of git is gitignored repo-wide;
git add's pathspec matching does not count gitignored files as a match, so the findings-JSON pattern inadd-pathswould abort the wholegit addcall the moment any real.mdchange needs staging. Confirmed live in plugins (run 31958209014, nself-org/plugins#33). No functional loss — the JSON is already preserved viaactions/upload-artifactand fed into the PR body viabody-path. Currently latent here (ntask's last audit run was clean, no findings to stage), but the bug is real.