fix(sdk-core): drop hardcoded staging IP fallback - #22
Merged
Merged
Conversation
nself-staging (167.235.233.65) was permanently destroyed 2026-09-12 by owner decision. STAGING_API_URL / resolveStagingUrl() silently fell back to that dead host's raw IP over HTTP -- now resolves to undefined unless an explicit VITE_NSELF_STAGING_URL / NSELF_STAGING_URL is set. No version bump or npm publish included; the package is not currently published (registry.npmjs.org returns 404 for @nself/sdk-core).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nself/sdk-core'sSTAGING_API_URLconstant andresolveStagingUrl()silently fell back to that raw IP over plain HTTP when no env override was set.STAGING_API_URLis nowundefinedby default;resolveStagingUrl()also checksNSELF_STAGING_URL(Node) in addition to the existingVITE_NSELF_STAGING_URL(Vite), and returnsundefinedwhen neither is set.Scope note
@nself/sdk-coredoes not appear to actually be published (npm view @nself/sdk-corereturns 404 against the public registry, and no workflow in this repo publishes it). Flagging in case that's unexpected — if it's meant to be live, that's a separate gap.resolveStagingUrl/STAGING_API_URLexist in this repo besides theindex.tsre-export.Test plan
vitest runin@nself/sdk-core— 28/28 pass