fix(ci): defensively disable git-lfs filters in quarterly-doc-audit - #32
Merged
Merged
Conversation
Consistency fix alongside admin/web/cli's identical step: this repo's .gitattributes has the same filter=lfs patterns, but currently has zero tracked files matching them, so this is a no-op today. Added so the same protection exists here if binary assets are ever added later — see admin's copy of this workflow for the full failure mode this prevents.
2 tasks
acamarata
added a commit
that referenced
this pull request
Aug 16, 2026
… add-paths (#33) The real, complete root cause of the Open-auto-fix-PR failures (after the mdx-pathspec fix in #31): .claude/ is gitignored repo-wide (org-standard per GCI -- '.claude/ standard: gitignored AI memory', confirmed via 'grep claude .gitignore' hitting 5 separate ignore lines here). git add's multi-pathspec matching is atomic and does NOT count gitignored files as a match even when the file genuinely exists on disk with fresh content -- reproduced locally: echo '.claude/' > .gitignore; git add .gitignore; git commit -qm init mkdir -p .claude/qa/findings; echo '{}' > .claude/qa/findings/test.json git add -- '.claude/qa/findings/*.json' # fatal: pathspec '.claude/qa/findings/*.json' did not match any files So '.claude/qa/findings/*.json' in add-paths was ALWAYS going to fail git add the moment any other add-paths pattern (**/*.md) also had real changes to stage -- confirmed live: run 31958209014 on commit 5b79fb2 (the #31/#32 fix) failed with exactly this pathspec, once the mdx bug was out of the way and 44 real .md changes needed staging. This isn't a real loss: the JSON report is already preserved via the 'Upload JSON report' actions/upload-artifact step (180-day retention) and fed into the PR body directly via body-path, independent of git staging. Dropping it from add-paths means it simply never gets committed into the repo -- which is correct, since .claude/ is supposed to stay untracked everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency fix alongside admin/web/cli's identical step (same shared workflow, patched together per the same investigation as #31). This repo's .gitattributes has the same
filter=lfspatterns as the other 4 repos, but plugins currently has zero tracked files matching them, so this is a no-op today. Added so the same protection exists here if binary assets are ever added later — see admin PR #70 for the failure mode this prevents (LFS clean-filter mismatch makes un-migrated binaries look perpetually modified, which breaks peter-evans/create-pull-request's internal git stash dance).