fix(ci): stop the counts gate turning main red over a missing secret - #89
Merged
Merged
Conversation
The cross-repo job exit 1'd when PLUGINS_PRO_CHECKOUT_TOKEN was absent. That secret is owner-gated and does not exist, so the job failed on every push to main from the moment it landed. A permanently-red main hides real failures instead of catching them, which is worse than the gap it was flagging. Adopts the Mode A / Mode B shape registry-check.yml already uses. With the secret, counts.json is regenerated and diffed against the committed copy as before. Without it, the job says plainly that the pro side was not verified and that the free side was, and stops. It never skips silently. The case that actually matters is untouched: scripts/plugin-counts.sh still exits 1 rather than emit free-only counts, so a partial artifact can never be generated or published. Verifying half is fine; publishing half is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cross-repo job
exit 1'd whenPLUGINS_PRO_CHECKOUT_TOKENwas absent. That secret is owner-gated and does not exist, so the job has failed on every push to main since it landed in #88.A permanently-red main hides real failures rather than catching them, so this adopts the Mode A / Mode B shape
registry-check.ymlalready uses:counts.json, diff against the committed copy, fail on drift.The gate that matters is untouched.
scripts/plugin-counts.shstill exits 1 rather than emit free-only counts, so a partial artifact can never be generated or published. Verifying half is legitimate; publishing half is not.Provisioning
PLUGINS_PRO_CHECKOUT_TOKEN(org-level Dependabot/Actions secret, scoped read onnself-org/plugins-pro) switches this to Mode A automatically.