fix: point the counts generator at nself-org/bundles - #98
Merged
Merged
Conversation
The licensed-plugin repo was renamed plugins-pro -> bundles (ADR-P6-01), so the artifact was labelling its own source with a name that no longer exists. The sibling-checkout lookup now prefers ../bundles and falls back to ../plugins-pro, because a clone made before the rename still has the old directory name on disk and reaches GitHub through the redirect. Failing on a pre-rename checkout would have broken every existing dev machine. counts.json regenerated with --origin. Counts are unchanged: 129/127 free, 46/46 licensed, 171 advertised. Only sources.pro.repo and the two source blob SHAs move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The licensed-plugin repo was renamed
plugins-pro->bundles(ADR-P6-01), socounts.jsonwas labelling its own source with a repo name that no longer exists.The sibling-checkout lookup now prefers
../bundlesand falls back to../plugins-pro. A clone made before the rename still has the old directory name on disk and reaches GitHub through the redirect; hard-failing on those would break every existing dev machine and CI checkout for no gain.counts.jsonregenerated with--origin(not hand-edited — it carries a DO-NOT-HAND-EDIT marker). Counts are unchanged: 129/127 free, 46/46 licensed, 171 advertised. Onlysources.pro.repoand the two source blob SHAs move, confirming the rename did not disturb the registries.The vendored copy in cli is updated in nself-org/cli#431.