Open
Conversation
This was added in #78 as part of Brightcove integration but appears to have fallen out of composer.json somewhere along the way. For further implementation context, see https://pronovix.com/blog/brightcove-video-connect-drupal-8-part-2-installation-configuration.
cmc333333
reviewed
May 7, 2018
Contributor
cmc333333
left a comment
cmc333333
left a comment
There was a problem hiding this comment.
I tried running "Sync All" from the Brightcove page locally prior to these dependency changes and it ran without an error. The composer.lock file doesn't add any new libraries (though it does bump up the version of many -- mayhaps you ran composer update?).
Are we sure we need this? It seems like we should already be grabbing these dependencies by referencing brightcove, despite their guidance. I'd prefer to handle dependencies without the merge plugin, if we can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in #78 as part of Brightcove integration but appears to have fallen out of composer.json somewhere along the way.
For further context, see https://pronovix.com/blog/brightcove-video-connect-drupal-8-part-2-installation-configuration.