tighten off-by-one report buffer overflow guards in TSIP input loops#28
Open
arib06 wants to merge 1 commit into
Open
tighten off-by-one report buffer overflow guards in TSIP input loops#28arib06 wants to merge 1 commit into
arib06 wants to merge 1 commit into
Conversation
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the tsip/parse input loops in palisade_io, tsip_input_proc and gps_input store an incoming byte into the report buffer and only check the accumulated length afterward with >, so a device streaming a long dle-stuffed packet writes one byte past rpt_buf/buf/parse_msg; tighten each guard to >= (>= BMAX-1 in palisade, where the mb() macro shifts the store index by one) so the overrunning store is dropped before it happens.