Skip to content

Add support for custom gm_opts#7

Open
byronpc wants to merge 1 commit into
nuex:masterfrom
byronpc:master
Open

Add support for custom gm_opts#7
byronpc wants to merge 1 commit into
nuex:masterfrom
byronpc:master

Conversation

@byronpc

@byronpc byronpc commented Oct 24, 2017

Copy link
Copy Markdown

Add ability to set custom opts without the need to define it in the gm_options module everytime

@nuex

nuex commented Oct 25, 2017

Copy link
Copy Markdown
Owner

I think the problem can be resolved by just implementing the remaining options in this list: http://www.graphicsmagick.org/GraphicsMagick.html#opti.

@nuex

nuex commented Oct 25, 2017

Copy link
Copy Markdown
Owner

Or we make it so options are defined dynamically, remove the options clauses altogether, and leave it up to the developer to ensure their options are correct.

@byronpc

byronpc commented Oct 26, 2017

Copy link
Copy Markdown
Author

The problem with implementing remaining options of gm is it's a temporary fix. As soon as new options are introduced in gm, we have to update the library again. I'm all with letting the developer define the options altogether, from a performance point of view, it will also be faster as you don't need to do all those translating and string manipulations, although we'd need to make note that it will break existing apps using your lib.

@byronpc

byronpc commented Oct 26, 2017

Copy link
Copy Markdown
Author

or maybe even just expose another api where sending a string will ignore gm_options module instead?

:gm.convert('#{source}', '#{target}', '-strip -opt2 -opt3...')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants