Skip to content

V0.1.2#7

Merged
nuniz merged 10 commits into
mainfrom
v0.1.2
Jan 29, 2026
Merged

V0.1.2#7
nuniz merged 10 commits into
mainfrom
v0.1.2

Conversation

@nuniz

@nuniz nuniz commented Jan 29, 2026

Copy link
Copy Markdown
Owner

No description provided.

@nuniz

nuniz commented Jan 29, 2026

Copy link
Copy Markdown
Owner Author

#5

@nuniz nuniz linked an issue Jan 29, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements version 0.1.2 of mlx_stft, adding inverse STFT (iSTFT) functionality and performance optimizations to the existing STFT implementation.

Changes:

  • Added ISTFT and CompiledISTFT classes for inverse short-time Fourier transform with perfect reconstruction capability
  • Introduced dual backend support (FFT and Conv) for both STFT and ISTFT with automatic selection based on n_fft size
  • Added comprehensive test suite covering perfect reconstruction, backend consistency, and various parameter combinations
  • Added benchmark script for performance testing across different configurations
  • Optimized various utility functions (blackman_window, pad_signal, AmpToDB, norm)

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
setup.py Version bump from 0.1.1 to 0.1.2
tests/test_mlx_stft.py Extensive new test suite for STFT/ISTFT with backend tests and reconstruction tests
scripts/benchmark.py New comprehensive benchmark script for performance profiling
requirements-dev.txt Added pytest for testing
mlx_stft/windows.py Optimized blackman_window computation to reduce redundant operations
mlx_stft/utils.py Major additions: overlap_add, compute_window_norm, frame_signal, precompute_inverse_fourier_basis functions; optimizations to pad_signal, norm, AmpToDB
mlx_stft/transforms.py Major refactoring: added ISTFT, CompiledSTFT, CompiledISTFT; refactored STFT to support dual backends
mlx_stft/init.py Updated exports to include new ISTFT and compiled classes
README.md Updated documentation with ISTFT usage examples, features, arguments, and performance benchmarks
.gitignore Expanded to include comprehensive Python and IDE patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_mlx_stft.py
Comment thread README.md
Comment thread setup.py
Comment thread tests/test_mlx_stft.py Outdated
@nuniz nuniz merged commit 6c5529f into main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ISTFT functionality

2 participants