Skip to content

🧪 add edge case test for getHtmlForWebview with empty input #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nur-srijan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 add edge case test for getHtmlForWebview with empty input #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/test/suite/helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ suite('Helpers Test Suite', () => {
});

suite('getHtmlForWebview', () => {
test('should handle empty input correctly', () => {
const html = getHtmlForWebview('');
assert.ok(html.includes('<body'), 'Should contain body tag');
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better test precision, it's advisable to check for the complete opening tag <body>. The current check html.includes('<body') is a bit loose and could potentially pass even if the tag was malformed (e.g., <body-something>). Making the assertion more specific ensures the test is more robust against future regressions.

Suggested change
assert.ok(html.includes('<body'), 'Should contain body tag');
assert.ok(html.includes('<body>'), 'Should contain body tag');

assert.ok(html.includes('</body>'), 'Should contain closing body tag');
});

test('should convert basic Markdown to HTML', () => {
const markdown = '# Hello\n\nThis is **bold** text.';
const html = getHtmlForWebview(markdown);
Expand Down
Loading