[Cheng Deren] iP#367
Open
DerenC wants to merge 52 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seriouslia0
approved these changes
Feb 3, 2023
| return new String[] {}; | ||
| } | ||
|
|
||
| static LocalDateTime parseDateTime(String str) { |
There was a problem hiding this comment.
Might want to store this parser into a seperate class
| System.out.println(" | " + str.substring(0, 64) + " |"); | ||
| int remainingLength = length - 64; | ||
| int leftover = remainingLength % 62; | ||
| int n = (int) Math.floor(remainingLength/62); |
There was a problem hiding this comment.
Might want to split this function into several to make it easier to edit in the future.
wpx12011
reviewed
Feb 5, 2023
wpx12011
left a comment
wpx12011
left a comment
There was a problem hiding this comment.
Good job for following the coding standard closely! Perhaps can implement a Parser class to reduce the amount of contents in the Wessy class.
| @@ -0,0 +1,32 @@ | |||
| import java.time.LocalDateTime; | |||
|
|
|||
| public class Deadline extends Task { | |||
There was a problem hiding this comment.
Perhaps can put this class into a package (like package duke), as other developers could better understand the code base when all the classes have been grouped in packages
| @@ -0,0 +1,397 @@ | |||
| import Exceptions.CommandNotFoundException; | |||
There was a problem hiding this comment.
Great job on importing the classes explicitly, and ordered them in a logical way.
…) methods in Parser
These classes are: Parser UserInputChecker CmdType Task ToDo Deadline Event WessyException CommandNotFoundException MissingSpacingException TimeSpecifierException UnspecifiedTimeException EmptyListException InvalidIntegerException NotAnIntegerException NotPositiveIntegerException MissingInputException TooManyInputException
Use JavaFX technology to implement the GUI.
Refactor the whole code base by extracting out the closely related code as the following components, with their respective function * Parser -- Process user input. * Storage -- Retrieve from existing storage and save as a new file after every update. * Ui -- Handle I/O. * UserInputChecker -- Check and throw exceptions while checking for correct formatting in the user input. Rethink and recategorise the exceptions by merging those that seem closely related. Add TimeSpecifierException on tp of UnspecifiedTimeException to differentiate between the 2 exceptions. Create more packages. Rearrange the code by placing the relevant classes into their respective packages.
Use assert feature (not JUnit assertions) to document importaant assumptions that should hold at various points in the code.
Use the Streams feature of Java in my code, if applicable.
Use Streams
Use Assertions
Improve code quality
Implement the following 2 features: * B-DoAfterTasks * B-FixedDurationTasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wessy, your friendly neighbourhood personal assistant
What I cannot do:
What I can do:
I can even print
hello world, just like you.What you should do everyday:
BEND DOWN TO ME, YOU LOWLY HUMAN