[Qiu Qianhui] iP by QQH0828 · Pull Request #376 · nus-cs2103-AY2223S2/ip

QQH0828 · 2023-01-31T18:31:40Z

Duke

“Your mind is for having ideas, not holding them.” – David Allen (Source)

Duke is a chatbot that frees your mind from having to remember the things you need to do. It's

Text-Based
Easy to learn
~~Fast~~ Super Fast to use

All you need to do is, 👍

Download it from here.
Double-click it
Add your tasks
Let it manage your tasks for you

And it is FREE! 🥳

Features: 👍

Managing tasks
Managing deadlines
Reminders
GUI interface

If you are a random programmer that's looking through this, you can use it to practice Java as well. Here is the main code for the launcher.

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

ShanHng

Code is clean and easy to read! But there is repeated violation of the rule to have the [ ] placed behind the data type instead of variable name. Generally looks great!

ShanHng · 2023-02-01T02:55:20Z

+            throw new DukeException(("☹ OOPS!!! The due date of a deadline cannot be empty.\n"));
+        }
+
+        String info[] = command.split(" /by ");


Perhaps we should put the [] right after the String instead even though this is valid too?

Thanks for pointing them out!

ShanHng · 2023-02-01T02:55:55Z

+
+        String info[] = command.split(" /by ");
        String description = info[0];
        String by = info[1];


Maybe instead of just "by", we can use a variable name that indicates that this is a date?

ShanHng · 2023-02-01T02:57:47Z

+            throw new DukeException("\t ☹ OOPS!!! The description, from date or due date of a event cannot be empty.\n");
+        }
+
+        String info[] = command.split(" /from ");


Perhaps the naming of this variable can be a standard plural noun instead?

ShanHng · 2023-02-01T10:46:21Z

+    }
+
+    public void event(String command) {
+        String info[] = command.split(" ", 2)[1].split(" /from ");


Ooh I like your clever usage of split to distinguish between /to argument and /from argument!

ShanHng · 2023-02-01T10:48:35Z

+    public void addTask(Task task) {
+        tasks[taskIndex] = task;
+        taskIndex++;
+        System.out.println("\t Got it. I've added this task:\n"


I like what you did here - indenting and spacing a sentence into parts that are more readable!

ShanHng · 2023-02-01T10:49:43Z

+    }
+
+    public void deadline(String command) {
+        String info[] = command.split(" ", 2)[1].split(" /by ");


Perhaps we could use a variable name that indicates this is an array? Also, remember to have the square brackets right after the data type~! (String[])

# Conflicts: # src/main/java/Event.java # src/main/java/Deadline.java

# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/Task.java

…2223S2/ip

# Conflicts: # src/main/java/command/AddDeadlineCommand.java # src/main/java/command/AddEventCommand.java # src/main/java/command/AddTaskCommand.java # src/main/java/command/AddTodoCommand.java # src/main/java/command/Command.java # src/main/java/command/DeleteTaskCommand.java # src/main/java/command/ExitCommand.java # src/main/java/command/ListCommand.java # src/main/java/command/MarkTaskCommand.java # src/main/java/storage/Storage.java # src/main/java/userinteraction/Ui.java

Assertions are used to define assumptions about the program state so that the runtime can verify them. Adding assertions in the code statements so that it can check whether the split operations used in the input string result in the correct output. It can help to detect the mistakes in the codes.

Some of the classes had some code quality violation that needed to be fixed according to the code quality rules. Deleting dead code and unused codes so that not trip up readers. Avoiding deep nesting and complicated expressions so that much more easier for reading. Trying to follow the single level of abstraction principle. These are helping to run-time efficiency and understandability.

Add assert statement in the TaskList class

* 'master' of https://github.com/QQH0828/ip: Add assert statement in the TaskList class

Modify the codes based on the code quality

* 'master' of https://github.com/QQH0828/ip: Modify the codes based on the code quality

Adding help command in the Duke to display all available commands with the explanation about how to use each commands.

Add a new line in each classes. Remove whitespace of "trailing whitespace". Add a space before "{". Add and change some java doc.

Mainly from gui part.

Solve the issues about spacing after some commands.

damithc and others added 8 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add Increment Level-1

2abf484

Add Increment Level-2

6e6c66f

Add Increment Level-3 with a new class Task

8e390d2

Add Increments Level-4

63deb9f

Add Increments for Automated Text UI Testing

638fe5e

Add Increment Level-5

fea77b0

Add Increment Level-6

a6d87e4

ShanHng reviewed Feb 1, 2023

View reviewed changes

QQH0828 added 21 commits February 7, 2023 10:18

Add Increment Level -7 as parallel branche with Save method

a57249e

Merge branch 'branch-Level-7'

1bc3b13

Merge branch 'branch-Level-8'

3d7c8f3

# Conflicts: # src/main/java/Event.java # src/main/java/Deadline.java

Add Increments as parallel branche-Level-8 with Dates and Times

f308ef4

Add Increments as parallel branch-Level-7 with Save method

eaeedb9

Merge branch 'branch-Level-7'

db837df

Merge branch 'branch-Level-8'

1e9262f

Solve merge conflict branch-Level-8

e1c0c5e

Merge remote-tracking branch 'origin/master'

858927b

# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/Task.java

Merge branch 'add-gradle-support' of https://github.com/nus-cs2103-AY…

c88a915

…2223S2/ip

Add Increment: A-MoreOOP

817bcee

Add Increment: A-Packages

6a8cd60

Add Increment: A-Gradle

1a75274

Add Increment: A-JUnit

f896222

Add Increments as parallel branches: A-JavaDoc

5e84399

Add Increments as parallel branches: Level-9

06a30bd

Add Increments as parallel branches: Level-9

bc80cb8

Add Increments as parallel branches: A-CodingStandard

2afc403

Merge branch 'branch-A-JavaDoc'

b05471e

Merge branch 'branch-Level-9'

0f3fe17

QQH0828 and others added 30 commits February 16, 2023 01:16

Delete unused classes

d3b4044

Add Increments as branches: Level-10

74bdb53

Merge branch 'branch-Level-10'

ff5718d

Merge pull request #2 from QQH0828/branch-A-Assertions

bc2e9a6

Add assert statement in the TaskList class

Merge branch 'master' of https://github.com/QQH0828/ip

3e7ebc9

* 'master' of https://github.com/QQH0828/ip: Add assert statement in the TaskList class

Merge pull request #3 from QQH0828/branch-A-CodeQuality

2c7366f

Modify the codes based on the code quality

Merge branch 'master' of https://github.com/QQH0828/ip

11b85c6

* 'master' of https://github.com/QQH0828/ip: Modify the codes based on the code quality

Merge branch 'master' into branch-A-Assertions

da2cede

Merge branch 'master' into branch-A-CodeQuality

9e36d1c

Merge branch 'branch-A-Assertions'

4ef0415

Merge branch 'branch-A-CodeQuality'

4b65663

Add Increment: A-CI

f7f30c0

Add an extension: C-Help

3a8547a

Adding help command in the Duke to display all available commands with the explanation about how to use each commands.

Merge branch 'branch-C-Help'

786fd75

Fix CheckStyle errors

9e53f70

Add a new line in each classes. Remove whitespace of "trailing whitespace". Add a space before "{". Add and change some java doc.

Add a unique personality

85a4776

Mainly from gui part.

Resolve the command error

6882f68

Solve the issues about spacing after some commands.

Fix the import format order issues

ac99812

Fix import format in parser class

3b97191

Fix checkstyle error

9ff9abb

Add java doc in ui class

26f91eb

Fix checkstyle error of DeadlineTest and DateTimeTest classes

832d46a

Fix the checkstyle error in the DateTimeTest class

f7536e5

Set up a product website with a representative screenshot and user guide

abd962b

Add help command in the user guide

769a11d

Finalize the features

b5d8dc4

Fix no match tasks while using find command

8cd75f8

Fix some errors to make it more user friendly

a19d9e3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qiu Qianhui] iP#376

[Qiu Qianhui] iP#376
QQH0828 wants to merge 60 commits into
nus-cs2103-AY2223S2:masterfrom
QQH0828:master

QQH0828 commented Jan 31, 2023 •

edited

Loading

Uh oh!

ShanHng left a comment

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

QQH0828 Feb 5, 2023

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

ShanHng Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

QQH0828 commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Duke

Uh oh!

ShanHng left a comment

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

QQH0828 Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

ShanHng Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

QQH0828 commented Jan 31, 2023 •

edited

Loading