[Liu Xuyan] iP by Flaaaash · Pull Request #185 · nus-cs2113-AY2425S2/ip

Flaaaash · 2025-02-06T14:57:02Z

Add Task class to manage tasks.
Add addTask() method to add tasks.
Add List() method to allow users to view the stored tasks.
Add markTask() and unmarkTask() to manage the status of a task.

himethcodes · 2025-02-07T03:52:58Z

+
+    private static void markTask(int index) {
+        System.out.println("____________________________________________________________");
+        if (index < 0 || index > taskCount) {


The condition should be index <= 0 || index > taskCount to properly handle cases where index = 0.

himethcodes · 2025-02-07T06:23:19Z

+
+    @Override
+    public String toString() {
+        return "[E]" + super.toString() + " (from: " + from + " to: " + to + ")";


Lack of spacing after "[E]" reduces readability.I think it's better if can add return "[E] " + super.toString() + " (from: " + from + " to: " + to + ")"; like this

himethcodes · 2025-02-07T06:27:16Z

+            default:
+                repeat(command);
+            }
+        }


The class is well-structured with clear separation of concerns.

HightechTR · 2025-02-07T06:40:56Z

@@ -0,0 +1,26 @@
+public class Task {
+    protected String taskName;
+    protected boolean isDone;


Good naming of boolean variables

HightechTR · 2025-02-07T06:45:15Z

+
+    public void unmarkAsDone() {
+        this.isDone = false;
+    }


Can use a single setter public void setDone(boolean isDone) here

HightechTR · 2025-02-07T06:53:47Z

@@ -0,0 +1,13 @@
+public class Deadline extends Task {
+    protected String deadLine;


Depends on how you view the word Deadline, but if this is one word, it should be all lowercase like deadline

HightechTR · 2025-02-07T06:55:10Z

+public class Flaaaash {
+    private static final int maxCount = 100;
+    private static final Task[] tasks = new Task[maxCount];
+    private static int taskCount = 0;


Good naming standard for the tasks array

sweetFish8 · 2025-02-07T06:55:14Z

+public class Todo extends Task {
+    public Todo(String taskName) {
+        super(taskName);
+    }
+
+    @Override
+    public String toString() {
+        return "[T]" + super.toString();
+    }
+}


Is it the same as Task class?

sweetFish8 · 2025-02-07T06:58:23Z

+
+    @Override
+    public String toString() {
+        return "[D]" + super.toString() + " (by: " + deadLine + ")";


I noticed the same issue in several other places too as himethcodes mentioned(spacing)

sweetFish8 · 2025-02-07T06:59:06Z

@@ -0,0 +1,13 @@
+public class Deadline extends Task {
+    protected String deadLine;


You can just name it deadline cause it is single word

sweetFish8 · 2025-02-07T07:11:24Z

+                break;
+
+            case "deadline":
+                String[] deadlineInputDetails = inputParts[1].split(" /by ", 2);


You can handle with the error with splitting string

sweetFish8 · 2025-02-07T07:31:41Z

+    private static final int maxCount = 100;
+    private static final Task[] tasks = new Task[maxCount];


Avoiding the use of magic number very well

tongkiankiat

Code is well structured and neat, good job adding in switch case statements to introduce different methods for different inputs!

tongkiankiat · 2025-02-07T07:37:28Z

+        greet();
+        Scanner scanner = new Scanner(System.in);
+
+        while (true) {


Nice use of switch-case statements to avoid deep nesting!

tongkiankiat · 2025-02-07T07:40:20Z

+            tasks[index - 1].markAsDone();
+            System.out.println("    " + tasks[index - 1]);
+        }
+        System.out.println("____________________________________________________________");


This magic string could be stored in a variable, since it is used multiple times

tongkiankiat · 2025-02-07T07:45:53Z

+    }
+
+    private static void addTask(Task task) {
+        tasks[taskCount] = task;


Good naming convention for singular nouns and plural nouns.

tongkiankiat · 2025-02-07T07:48:00Z

+        System.out.println("____________________________________________________________");
+        System.out.println(" Got it. I've added this task:");
+        System.out.println("    " + tasks[taskCount - 1]);
+        System.out.println(" Now you have " + taskCount + " tasks in the list.");


Could add in the different spelling for 'task' when there is only 1 task and when there are multiple tasks

…sizes.

aditichadha1310 · 2025-02-27T05:53:02Z

+        System.out.println("  " + tasks.get(index - 1));
+        tasks.remove(tasks.get(index - 1));
+        System.out.println(" Now you have " + tasks.size() + " tasks in the list.");
+        System.out.println("____________________________________________________________");


Avoid repeating this code line. Store it in a variable or make it a function and use it multiple times.

aditichadha1310 · 2025-02-27T05:53:26Z

+        }
+    }
+
+    private static void loadFromFile() {


Keep the method length to about 30 lines of code

aditichadha1310 · 2025-02-27T05:53:43Z

+        try {
+            Scanner fileScanner = new Scanner(file);
+            while (fileScanner.hasNextLine()) {
+                String line = fileScanner.nextLine();
+                String[] parts = line.split(" / ");
+
+                try {
+                    String type = parts[0];
+                    boolean isDone = parts[1].equals("1");
+                    String description = parts[2];
+
+                    switch (type) {
+                    case "T":


Avoid the arrow head style code

Create package for command, ui, parser, data, common, storage and exception.

Write MESSGAE_USAGE for all command subclasses.

Update relevant classes (HelpCommand, Parser) for newly added class.

Add FindCommand class.

…ial private methods.

Add header comments to most non-private classes/methods, and non-triv…

Improve the level of abstraction of Parser class

Flaaaash added 3 commits January 31, 2025 17:16

Add Flaaaash remove Duke.

219f7a4

Add increment 1-3. Add Task class

c85bf1c

Add sub-classes Todo, Deadline and Event of Task class.

f915452

himethcodes reviewed Feb 7, 2025

View reviewed changes

HightechTR reviewed Feb 7, 2025

View reviewed changes

sweetFish8 reviewed Feb 7, 2025

View reviewed changes

tongkiankiat reviewed Feb 7, 2025

View reviewed changes

Flaaaash added 9 commits February 14, 2025 12:05

Level-5. Exception handling

ef0e0e5

Merge branch 'branch-Level-5'

85505a1

Add deleteTask(). Change tasks array to a ArrayList type for dynamic …

97802b2

…sizes.

Add save and load methods.

fc1b49a

Level-7

49f4871

Merge branch 'master' into branch-Level-6

9afe0b6

Merge branch 'branch-Level-7'

114008a

Fixed a naming conflict.

a669331

A-Packages

790d185

aditichadha1310 reviewed Feb 27, 2025

View reviewed changes

Flaaaash and others added 13 commits March 14, 2025 06:51

Apply a more OOP design

237eb84

Create package for command, ui, parser, data, common, storage and exception.

Completed HelpCommand class.

7dc40ad

Write MESSGAE_USAGE for all command subclasses.

Add FindCommand class to handle level-9 task finding matching task.

b02cb4c

Update relevant classes (HelpCommand, Parser) for newly added class.

Merge pull request #1 from Flaaaash/branch-Level-9

446f8e5

Add FindCommand class.

Merge branch 'master' of https://github.com/Flaaaash/ip

856350a

Add header comments to most non-private classes/methods, and non-triv…

4bcfc50

…ial private methods.

Merge pull request #2 from Flaaaash/branch-A-JavaDoc

dc40b48

Add header comments to most non-private classes/methods, and non-triv…

Merge branch 'master' of https://github.com/Flaaaash/ip

433eba8

Update README.md (unfinished).

8d595d9

Minor changes.

0884152

Finished User Guide.

989918e

Update Release link in README.md.

1e5f56c

Change StorageFile default storage path to save by file name.

ab5fc69

Improve the level of abstraction of Parser class

Remove local data.

02d6c4b

		@@ -0,0 +1,13 @@
		public class Deadline extends Task {
		protected String deadLine;

		private static final int maxCount = 100;
		private static final Task[] tasks = new Task[maxCount];

Conversation

Flaaaash commented Feb 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tongkiankiat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants