[CS2113-W13-3] FinBro#50
Open
ljunfun wants to merge 397 commits into
Open
Conversation
# Conflicts: # src/test/java/seedu/finbro/logic/command/SearchCommandTest.java
adds test cases for Search feature v1.0
… TestingBranch # Conflicts: # src/test/java/seedu/finbro/logic/command/SearchCommandTest.java
Logging and assertions: FilterCommand & SummaryCommand
adds tests for duplicate check when creating new income / expense transaction
Fix magic number
Fixes annoying github gradle issues
adds valuable assertion
DG: sequence diagrams description
Quick fixes
ultimate anti-corruption
Quick additions to documentation
fix: during cold start, log will appear below enter command
Update DeleteCommand and UI
Update PPP
Typos for PPP
Update notgiggs.md
updates denzel's PPP
Lyam-T
reviewed
Apr 10, 2025
| * *glossary item* - Definition | ||
| Storage <--> FileSystem[(File System)] | ||
|
|
||
| ## Instructions for manual testing |
There was a problem hiding this comment.
It will be more helpful if diagram is included instead, it can be autogenerated in plantuml as we
|
|
||
| ## Component Details | ||
|
|
||
| ### Main Component |
There was a problem hiding this comment.
It is suggested to add more description other than the diagrams such that the concept can be explained more clearly
| **1. Single Transaction Class with Type Enum** | ||
|
|
||
| ```java | ||
| class Transaction { |
There was a problem hiding this comment.
This will be nicer if it is explained by words or sequence diagram instead of codes directly
| RuntimeException <|-- NegativeNumberException : extends | ||
| ``` | ||
|
|
||
| ## Class Structure |
There was a problem hiding this comment.
I like how the class diagram is listed with comment here for the overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FinBro is a powerful Command Line Interface (CLI) application designed to help you take control of your personal finances. With its fast and efficient command-based interface, FinBro makes tracking expenses, managing income, and monitoring your financial health easier than ever before.