[CS2113-T12-1] MediNote#62
Open
Li-JunXian wants to merge 390 commits into
Open
Conversation
Updated delete doctor, discharge patient functions
…-branch-update-delete-doctor-function Each function now removes corresponding info in other persons' attributes. Delete doctor removes doctor name in patient's doctorAssigned attribute. Discharge patient removes patient name from doctor's patientsBeingTreated attribute.
Viewing-Patient-Doctor-Attributes-And-Statistics
Added JUnit tests for delete doctor function
Added JUnit tests for delete doctor function
…-jUnit-tests Branch delete doctor j unit tests
…Patients, as well as some cleaning up of codes.
For [Issue #67] Implement Data Storage of all information related to the Doctors and Patients, as well as some cleaning up of codes.
…function For [Issue #67] Merge branch-dataStorage-function into master
wenxin-c
reviewed
Mar 29, 2025
wenxin-c
left a comment
wenxin-c
left a comment
There was a problem hiding this comment.
Overall good work so far. There are some comments for your consideration. Keep it up!!
Comment on lines
+1
to
+5
| <<<<<<< HEAD | ||
| # MediNote template | ||
| ======= | ||
| # MediNote project template | ||
| >>>>>>> upstream/master |
There was a problem hiding this comment.
Please remove the arrow heads and separation line due to merge conflicts after resolving them.
|
|
||
| public static void listAllDoctors(ArrayList<Doctor> doctorList) { | ||
| printListDoctorHeader(doctorList.size()); | ||
| int doctorIndex = 1; |
There was a problem hiding this comment.
You might consider converting magic numbers or literals into named constant so that it will be easier to understand, maintain and reuse in your code.
| private static final String LINE_BREAK = "===============================================" + | ||
| "==============================================="; | ||
|
|
||
| public static void ShowStatistics(){ |
There was a problem hiding this comment.
You might consider abstracting this long method into several smaller methods, e.g. a separate method for each stats calculation then use the calculated stats in final calculation.
| private static final String LINE_BREAK = "===============================================" + | ||
| "==============================================="; | ||
|
|
||
| public static void PrintDoctorAttributes(String attribute){ |
There was a problem hiding this comment.
The first letter should be small letter for method name, i.e. printDoctorAttributes.
Comment on lines
+23
to
+57
| case "name": | ||
| for (int i = 0; i < doctors.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + doctors.get(i).getName()); | ||
| System.out.println(LINE_BREAK); | ||
| } | ||
| break; | ||
| case "specialisation": | ||
| for (int i = 0; i < doctors.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + doctors.get(i).getName() + ": " + doctors.get(i).getSpecialisation()); | ||
| System.out.println(LINE_BREAK); | ||
| } | ||
| break; | ||
| case "availability": | ||
| for (int i = 0; i < doctors.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + doctors.get(i).getName() + ": " + doctors.get(i).getAvailability()); | ||
| System.out.println(LINE_BREAK); | ||
| } | ||
| break; | ||
| case "patients": | ||
| for (int i = 0; i < doctors.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + doctors.get(i).getName() + ": " + doctors.get(i).getPatientsBeingTreated()); | ||
| System.out.println(LINE_BREAK); | ||
| } | ||
| break; | ||
| case "count": | ||
| for (int i = 0; i < doctors.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + doctors.get(i).getName() + ": " + doctors.get(i).getNumPatientsTreated() + " number of patients treated"); | ||
| System.out.println(LINE_BREAK); | ||
| } | ||
| break; |
There was a problem hiding this comment.
There shouldn't be extra indentation in front of case clauses.
E.g.
Comment on lines
+24
to
+28
| for (int i = 0; i < patients.size(); i++) { | ||
| System.out.println(LINE_BREAK); | ||
| System.out.println((i + 1) + ". " + patients.get(i).getName()); | ||
| System.out.println(LINE_BREAK); | ||
| } |
There was a problem hiding this comment.
Since each of the case block is pretty similar, you might consider abstracting it into a separate method and pass in parameters to decide which method to call/which attribute to get.
| import java.nio.file.Files; | ||
| import java.nio.file.Paths; | ||
|
|
||
| public class ensureFilesExist { |
There was a problem hiding this comment.
Class name must be noun and written in PascalCase, i.e. the first letter must be capital letter as well.
Complete Clean-up of the code based on errors identified by GitHub in-built "build (ubuntu-latest)" test.
Ashertan256
pushed a commit
to Ashertan256/tp
that referenced
this pull request
Mar 30, 2025
Add DG content for Group class
Added user stories, product scope.
Branch 0204 updates
Started on Developer Guide, read desc
Branch user guide
Update UserGuide
Branch user guide
Merge branch 'branch-DG-V1' of https://github.com/AY2425S2-CS2113-T12-1/tp into branch-Developer-Guide
…itecture of MediNote added. Made a diagram and png of overall architecture.
Started on Design and Implementation in Developer Guide. Overall arch…
Developer Guide: Added overall architecture information under design and implementation. Read desc
…-1/tp into branch-Developer-Guide
Branch pe d cj143n
Branch datetime timestamp
Remove redundant trims and empty spaces, update junit test code
Fix indentation levels
Made admission timestamp to be in a datetime format
Branch pe d cj143n
Big changes to update command and reflected it in UG
Branch pe d siqiangz
Updated DG with sequence diagrams for update, patient, doctor functions
Branch pe d siqiangz
Update DG, PPP and AboutUs
Branch pe d siqiangz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediNote is a desktop app for managing hospital information such as doctor and patient records, optimised for use via a Command Line Interface (CLI).