[CS2113-W14-3] FitChasers by ZhongBaode · Pull Request #9 · nus-cs2113-AY2526S1/tp

ZhongBaode · 2025-09-17T07:24:37Z

FitChaser is a Command Line Interface (CLI)-based fitness tracking app designed for NUS
gym-goers. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands

User greet and J-Unit test

NigelYeoTW

Overall lgtm, good progress, keep it up 🔥

NigelYeoTW · 2025-10-19T16:42:41Z

+     */
+    public Person(String name) {
+        setName(name); // reuse setter để kiểm tra name
+        this.weightHistory = new ArrayList<>();


Any reason why the variable is not instantiated during declaration?

NigelYeoTW · 2025-10-19T16:43:21Z

+     * @throws IllegalArgumentException if name is null or empty
+     */
+    public Person(String name) {
+        setName(name); // reuse setter để kiểm tra name


Comments should be in as per coding standards

NigelYeoTW · 2025-10-19T16:49:34Z

+     *
+     * @return true if a record was removed, false if no records exist
+     */
+    public boolean removeLatestWeightRecord() {


Perhaps could make the method sound more like a boolean

NigelYeoTW · 2025-10-19T16:52:05Z

+     */
+    public Exercise(String name, int reps) {
+        this.name = name;
+        this.sets = new ArrayList<>();


Any reason why this is not initialised on declaration

NigelYeoTW · 2025-10-19T16:53:12Z

+    public Exercise(String name, int reps) {
+        this.name = name;
+        this.sets = new ArrayList<>();
+        this.sets.add(reps);


Any reason why you did you just use your defined method to add reps for the class?

NigelYeoTW · 2025-10-19T17:29:37Z

+        if(dateStr.isEmpty()) {
+            dateStr = LocalDate.now().format(DateTimeFormatter.ofPattern("dd/MM/yy"));
+            ui.showMessage("You missed out the date! Using current date: " + dateStr);
+        }
+        if(timeStr.isEmpty()) {
+            timeStr = LocalTime.now().format(DateTimeFormatter.ofPattern("HHmm"));
+            ui.showMessage("You missed out the time! Using current time: " + timeStr);
+        }


Perhaps ensure whitespace consistency

NigelYeoTW · 2025-10-19T17:34:05Z

+            ui.showMessage("No workouts recorded yet!");
+            return;
+        }
+
+        for (int i = 0; i < workouts.size(); i++) {
+            Workout w = workouts.get(i);
+            ui.showMessage("------------------------------------------------");
+            ui.showMessage("[" + (i + ARRAY_OFFSET) + "]: " + w.getWorkoutName() +


Perhaps UI can have functions to output these?

NigelYeoTW · 2025-10-19T17:34:34Z

+            if (w.getExercises().isEmpty()) {
+                ui.showMessage("     No exercises added yet.");
+            } else {
+                for (int j = 0; j < w.getExercises().size(); j++) {
+                    Exercise ex = w.getExercises().get(j);
+                    ui.showMessage("     Exercise " + (j + 1) + ". " + ex);
+                    for (int k = 0; k < ex.getSets().size(); k++) {
+                        ui.showMessage("         Set " + (k + 1) + " -> Reps: " + ex.getSets().get(k));
+                    }
+                }
+            }
+        }
+    }


Perhaps try to reduce nesting for readability

NigelYeoTW · 2025-10-19T17:35:18Z

+            boolean usedDefaultDate = false;
+            boolean usedDefaultTime = false;


Perhaps variables can sound more like booleans

NigelYeoTW · 2025-10-19T17:37:23Z

+     * @param scanner Scanner for reading user input in the retry loop
+     * @param initialArgs Initial command arguments containing end date/time details
+     */
+    public void endWorkout(Scanner scanner, String initialArgs) {


perhaps refactor this methods as it seems to be quite long, the logic paths could also be made more readable

XuHh03 · 2025-10-29T02:12:17Z

+Given below is a quick overview of main components and how they interact with each other.
+
+#### Main components of the architecture
+![Alt text](docs/diagrams/FitChaser_Architecture.jpg "Basic Architecture")


Is this suppose to be a picture?

XuHh03 · 2025-10-29T02:16:31Z

+At app launch, it initializes and loads the components and data in the correct sequence, and connects them up with each other.
+At shut down, it shuts down the other components and invokes cleanup methods where necessary.

+The bulk of the app’s work is done by the following six components:


Should it be in point format instead, its a continuous line now

XuHh03 · 2025-10-29T02:22:20Z

+and tags are auto-generated:
+![Alt text](../docs/diagrams/Sequence Digram for tagging.png "Sequence Diagram for Tagging")
+### Sequence Diagram for creating a workout
+![Sequence diagram for creating a workout](diagrams/SD_createw.png)


Would you consider using plantUML on IDE to create the diagram, because handwritten diagrams can be hard to read

XuHh03 · 2025-10-29T02:26:32Z

+### Sequence Diagram for creating a workout
+![Sequence diagram for creating a workout](diagrams/SD_createw.png)
+### Sequence Diagram for adding an exercise to current workout
+![Sequence diagram for adding an exercise](diagrams/SD_addex.png)


Is the activation bar suppose to continue after return Exercise?

XuHh03 · 2025-10-29T02:29:54Z

+* Higher computational cost
+* Difficult to debug and test
+
+Rationale: ALternative 1 was chosen for simplicity and predictability. For a CLI Fitchaser,


Is ALternative a typo?

XuHh03 · 2025-10-29T02:45:53Z

+This enables users to quickly identify workout types and track training patterns over time.
+
+### Class Diagram
+![Alt text](../docs/diagrams/Class_Diagram_for_tagging_2.png "Class Diagram for Tagging")


Is this the same issue as above, as the image is not displaying?

I am getting the same issue, there is no class diagram image showing

ry-koh

Overall, good job on the Developer Guide, it is very in depth, just some minor formatting issues and diagram problems.

ry-koh · 2025-10-29T04:30:38Z

+## UI Component
+The API of this component is specified in seedu.fitchasers.ui.UI.
+
+![img.png](img.png)


For the class diagram, I think there should not be the circle with the C indicating class.

ry-koh · 2025-10-29T04:32:33Z

+## UI Component
+The API of this component is specified in seedu.fitchasers.ui.UI.
+
+![img.png](img.png)


I think this UML diagram does not follow the convention of our module. There should not be the 'Constants', 'State', 'Ctor', 'Input API', 'Output API', 'Chat Bubble Logic (helpers)' headers.

ry-koh · 2025-10-29T04:35:09Z

+## UI Component
+The API of this component is specified in seedu.fitchasers.ui.UI.
+
+![img.png](img.png)


I think there should also not be the {readOnly} in the constants section. Also, should the constants section be in the class diagram?

ry-koh · 2025-10-29T04:36:37Z

+a user's weight and goal weight. It works together with the `Person` entity to maintain a complete
+history of weight entries.
+
+![Alt text](docs/diagrams/WeightManager_Class_Diagram.png "Basic Architecture")


The image does not seem to be loading properly.

ry-koh · 2025-10-29T04:37:18Z

+
+The `GoalWeightTracker` component handles the user's target goal weight. It works together with the `FileHandler` to persist goal data and provides feedback comparing the goal with the user's latest recorded weight.
+
+![Alt text](docs/diagrams/GoalWeightTracker_Class_Diagram.png "Basic Architecture")


The image does not seem to be loading properly.

ry-koh · 2025-10-29T04:42:18Z

+### Sequence Diagram for adding an exercise to current workout
+![Sequence diagram for adding an exercise](diagrams/SD_addex.png)
+### Sequence Diagram for adding a set to the current exercise 
+![Sequence diagram for adding a set](diagrams/SD_addset.png)


I think the words might be a bit too small after converting to PDF.

ry-koh · 2025-10-29T04:43:34Z

+* More complex override logic
+
+Rationale: Alternative 1 was chosen as the separation provides clearer semantics and aligns with the use
+case where users may want to distinguish between automatic suggestions and their own categorization.


I think there is a formatting issue here with an extra indentation.

ry-koh · 2025-10-29T04:45:36Z

+* Add a `filterByTag(String tag)` method to `WorkoutManager`
+* Modify `Workout.getAllTags()` to support efficient tag lookups
+#### Proposed feature: Display aggregate statistics grouped by tag
+Example command: `/stats --by-tag`


Another formatting issue here

# Conflicts: # src/main/java/seedu/fitchasers/FileHandler.java

Fixing bugs

# Conflicts: # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Enhanced chat interface

# Conflicts: # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Edge cases bug fix

# Conflicts: # src/main/java/seedu/fitchasers/ui/ViewLog.java # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Pavithra6-Srinivasan

Most of your diagrams are not showing but other than that its a very detailed DG, good job!

Pavithra6-Srinivasan · 2025-10-30T03:09:45Z

+#### How the architecture components interact with each other
+
+The Sequence Diagram below shows how the components interact with each other for the scenario where the user issues the command /create_workout pushup.
+![Alt text](../docs/diagrams/Architectural_Sequence_Diagram_CW.png "Basic Architecture Sequence Diagram")


I am not able to see you sequence diagram

Pavithra6-Srinivasan · 2025-10-30T03:14:01Z

+- Listens to model changes indirectly: Domain managers return updated entities/strings; UI redraws views (e.g., ViewLog.render(...) for monthly logs).
+
+
+Responsibilities


would be easier to read if this section was in point form

Pavithra6-Srinivasan · 2025-10-30T03:14:37Z

+
+The `WorkoutManager` component is responsible for managing all workout-related operations in FitChasers, including 
+workout creation, exercise tracking, and workout history management.
+![Alt text](docs/diagrams/WorkoutManager_class_diagram.png "Basic Architecture")


I am not able to see this class diagram

Lee-YiSheng

overall good sequence diagram in general, easy to understand. As other has commented, may be better to use UML diagram instead of hand written notes

Lee-YiSheng · 2025-10-30T03:20:57Z

+This enables users to quickly identify workout types and track training patterns over time.
+
+### Class Diagram
+![Alt text](../docs/diagrams/Class_Diagram_for_tagging_2.png "Class Diagram for Tagging")


I am getting the same issue, there is no class diagram image showing

Lee-YiSheng · 2025-10-30T03:27:05Z

+### Sequence Diagram for creating a workout
+![Sequence diagram for creating a workout](diagrams/SD_createw.png)
+### Sequence Diagram for adding an exercise to current workout
+![Sequence diagram for adding an exercise](diagrams/SD_addex.png)


Should the workout instance line be angled?

Lee-YiSheng · 2025-10-30T03:33:41Z

+### Sequence Diagram for creating a workout
+![Sequence diagram for creating a workout](diagrams/SD_createw.png)
+### Sequence Diagram for adding an exercise to current workout
+![Sequence diagram for adding an exercise](diagrams/SD_addex.png)


Should method returns, showMessage() and displaySuccessMessage be single filled arrows?

is showmessage() following the correct naming convention?
is display success message also following the correct method naming convention?

Lee-YiSheng · 2025-10-30T03:45:14Z

+### Sequence Diagram for creating a workout
+![Sequence diagram for creating a workout](diagrams/SD_createw.png)
+### Sequence Diagram for adding an exercise to current workout
+![Sequence diagram for adding an exercise](diagrams/SD_addex.png)


Is this the correct self-invocation notation?

…e/tp into Adjusting-Open-by-index-params

Updated open log using standard params

Solve PPP Format Issue

Updated RepoSense Link

Help UI fix

Add object diagram

Added object diagrams

# Conflicts: # src/main/java/seedu/fitchasers/FileHandler.java # src/main/java/seedu/fitchasers/ui/ViewLog.java # src/main/java/seedu/fitchasers/user/Person.java

ZhongBaode changed the title ~~[CS2113-W14-3]~~ [CS2113-W14-3] FitChasers Sep 17, 2025

danielkwan2004 pushed a commit to danielkwan2004/tp that referenced this pull request Oct 14, 2025

Merge pull request nus-cs2113-AY2526S1#9 from JianHao24/User-Greet

29dfb17

User greet and J-Unit test

NigelYeoTW reviewed Oct 19, 2025

View reviewed changes

XuHh03 reviewed Oct 29, 2025

View reviewed changes

ry-koh reviewed Oct 29, 2025

View reviewed changes

Zhong Baode and others added 22 commits October 29, 2025 18:39

Changing back to readable file

1ebdf60

Merge branch 'master' into 193_User_editable_File

f88238c

# Conflicts: # src/main/java/seedu/fitchasers/FileHandler.java

Bug fix on gym_where and gym_page

cce9263

Bug fixes from user input

ed61d6a

Fix bug for owerride current tag

e4d6b49

CLI fixes

1b3ba7a

Merge branch 'master' into Fixing-bugs

b44c4ad

Improve logic to make input handling robust

53cd93f

Merge pull request #195 from Kart04/Fixing-bugs

6e144a8

Fixing bugs

Merge branch 'master' into nitin-bug-fixes

99d7bd6

# Conflicts: # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Bug fixes after merge conflict was resolved

cb62918

Enhanced chat interface

0517269

CI fixes

ad84b79

Updated to human readable file type

265ff80

Enhanced chat interface

dd1efbb

Merge pull request #197 from Exceptional-Khoi/184-enhance-chat-interface

e392377

Enhanced chat interface

CI bug fix

e84d5cf

Merge branch 'master' into nitin-bug-fixes

c46ac28

# Conflicts: # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Fix merge conflict

f0b2856

CI fixes

dc97772

Merge pull request #196 from nitin19011/nitin-bug-fixes

6c7121e

Edge cases bug fix

Merge branch 'master' into 193_User_editable_File

0bebd5e

# Conflicts: # src/main/java/seedu/fitchasers/ui/ViewLog.java # src/main/java/seedu/fitchasers/workouts/WorkoutManager.java

Pavithra6-Srinivasan reviewed Oct 30, 2025

View reviewed changes

Lee-YiSheng reviewed Oct 30, 2025

View reviewed changes

Fixed auto-detected errors

3e90ad8

bennyy117 and others added 30 commits November 4, 2025 12:29

Add object diagram

b064d2d

Merge branch 'master' into 267-object-diagram

164cac9

Updated open log using standard params

05b4c53

Merge branch 'master' into Adjusting-Open-by-index-params

ba06c20

Fixing UI check test

72f132b

Add object diagram

175f23a

Updated UG/DG for open

5e7dec6

Updated help command

e5fb1db

Updated help command

f9f507a

Merge branch 'Adjusting-Open-by-index-params' of github.com:ZhongBaod…

b3132d6

…e/tp into Adjusting-Open-by-index-params

Updated deleteWorkout test

3e99b75

Merge pull request #299 from ZhongBaode/Adjusting-Open-by-index-params

cec4128

Updated open log using standard params

Solve PPP Format Issue

de8861b

Merge pull request #300 from ZhongBaode/Adjusting-Open-by-index-params

22d53e4

Solve PPP Format Issue

Updated RepoSense Link

e0653e7

Merge pull request #301 from ZhongBaode/UpdateRepoSenseLink

357e7ea

Updated RepoSense Link

Add object diagram

cc07de9

Merge branch 'master' into 267-object-diagram

7e659c5

Help UI fix

b76e5ea

Add object diagram

059b534

Added object diagrams

882d66b

Merge pull request #303 from ZhongBaode/UpdateRepoSenseLink

11beb86

Help UI fix

Add object diagram

6ac0f0c

Added object diagrams

55be454

Merge branch 'master' into 267-object-diagram

d598e78

Merge pull request #302 from bennyy117/267-object-diagram

1fefe36

Add object diagram

Added object diagrams

f08e977

Merge pull request #304 from Exceptional-Khoi/267-add-object-diagrams

ff5d400

Added object diagrams

Merge branch 'master' into 193_User_editable_File

fda9ded

# Conflicts: # src/main/java/seedu/fitchasers/FileHandler.java # src/main/java/seedu/fitchasers/ui/ViewLog.java # src/main/java/seedu/fitchasers/user/Person.java

Fix UI test

6308cb4

		boolean usedDefaultDate = false;
		boolean usedDefaultTime = false;


		The `GoalWeightTracker` component handles the user's target goal weight. It works together with the `FileHandler` to persist goal data and provides feedback comparing the goal with the user's latest recorded weight.

		![Alt text](docs/diagrams/GoalWeightTracker_Class_Diagram.png "Basic Architecture")

		- Listens to model changes indirectly: Domain managers return updated entities/strings; UI redraws views (e.g., ViewLog.render(...) for monthly logs).


		Responsibilities

Conversation

ZhongBaode commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NigelYeoTW left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ry-koh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pavithra6-Srinivasan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lee-YiSheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhongBaode commented Sep 17, 2025 •

edited

Loading