fix(document): skip no-op YAML rewrites on editor open - #547
Open
TotomInc wants to merge 1 commit into
Open
Conversation
Contributor
|
@TotomInc is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #546.
Opening a page in the visual editor was enough to rewrite
::componentYAML (key order + omitted Vue defaults) and, on the next open, surface a Git vs Website conflict. This PR stops those silent writes and keeps authored prop order when the component form saves.onUpdateso mounting the stored document does not write a draftisMatchingContentsays the rendered document matches the file on disk::media-sectionYAML-order case inisDocumentMatchingContent, plus form-prop round-trip testsRelated: #356, #382, #544.
Out of scope
checkConflictstill has a raw-string fallback after structural comparelegacy.tsunbind order andgetOrderedSchemaKeysalphabetical frontmatter sort are unchangedTest plan
content/index.mdin studio-repro) without editing —git statusstays cleanimageSize: 1/2) are not written into the YAML