Clean up handling of Legion config options#670
Open
manopapad wants to merge 6 commits intonv-legate:branch-24.03from
Open
Clean up handling of Legion config options#670manopapad wants to merge 6 commits intonv-legate:branch-24.03from
manopapad wants to merge 6 commits intonv-legate:branch-24.03from
Conversation
jjwilke
requested changes
Apr 7, 2023
jjwilke
approved these changes
Apr 7, 2023
Contributor
jjwilke
left a comment
There was a problem hiding this comment.
LGTM. Installation works and checks correctly catch errors.
trxcllnt
requested changes
Apr 10, 2023
Comment on lines
+75
to
+77
| if(NOT Legion_USE_Python) | ||
| message(FATAL_ERROR "Legion was not compiled with Legion_USE_Python") | ||
| endif() |
Contributor
There was a problem hiding this comment.
This makes it impossible to build the legate C++ library without Legion built w/ Python bindings. Is this really what we want?
Contributor
Author
There was a problem hiding this comment.
This change is my attempt at avoiding the following fell-bad scenario:
- user builds Legion separately, forgets to add python support
- user builds legate.core C++ bits using
cmakedirectly - users does
pip install - user realizes nothing is working, because they built Legion w/o Python support (and the build process never complained)
I would also be ok with a situation where the cmake build doesn't enforce Legion_USE_Python, and instead that becomes necessary only when you try to install the python pieces of legate.core. Do you think that's possible/preferable? Or maybe you have a different approach to avoid this scenario?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install, the Legion build that cmake did will automatically be compatible with the python layer. We could just change the default to be ON everywhere, but I don't see a reason why we need to support Legion builds w/o python and bindings, but maybe folks have a different opinion.install.py, and leave a note to put those in the cmake configuration. As is we run the risk that developers will only updateinstall.pyand forget to update the cmake-only defaults.