Update Thrust to the latest version#802
Closed
marcinz wants to merge 2 commits intonv-legate:branch-24.03from
Closed
Update Thrust to the latest version#802marcinz wants to merge 2 commits intonv-legate:branch-24.03from
marcinz wants to merge 2 commits intonv-legate:branch-24.03from
Conversation
marcinz
added
the
category:improvement
Contributor
|
I think we can stick to thrust 1.17 for now, and avoid having to bump our minimum CTK version. It appears that thrust is moving towards a model where thrust, cub and libcu++ are distributed together, and don't depend on specific CTK versions. Once https://github.com/nvidia/cccl and the corresponding conda package https://anaconda.org/conda-forge/cuda-cccl-impl are mature we can switch to those. |
Collaborator
Author
|
Rapids cmake has been updated for the new Thrust: rapidsai/rapids-cmake#399 They apply quite a few patches and install their own libcudacxx. I will check if that works with the older CTK. |
Contributor
Collaborator
Author
|
/ok to test |
manopapad
added a commit
that referenced
this pull request
Mar 5, 2025
* fixing collective logic for broadcasted regions * Bump legion * Don't read the region requirement if it's a future --------- Co-authored-by: Manolis Papadakis <mpapadakis@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update will have impact on the CTK requirement. There is be a corresponding cunumeric PR to test the impact of the update on cunumeric: nv-legate/cupynumeric#1006