Simple addition enabling the passing of scalar arguments to Reduce#942
Open
JosephGuman wants to merge 2 commits intonv-legate:branch-24.03from
Open
Simple addition enabling the passing of scalar arguments to Reduce#942JosephGuman wants to merge 2 commits intonv-legate:branch-24.03from
JosephGuman wants to merge 2 commits intonv-legate:branch-24.03from
Conversation
…jects Signed-off-by: Joseph Guman <joeytg@stanford.edu>
Contributor
Member
|
I'll take a pass through this, but @manopapad can you review or should we wait for wonchan to come back from vacation? |
rohany
reviewed
Apr 26, 2024
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ad hoc change for cunumeric np.unique(return_index=True) functionality. I made this separate from the more comprehensive equivalent function in Task, but it might be worthwhile to move these functions up into some higher level shared ancestor. @magnatelee @rohany
Signed-off-by: Joseph Guman joeytg@stanford.edu