Improved the container user creation process#10
Open
john-r-graham wants to merge 1 commit into
Open
Conversation
This accounts for the condition where the UID and/or GID of the host system user already exists in the container. This was causing the `docker build` to fail late in the process, not _quite_ completing the container build. A new `create-container-user.sh` script has a slightly more nuanced user creation heuristic that _creates_ the new host user/group if there is no UID/GID overlap and _modifies_ the existing user/group if there _is._ The script is shared with _all_ dockerfiles and frankly looks a lot nicer than it would if it was included in each with all those line continuation escapes and semicolons.
|
An easy fix is to add these lines just below the FROM line in the Dockerfile: Inspiration: https://gitlab.com/crafty-controller/crafty-4/-/work_items/521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accounts for the condition where the UID and/or GID of the host system user already exists in the container. This was causing the
docker buildto fail late in the process, not quite completing the container build.A new
create-container-user.shscript has a slightly more nuanced user creation heuristic that creates the new host user/group if there is no UID/GID overlap and modifies the existing user/group if there is. The script is shared with all dockerfiles and frankly looks a lot nicer than it would if it was included in each with all those line continuation escapes and semicolons.