Add test coverage for undertested core modules (BasisEvaluator, VolumeEvaluator, SurfaceOperator, PrimitiveFactory)#3
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
…urfaceOperator, PrimitiveFactory Agent-Logs-Url: https://github.com/nyarurato/NurbsSharp/sessions/58bd23ed-c3c5-49ca-9884-41b87c0fd788 Co-authored-by: nyarurato <8384007+nyarurato@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Evaluate completeness of the nurbssharp repository
Add test coverage for undertested core modules (BasisEvaluator, VolumeEvaluator, SurfaceOperator, PrimitiveFactory)
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completeness evaluation of the repository identified several public APIs with minimal or no test coverage. This PR adds 16 targeted tests across 4 files to cover the gaps found.
New Tests
BasisEvaluationTest.cs(+7 tests)Core NURBS math properties that were entirely untested:
∑ Nᵢ,ₚ(u) = 1at any parameteru=0.25,u=0.75)∑ N'ᵢ,ₚ(u) = 0)FindSpanclamping behavior for out-of-range parametersVolumeEvaluateTest.cs(+4 tests)P(u,v,w) = (w,v,u)nullargument throwsArgumentNullExceptionInvalidOperationExceptionin constructorSurfaceOperatorTest.cs(+4 tests)FindClosestPointhad zero test coverage:z=0with correct distancetolerance/gridDivisionsvs. default parameters produce consistent results (validates optional args are exercised)nullsurface throwsPrimitiveTest.cs(+1 test)CreateLine: verifies degree-1, 2-control-point structure; start/end interpolation; parametric linearity at all sample points