Rename timer_t to not clash with POSIX _t convention#2
Open
tuckerpo wants to merge 1 commit intonybblesio:masterfrom
Open
Rename timer_t to not clash with POSIX _t convention#2tuckerpo wants to merge 1 commit intonybblesio:masterfrom
timer_t to not clash with POSIX _t convention#2tuckerpo wants to merge 1 commit intonybblesio:masterfrom
Conversation
Fix gcc typedef clash
tuckerpo
force-pushed
the
fix/posix_typedef_clash_timer_t
branch
from
93b31ed to
5ff94a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tip of master (e70ca29) failed to build due to a redefinition of
timer_tin libctimer.hgcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
ubuntu x86_64 GNU/Linux
Simply changing ckong's timer_t typedef name fixes this, but causes a stylistic clash in the codebase, now.
It may be worth going through and changing the
typedefnaming convention here to avoid redefinition issues in the future.