Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
neacsu
approved these changes
Sep 4, 2025
Contributor
neacsu
left a comment
neacsu
left a comment
There was a problem hiding this comment.
@neacsu reviewed 108 of 111 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @durch, @dynco-nym, and @simonwicky)
Contributor
Author
|
temporarily put on hold as after further discussion IPR will have to be a little bit less tighly coupled, i.e. the actual "core" would have to be a separate crate |
jstuczyn
modified the milestones:
Isabirra (est. mainnet 30.09.2025),
Jarlsberg (est. mainnet 14.10.2025)
jstuczyn
modified the milestones:
Jarlsberg (est. mainnet 14.10.2025),
Kase (est. mainnet 28.10.2025)
jstuczyn
modified the milestones:
Kase (est. mainnet 28.10.2025),
"M" (est. mainnet 25.11.2025)
durch
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR moves NR and IPR into the gateway crate to allow us to more easily couple them more closely together in the future, which I can imagine will allow us to simplify a lot of things.
This change is