Skip to content

CE-139 pnio: dynamic config #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nofateg merged 1 commit into from
Mar 13, 2026
+21 −4
Merged

CE-139 pnio: dynamic config #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions oap-http/oap-pnio-v3/src/main/java/oap/http/pniov3/PnioController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,26 @@ public class PnioController implements AutoCloseable {
}
}

public final int maxThreads;
final ForkJoinPool forkJoinPool;
private final int maxThreads;
public volatile boolean done;

public PnioController( int parallelism, double maxThreadsMultiplicator ) {
this( getForkJoinPoolParallelism( parallelism ), ( int ) ( getForkJoinPoolParallelism( parallelism ) * maxThreadsMultiplicator ) );
}

public PnioController( int parallelism, int maxThreads ) {
forkJoinPool = new ForkJoinPool( parallelism, new ForkJoinPool.ForkJoinWorkerThreadFactory() {
int forkJoinPoolParallelism = getForkJoinPoolParallelism( parallelism );

// ForkJoinPool#MAX_CAP = 0x7fff
forkJoinPool = new ForkJoinPool( forkJoinPoolParallelism, new ForkJoinPool.ForkJoinWorkerThreadFactory() {
@SneakyThrows
@Override
public ForkJoinWorkerThread newThread( ForkJoinPool pool ) {
return ( ForkJoinWorkerThread ) carrierThread.invokeWithArguments( pool );
}
}, ( t, e ) -> log.error( e.getMessage(), e ),
true, parallelism, parallelism, parallelism, null, 60_000L, TimeUnit.MILLISECONDS );
true, 0, 0x7fff, forkJoinPoolParallelism, null, 60_000L, TimeUnit.MILLISECONDS );
this.maxThreads = maxThreads;

Metrics.gauge( "pnio_controller", Tags.of( "type", "QueuedTask" ), this, _ -> forkJoinPool.getQueuedTaskCount() );
Expand All @@ -68,6 +75,16 @@ public ForkJoinWorkerThread newThread( ForkJoinPool pool ) {
Metrics.gauge( "pnio_controller", Tags.of( "type", "RequestQueue" ), this, _ -> threadCounter.get() );
}

private static int getForkJoinPoolParallelism( int parallelism ) {
int forkJoinPoolParallelism;
if( parallelism > 0 ) {
forkJoinPoolParallelism = parallelism;
} else {
forkJoinPoolParallelism = Runtime.getRuntime().availableProcessors() - parallelism;
}
return forkJoinPoolParallelism;
}

@Override
public void close() {
done = true;
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
</distributionManagement>

<properties>
<oap.project.version>25.4.6</oap.project.version>
<oap.project.version>25.4.7</oap.project.version>

<oap.deps.config.version>25.0.1</oap.deps.config.version>
<oap.deps.oap-teamcity.version>25.0.0</oap.deps.oap-teamcity.version>
Expand Down
Loading