Skip to content

Release 17.1.1#1175

Merged
oat-devops merged 4 commits intomasterfrom
release-17.1.1
Mar 3, 2026
Merged

Release 17.1.1#1175
oat-devops merged 4 commits intomasterfrom
release-17.1.1

Conversation

@oat-devops
Copy link
Copy Markdown

@oat-devops oat-devops commented Mar 3, 2026

Release 17.1.1 from 17.1.0

Summary by CodeRabbit

  • Tests
    • Added comprehensive unit test coverage for the persistence layer, validating data storage and retrieval operations across multiple database platforms.

@oat-devops oat-devops merged commit 750a7d8 into master Mar 3, 2026
4 of 5 checks passed
@oat-devops oat-devops deleted the release-17.1.1 branch March 3, 2026 14:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: https://raw.githubusercontent.com/oat-sa/tao-code-quality/main/coderabbit/php/authoring/v1/.coderabbit.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0faafc6 and a71d17d.

📒 Files selected for processing (2)
  • common/persistence/class.SqlKvDriver.php
  • test/unit/common/persistence/SqlKvDriverTest.php

📝 Walkthrough

Walkthrough

Parameter binding keys in SqlKvDriver changed from colon-prefixed to unprefixed format in set, incr, and decr methods to align with Doctrine DBAL expectations. Comprehensive unit tests added covering cross-platform SQL behavior, parameter binding, error handling, and data encoding.

Changes

Cohort / File(s) Summary
Production: Parameter Binding Alignment
common/persistence/class.SqlKvDriver.php
Changed parameter binding keys from colon-prefixed (":id", ":data", ":time") to unprefixed ("id", "data", "time") in set, incr, and decr methods. Added comment documenting Doctrine DBAL binding expectations. Control flow unchanged.
Test Coverage: SqlKvDriver Unit Tests
test/unit/common/persistence/SqlKvDriverTest.php
New comprehensive unit test suite with 391 lines covering: parameter key validation (no leading colons), set/incr/decr behavior across MySQL/PostgreSQL/GCP Spanner platforms, error propagation, data encoding validation, and helper methods for test fixture creation via mock injection.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

⏱️ 10-30 Min Review

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-17.1.1

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants