Feature/nex 334/global newsql schema branch#693
Open
julien-sebire wants to merge 24 commits intodevelopfrom
Open
Feature/nex 334/global newsql schema branch#693julien-sebire wants to merge 24 commits intodevelopfrom
julien-sebire wants to merge 24 commits intodevelopfrom
Conversation
Added types to queries to persistence.
Added Spanner driver.
…tract-model-factory
…ewsql-schema-branch
…ure/NEX-334/global-newsql-schema-branch
…NEX-334/global-newsql-schema-branch
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| /** | ||
| * @inheritdoc | ||
| */ | ||
| public function prepareStatement($modelId, $subject, $predicate, $object, $lang, $author) |
There was a problem hiding this comment.
Method prepareStatement has 6 arguments (exceeds 4 allowed). Consider refactoring.
| * @param string $author | ||
| * @return array | ||
| */ | ||
| abstract public function prepareStatement($modelId, $subject, $predicate, $object, $lang, $author); |
There was a problem hiding this comment.
Method prepareStatement has 6 arguments (exceeds 4 allowed). Consider refactoring.
| /** | ||
| * @inheritdoc | ||
| */ | ||
| public function prepareStatement($modelId, $subject, $predicate, $object, $lang, $author) |
There was a problem hiding this comment.
Method prepareStatement has 6 arguments (exceeds 4 allowed). Consider refactoring.
|
Code Climate has analyzed commit c924b65 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
UUID should be string instead of object to be persisted to storage
Update UuidPrimaryKeyTrait.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global PR for the whole NewSql implementation.