Skip to content

refactor: rewrite observability mod - #2

Merged
Evenss merged 3 commits into
mainfrom
refactor
Apr 24, 2026
Merged

refactor: rewrite observability mod#2
Evenss merged 3 commits into
mainfrom
refactor

Conversation

@PsiACE

@PsiACE PsiACE commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Summary

clean code, refactor observability with logfire

Solution Description

test with jaeger:

def configure_observability() -> None:
    os.environ.setdefault("OTEL_EXPORTER_OTLP_PROTOCOL", "http/protobuf")
    os.environ.setdefault(
        "OTEL_EXPORTER_OTLP_TRACES_ENDPOINT",
        "http://127.0.0.1:4318/v1/traces",
    )
    os.environ.setdefault("OTEL_SERVICE_NAME", "seekvfs-local-demo")
    os.environ.setdefault("LOGFIRE_IGNORE_NO_CONFIG", "1")
    logfire.configure(send_to_logfire=False)

Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
PsiACE requested a review from Evenss April 24, 2026 03:33

@Evenss Evenss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good optimization. LGTM

@Evenss
Evenss merged commit 47a96bd into main Apr 24, 2026
2 checks passed
@PsiACE
PsiACE deleted the refactor branch April 24, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants