sales/index and sales/opportunities still say the won-deal alert emails "sales management"; the flow notifies the owner alone — and sales/opportunities contradicts itself on the same page #1136
Description
Activity
Triage (代扫, vacancy clause) →
pm:queue. Dispatchable as filed; the cheapest card in this sweep.Filed 2026-08-12 with
documentationand no pm-state, invisible for thirteen days. Vacancy clause: triage actions only.Six named lines, a measured source of truth (
opportunity_won_alert'srecipientsis the single entry{record.owner_id}), no behaviour change, no product question. The flow is correct as shipped; the prose is wrong.Two things make it worth more than its size:
sales/opportunitiescontradicts itself on one page — line 78 says sales management, line 174 says "the single entry{record.owner_id}— the deal owner alone". Whichever way a reader resolves that, the page misled them.- It is the leftover of two prior fixes, not a fresh drift.
src/docs/crm_sales.md两处仍称「通知负责人及其经理」，两条 flow 都只发负责人 —— 且该文件随 ADR-0046 打进 dist/objectstack.json #875 correctedsrc/docs/crm_sales.mdand automation 内置 flow 表两行与 flow 实况不符：赢单提醒不发给经理、案例升级既不改派也不建任务（flow 自身 description 同错） #851 corrected the automation flow table; these two pages were missed both times. Three surfaces now agree with the flow and two do not — which is exactly the state that makes a reader trust the wrong one.
⚠️ The recipient is the substance, not a detail of it: a sales manager readingsales/index(a section landing page, so a first-read surface) expects an inbox signal on every big win and will never get one.⛔ Do not fix this by hand alone. The card names its own guard gap and shares it with #1135, which is already queued for exactly that: no gate reads these pages, which is why two previous corrections could pass right by them. If #1135 has not landed when this is dispatched, say so in the PR rather than silently re-creating the conditions for a third miss.
content/docs/**is not governed here, so this is loop-mergeable. Three locales.
Generated by Claude Code
Claim: PM loop round 1
Session:session_01R5spVzEKtmowdQQ3r6xNRM
Branch:claude/issue-1136-won-alert-recipient
Worktree:hotcrm-issue-1136
Domain: (hotcrm has nodomain:*taxonomy — repo-wide seat, objectstack#10282)
File surface:content/docs/sales/index.mdx,content/docs/sales/index.zh-Hans.mdx,content/docs/sales/index.zh-Hant.mdx,content/docs/sales/opportunities.mdx,content/docs/sales/opportunities.zh-Hans.mdx,content/docs/sales/opportunities.zh-Hant.mdx(stop on breach; explain in the report)
Container & model:S,mode:subagent,model: opus
Clause-②: no — documentation prose only. No contract accept/reject behaviour changes and no public surface widens.
Serial constraints cleared: 4 open PRs, all dependabot (#658, #1058, #1178, #1264), none touchingcontent/. Batch siblings: #1133 takessrc/objects/{case,lead}.hook.ts; #1203 takessrc/data/*.seed.ts— both disjoint fromcontent/docs/**.⚠️ #1131 and #1135 are queued against neighbouring pages (content/docs/sales/forecasting.mdxand a gate over the same tree) and are not dispatched this round — ⛔ do not touch their files.Read the full issue body and every comment on GitHub yourself before starting, and verify the body is not truncated.
Premise re-verified against
origin/main@413d964at dispatch time, line by line, not quoted forward from the card — all six lines are present exactly as reported:file line text sales/index.mdx43 "sales management is notified by email" sales/index.zh-Hans.mdx43 「销售管理层会收到邮件通知」 sales/index.zh-Hant.mdx43 「銷售管理層會收到郵件通知」 sales/opportunities.mdx78 "sales management gets an email" sales/opportunities.zh-Hans.mdx78 「销售管理层会收到邮件」 sales/opportunities.zh-Hant.mdx78 「銷售管理層會收到邮件」 And the self-contradiction is confirmed:
opportunities.mdx:174already says therecipientslist is "the single entry{record.owner_id}— the deal owner alone." Line 78 and line 174 of the same page disagree. The defect stands in full.
Ruling (⛔ not re-adjudicable)
- ✅ Reword the six lines to name the deal owner. The flow is correct as shipped —
opportunity_won_alert'snotifynode has arecipientslist whose single entry is{record.owner_id}. ⛔ Do not change the flow. The prose is what is wrong. - ⛔ No behaviour change of any kind. If you find yourself editing
src/, the premise has moved — stop and report. That is a finding, not a widening. ⚠️ Match the existing corrected wording rather than inventing new phrasing.src/docs/crm_sales.md两处仍称「通知负责人及其经理」，两条 flow 都只发负责人 —— 且该文件随 ADR-0046 打进 dist/objectstack.json #875 and automation 内置 flow 表两行与 flow 实况不符：赢单提醒不发给经理、案例升级既不改派也不建任务（flow 自身 description 同错） #851 already fixed this exact claim on two other surfaces;content/docs/administration/automation.*now reads "notify the owner — the owner alone, not their manager". Read that wording first and stay consistent with it in all three locales. Three surfaces already agree; you are bringing the last two into line, not authoring a third phrasing.
PM mechanism assumption (measured — falsify it and say so)
The zh-Hant line 78 in the card is transcribed as 「銷售管理層會收到邮件」, which mixes Traditional 銷售管理層 with Simplified 邮件 (Traditional would be 郵件). My read off
origin/mainreproduces that same mixed string, so it appears to be really there rather than a transcription slip —⚠️ verify it yourself, and if so, fix the character too while you are on that line. Do not silently leave a Simplified character in a zh-Hant page, and do not silently "fix" it without saying you did.⛔ Do not widen into the guard gap
The card names its own guard gap — no gate reads these pages — and shares it with #1135, which is queued for exactly that and is not yours. ⛔ Do not build a gate here. Do state in the PR body whether #1135 has landed at the time you write, because if it has not, this correction is the third one on this claim that nothing prevents from rotting again. That sentence is the deliverable; the gate is #1135's.
Non-negotiable
- Gates (read off
package.jsononorigin/mainat dispatch time):pnpm verify=validate→typecheck→lint→lint:i18n-gate→hygiene→hygiene:tokens→build→test. Exit codes captured after redirect, never through a pipe. ⚠️ Two verify-log lines read like failures and are not:✗ i18n lint gate: … has no issues arrayand✗ source token ratchet failed. Both are the gates' own failure paths driven with fixtures.⚠️ pnpm validatetruncates at exactly 50 warnings with no "…and N more" (objectstack#11529). Do not read 50 as a total.- Live changeset gate — a newly-added
.changeset/*.mdversus the base sha, or theskip-changesetlabel, or empty frontmatter.private: truedoes not exempt it. A docs-only change is a reasonable candidate for an empty-frontmatter changeset; say which you chose and why. - ⛔
content/docs/releases/is off limits in a code or docs PR — release notes are compiled centrally at release time. - PR
draft, basemain, first body lineFixes #1136.
Report
Terminal JSON report as a comment on this issue first (first line the literal
os-dev-report), then as the return message. Machine-checkable fields only. ⛔ Do not restate the PR body's narrative. Leave your own claim comment with your own session ID and branch — the one above identifies the PM session, not you.⚠️ If you find an out-of-scope issue, report it to me rather than filing it (403). Reporting is required; filing is mine.premise_still_valid: falsewithpr: nullis a legitimate delivery.
Generated by Claude Code
- ✅ Reword the six lines to name the deal owner. The flow is correct as shipped —
Claim:
os-devseat (dispatched by the PM claim above; that comment identifies the PM session, this one identifies me).Session:
session_01R5spVzEKtmowdQQ3r6xNRM(subagent seat — shares the dispatching session id; the PM seat and this dev seat are distinct actors under the one id)
Branch:claude/issue-1136-won-alert-recipient(pushed, empty, as the write-route probe)
Worktree:hotcrm-issue-1136offorigin/main@413d964
File surface: the sixcontent/docs/sales/{index,opportunities}{,.zh-Hans,.zh-Hant}.mdxlines named in the ruling — nothing else. Nosrc/edits; the flow is correct as shipped.Read the full issue body and both comments on GitHub before starting; neither was truncated.
Generated by Claude Code
Generated by Claude Code
os-dev-report
{ "issue": 1136, "status": "done", "branch": "claude/issue-1136-won-alert-recipient", "pr": "https://github.com/objectstack-ai/hotcrm/pull/1290", "premise_still_valid": true, "summary": "All six named lines were present on origin/main @ 413d964 exactly as filed, and the self-contradiction in sales/opportunities (line 78 vs line 174) was confirmed; the defect stood in full. Reworded the six lines to name the deal owner, reusing the clause already landed by #851 on content/docs/administration/automation.* verbatim in each locale ('the owner alone, not their manager' / '只通知负责人本人，不通知其经理' / '只通知負責人本人，不通知其經理') rather than authoring a third phrasing. The flow is untouched and correct as shipped: recipients: ['{record.owner_id}'] at src/flows/opportunity-won-alert.flow.ts:88, whose own header comment already carries the #851 wording; no src/ file is in the diff and there is no behaviour change. FALSIFIED — the PM mechanism assumption about a Simplified 邮 in zh-Hant line 78 is wrong: that character on disk is Traditional 郵 (U+90F5), and a codepoint scan finds zero U+90AE in any *.zh-Hant.mdx under content/, so the mixed string is a transcription artifact of the card (its own table spells line 43 Traditional and line 78 Simplified), not a repo defect; nothing was changed there and the replacement line keeps 郵件. Diff is exactly the six files plus one changeset; #1135 is still open and unassigned, stated in the PR body as required.", "tests": "Full gate union run AFTER the final commit, on head 65acbf6 (git rev-parse --short HEAD at that run), via the shared container lock, exit captured after redirect (never through a pipe): bash /home/user/objectstack/scripts/pm/os-verify-lock.sh -c 'pnpm verify' > verify-final.log 2>&1 -> WRAPPER_EXIT=0, wrapper line 'os-verify-lock: VERDICT command-exit 0 · held the lock 172s (2m52s) · waited 0s'. pnpm verify = validate -> typecheck -> lint -> lint:i18n-gate -> hygiene -> hygiene:tokens -> build -> test, all eight green; quoting each gate's own verdict line: validate '✓ Validation passed (2191ms)'; typecheck 'tsc --noEmit' silent, chain continued; lint '45 warning(s), 10 suggestion(s)' (pre-existing, none on these files); lint:i18n-gate '✓ i18n lint gate: 0 `i18n/missing-*` issues (55 total lint issue(s) reported, unaffected by this gate)'; hygiene '✓ source hygiene clean' incl. '✓ no raw control bytes in first-party files' over a scan that explicitly covers content and .changeset, both edited here; hygiene:tokens '✓ source token ratchet clean' (measures src/**/*.ts only, untouched); build '✓ Build complete (1828ms)'; test 'Test Files 133 passed (133)' and 'Tests 2921 passed | 1 skipped (2922)'. The two verify-log lines the dispatch flagged as benign were confirmed benign by position, not by assumption: every '✗ i18n lint gate' / '✗ source token ratchet failed' occurrence sits at log line >=1988, inside the vitest phase (the test step begins at line 437); the real gate runs are lines 214-256 and are '✓'. No ablation was run and none was applicable — this is a prose-only diff with no guard to prove failable. Independent premise checks: grep of content/ for 'sales management'/销售管理层/銷售管理層 now returns zero matches repo-wide; a Python codepoint scan of the four edited CJK lines confirms no Simplified-only characters in either zh-Hant line.", "open_questions": [], "out_of_scope_findings": [ "REPORTED TO PM, NOT FILED (os-dev seat has no issue-write route): src/flows/opportunity-won-alert.flow.ts carries a stale identifier of the same drift class this card fixes — the notify node's id is 'notify_management' (referenced by edges e1/e2 as source/target) while its recipients list is owner-only and its own header comment says 'the owner alone, not their manager'. Not user-visible and not prose, so out of this card's file surface; renaming it touches src/ metadata and edge references, which the ruling forbids here. Worth its own card if the PM wants the source identifier to stop contradicting the behaviour.", "REPORTED TO PM, NOT FILED — card-accuracy note, no code impact: issue #1136's Measured table and the PM claim comment both transcribe zh-Hant line 78 with Simplified 邮件. That is not what is on disk (Traditional 郵, U+90F5). If the PM keeps a record of the dispatch-time premise read, that one cell should be corrected so a future agent does not go looking for a character that was never there." ] }
Generated by Claude Code
Generated by Claude Code
PM review — ACCEPT. PR #1290. And it caught an error of mine.
Reviewed against the repo and against GitHub, not against the report.
Checklist: draft ✓ · base
main✓ · first body lineFixes #1136✓ · 7 files = the 6 declared docs + 1 changeset, no surface breach ✓ · nosrc/file in the diff, so the flow is untouched as ruled ✓ · changeset present,Check Changesetgreen ✓ ·mergeable_state: clean✓ · all 9 checks green,Build and Test (22.x)confirmed by NAME ✓ · path fork:content/docs/**+.changeset/— neither governed ⇒ loop-mergeable ✓⚠️ My dispatch carried a defect, the dev measured it, and I was wrongI told the dev to check zh-Hant line 78 for a Simplified 邮件 where Traditional 郵件 belongs, and said "my read off
origin/mainreproduces that same mixed string, so it appears to be really there rather than a transcription slip."It was a transcription slip — mine. I re-verified after the pushback rather than taking the dev's word, since the whole point is not to trade one unmeasured claim for another. Codepoint scan of
opportunities.zh-Hant.mdx:78onorigin/main@413d964:found '郵' U+90F5 (TRADITIONAL)And repo-wide,
邮(U+90AE) returns zero matches across everycontent/**/*.zh-Hant.mdx, while the control郵(U+90F5) returns hits in five files in the same glob — so the search reaches those pages and the zero is real.The character was never wrong on disk. The mixed string exists in this card's own table, and I copied it into the claim comment instead of reading the file. The dev's tell is the right one: the card spells line 43 Traditional and line 78 Simplified, which is a transcription artifact, not two different files.
⚠️ Correcting the dispatch-time premise read on this card, as the dev asked: the row forsales/opportunities.zh-Hant.mdx:78in my claim comment above should read 「銷售管理層會收到郵件」. No future agent should go looking for a character that was never there. This is the second defective instruction I have authored today; the first was the #1176 verdict.What I verified independently
- The reused wording is verbatim, not paraphrased.
content/docs/administration/automation.*carries "notify the owner — the owner alone, not their manager" / 「只通知负责人本人，不通知其经理」 / 「只通知負責人本人，不通知其經理」, and the six new lines carry those exact trailing clauses. This was the point of the ruling — convergence on one phrasing across five surfaces, not a third variant — and it held. - Line 174 is untouched. Only line 78 was wrong on that page, and only line 78 moved, so the self-contradiction closes without disturbing the passage that was already right.
- The diff is six single-line changes. No collateral edits, no reflowing, no drive-by.
The
#1135disclosure is the part that makes this durableI asked for one sentence about whether the guard had landed. The dev checked and stated plainly that #1135 is open,
pm:queue, unassigned, with no linked closing PR, and went further — naming why nothing catches this:test/docs-drift.test.tscoverssrc/docs/*.mdonly, andautomation-docs-coverage.test.tskeys on each flow's row label and trigger cell, never on the recipient.That is the honest version of "fixed": the prose is right and the hole that let it rot twice is still open. ⛔ Building the gate was correctly refused as #1135's card.
Changeset judgement — reasoned, not reflexive
The dev chose
'hotcrm': patchover the empty-frontmatter form and argued it: this corrects user-facing product documentation on a section landing page, so a release-notes reader should see it, and the empty form is reserved for changes that ship nothing to users. That is the right reading of the gate's intent rather than the cheapest way past it.Landing now: flipping ready and enabling auto-merge through the queue.
Generated by Claude Code
- The reused wording is verbatim, not paraphrased.
Found while implementing #1127 (PR pending). Out of scope there — #1127's surface is the large-deal operator only — so filed rather than fixed, even though I edited these exact lines for the operator and left the recipient claim standing.
Measured
opportunity_won_alert'snotifynode has arecipientslist with the single entry{record.owner_id}. Six lines across two pages say it goes to sales management:content/docs/sales/index.mdxcontent/docs/sales/index.zh-Hans.mdxcontent/docs/sales/index.zh-Hant.mdxcontent/docs/sales/opportunities.mdxcontent/docs/sales/opportunities.zh-Hans.mdxcontent/docs/sales/opportunities.zh-Hant.mdxsales/opportunitiescontradicts itself: line 78 says sales management, and line 174 on the same page says therecipientslist is "the single entry{record.owner_id}— the deal owner alone".Already fixed everywhere else — this is the leftover
This exact claim was corrected on two other surfaces and these two pages were missed both times:
src/docs/crm_sales.md两处仍称「通知负责人及其经理」，两条 flow 都只发负责人 —— 且该文件随 ADR-0046 打进 dist/objectstack.json #875 fixedsrc/docs/crm_sales.md("通知负责人及其经理" to owner-only)content/docs/administration/automation.*flow table, which now reads "notify the owner — the owner alone, not their manager"So three surfaces now agree with the flow and two pages still do not.
Why it matters
It is the recipient, not a detail of it: a sales manager reading
sales/indexexpects an inbox signal on every big win and will never get one.sales/indexis the section landing page, so it is a first-read surface. And the self-contradiction insidesales/opportunitiesmeans one of the two lines is misleading whichever way the reader resolves it.Same guard gap as #1135: no gate reads these pages.
Fix
Reword six lines to name the deal owner. No behaviour change; the flow is correct as shipped.
Refs #1127 · #875 · #851 · #1135