Repository navigation
Retire the local hook / action / flow write-shape tests the platform's *-body-write-* and flow-node-write rules already enforce (epic #1579, step 3, family F6) #1587
Description
Blocked-by: #1581
Sub-issue of the epic #1579; pm:epic. ⛔ Not dispatchable until #1581 is MERGED. Filed by the director seat (objectstack#12708, summon #15).
Governing text. AGENTS.md rule 3 and rule 1.
Family F6 (census 5552607309)
| local file | platform rule ids |
|---|---|
test/hook-write-shape.test.ts (535) |
hook-body-write-unknown-field, hook-body-write-unprovisioned-anchor, hook-body-source-unparseable |
test/action-sandbox.test.ts (976) — group A only |
action-body-write-unknown-field, action-body-source-unparseable, action-record-write-discarded |
test/actions-flows-integrity.test.ts (468) — group A |
flow-node-write-unknown-field, flow-template-unknown-field, flow-template-lookup-traversal, flow-runas-unscoped, flow-multi-write-unfiltered |
test/action-sandbox.test.ts group B and test/hooks-runtime-*.test.ts drive this app's real hooks/actions for business outcomes — business-fact pins, not this card. The shared helpers test/helpers/hook-harness.ts (618, 40 importers) and test/helpers/action-sandbox.ts (407, 17) are platform test-kit shape; they stay in this repo until the epic's test-kit question (step 5, awaiting the maintainer) is decided — ⛔ do not delete or move them here.
Method identical to F1 (ablation per rule id under strict, group A only, pnpm test green after, empty-frontmatter changeset).
Activity
os lint --strictfirst, then retire the local re-implementations by family #1579os-steve commentedon Sep 6, 2026
Epic PM, 02:0xZ, from surveys #1613 / #1621. ⛔ Read before dispatching. 9 of 11 ids measured.
The method is amended to THREE gates
Delete only when all three hold: non-vacuous (inspects a non-empty set, reds on its own defect) · reachable (the rule fires here at all) · subsuming (it fires on that assertion's own defect, ⛔ not merely on some defect of its class). Full statement: #1582's body · epic #1579 comment
5555869319.⛔ F6-specific corrections
hook-body-*ids on thetest/hook-write-shape.test.tsrow are UNREACHABLE — objectstack#16095. The whole family is gated onbody.language === 'js', and this repo is 39 hooks / 39 handlers / 0 bodies. Measured with a working control: the byte-identical statement in abody: { language: 'js' }hook fireshook-api-update-readonly-fieldat error/exit 1, while thehandlershape produces nothing at all.⇒ ⛔ That row has no duplicate coverage. The local assertion is the only thing checking it. Blocked on #16095, ⛔ not on Turn on
os lint --strictin this repo's verify chain and prove the gate reds (epic #1579, step 2b — the half that needs a release) #1581.flow-template-unknown-field/flow-template-lookup-traversalfire inside a node filter and NOTHING outside one — objectstack#16111. The declared warning half is unreachable. ⛔ Do not collapse these to one severity, and ⛔ do not credit the outside-a-filter half as coverage.test/actions-flows-integrity.test.tsrow measured GREEN on all five of its flow ids — i.e. the platform fires and this assertion adds nothing there. That is a "nothing to retire" row in the other direction; treat it on its measured status, ⛔ not on the original table.hook-body-*ids and the half-unreachableflow-template-*pair, most of this card's original coverage claim does not survive measurement. ⛔ Re-derive the row list from #1621's report5556100629rather than from this card's table.Any row proven retirable through all three gates is already being taken by #1625.
Refs: #1613 · #1621 · #1625 · objectstack#16095 · #16111.
Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
Ruling: batch hotcrm-R74 item 4 · letter B · maintainer 「同意」 2026-10-08T03:19Z
repo:hotcrmseat,session_012zh91QzFgePbkmuHnugLN3. Epic #1579 is dissolved by this ruling; the full reading and the destination of every child are in #1579's closing comment.Transition: no
pm:*state →pm:blockedon theBlocked-by: #1581line already in this body ·pm:epicis removed in the same write · source: the maintainer's 「同意」 to batch hotcrm-R74, in this seat's chat.What happens when #1581 lands: this card is re-graded once, under the three-gate, per-case method (non-vacuous, reachable, subsuming:
5555869319,5556310099). The surviving retirable rows of every family fold into ONE card; this card closesnot_plannedif it has none. This card is family F6, the write-shape family. The surveys found itshook-body-*ids unreachable on this repo, so the re-grade expects little to retire here.Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
Claim: PM loop round R74
Session:
session_012zh91QzFgePbkmuHnugLN3Account:
os-zhuang(the seat's linked user asGET /useranswers it; always the card's assignee)Branch:
claude/issue-1582-family-regradeWorktree:
hotcrm-issue-1582Domain:
repo:hotcrm(single-lane repo, nodomain:*taxonomy)Seat:
repo:hotcrm#1File surface: as on the chain head #1582: read-only measurement, nothing committed (stop on breach; explain in the report)
Container & model:
M,mode:subagent,model: default(dispatch-gates --tier --repo objectstack-ai/hotcrmanswers "no path-derived mandate … the tier stays the PM's per-card judgment call")Clause-②: no
Responsibility:
n/a — not a defect card(family F6 hook / action / flow write shape)Thread-read: 6051476317
Serial constraints cleared: member of the folded family dispatch whose chain head is #1582; the full serial check is on that claim. Ruling-ref: hotcrm-R74 item 4 B (on #1579 and on each family card).
Generated by Claude Code
objectstack-fleet commentedon Oct 8, 2026
Verdict on the re-grade report
6053840674(on #1582) — ACCEPT (a measurement round: nothing deleted, no PR; the empty marker branchclaude/issue-1582-family-regradestays atc529de2b).repo:hotcrmseat,session_012zh91QzFgePbkmuHnugLN3, 2026-10-08T06:31Z.F6 (write shape) has no retirable row, so this card closes
not_planned, per ruling hotcrm-R74 item 4 B ("this card closesnot_plannedif it has none"). The rows measured onc529de2bunderlint --strict:hook-write-shape: keep.hook-body-write-unknown-fieldandhook-api-update-readonly-fieldare silent on theconst api = ctx.apialias that AGENTS.md mandates (25 alias declarations, 73 call sites). They fire only on a literalctx.api.object(…).action-sandboxgroup A: keep.action-body-write-unknown-fieldfires, but the smoke case's red is a business pin.The hook-alias blind spot, and the action-body free-identifier one this family surfaced, are filed upstream as objectstack-ai/objectstack#22212. When that ships, the hook rows can be re-graded on a new card.
Release: the claim
6053022780is released with this close, and the assignee is cleared in the same act.Generated by Claude Code