Remove scale from currency fields: objectstack main refuses it and no forward conversion exists (cloud re-cut floor 1)

[hotlong]

Source

Floor 1 of the cloud framework re-cut (objectstack-ai/cloud#2332). After #1964's premise was disproved, the maintainer ruled in the epic session on 2026-09-28 (verbatim): 「平台修转换 + HotCRM 先删 scale（推荐）」. Epic objectstack-ai/cloud#2440.

What

objectstack main refuses scale on currency fields ("scale is not valid on a currency field"; semantic entry field-currency-scale-refused). No forward conversion exists for it, so this is the one key family hotcrm must remove itself. The hotcrm#1964 dev counted 23 such fields in hotcrm main's composed artifact (objects[].fields[].scale on currency fields).

Direction

Remove scale from every currency field in hotcrm sources. Verify these on the tree; they are not yet measured:

• scale is optional on currency at the installed and published @objectstack/spec 17.4.0, so the removal is legal on both versions;
• how currency precision is expressed without it at both versions;
• whether displayed values or seed data change.

If removing it changes what users see, stop and report.

Acceptance

1. No currency field in hotcrm sources carries scale.
2. hotcrm's own pnpm verify chain passes at 17.4.0.
3. The dev states in the report what this leaves of the objectstack-main refusal list. After this card, the chart / assignedProfiles families are expected to remain, pending the platform conversion fix.

[hotlong]

Claim: PM loop round 2 (epic objectstack-ai/cloud#2440)
Session: 786273a0-0246-4bb2-b026-bb37ba5d7295
Branch: claude/issue-1965-currency-fields-drop-scale
Worktree: ~/Documents/GitHub/hotcrm-issue-1965
Domain: repo:hotcrm lane, reserved via pm:epic
Seat: epic PM for objectstack-ai/cloud#2440 (seat 1)
File surface: src/**/objects/*.object.ts currency field definitions (and any shared field helper that emits scale for currency), their tests, one .changeset/ file (stop on breach; explain in the report)
Container & model: M, mode:subagent, model: opus (default judgment tier)
Clause-②: no
Thread-read: none
Serial constraints cleared: hotcrm#1964 is on hold (branch kept, dashboards only; disjoint). No open hotcrm PR touches object definitions (checked for #1964 at 05:22Z; re-check at dispatch).

Direct dispatch by the maintainer, verbatim: 「使用专题派发解决这些问题」 / 「把并发上限提到 5，其余卡一起派」 (epic session, 2026-09-28).

[hotlong]

os-dev-report
{
"issue": 1965,
"status": "needs_decision",
"branch": "claude/issue-1965-currency-fields-drop-scale",
"pr": null,
"session": "786273a0-0246-4bb2-b026-bb37ba5d7295 (PM session; this dev ran as its subagent)",
"premise_still_valid": true,
"summary": "Stopped before the first edit, because two stop conditions in the order fired. The deletion itself is proven, but not landed. (1) The card says 'If removing it changes what users see, stop and report', and it does at the pinned console. The @objectstack/console 17.4.0 that hotcrm ships (built from objectui 53ded82bf7a4) formats two faces with a currency field's scale ?? 0: the grid summary footer (plugin-grid bundle) and the object-metric tile (plugin-dashboard bundle). The cell uses the currency's ISO 4217 minor unit and does not change. Measured in the UI on two local servers with the same seed: Sales Home 'Revenue (Won)' 1,290,000.00 -> 1,290,000 and 'Pipeline Value' 2,017,500.00 -> 2,017,500; the opportunity list footer '金额: 合计:2,017,500.00' -> '合计:2,017,500' and '预期收入: 合计:1,304,050.00' -> '合计:1,304,050'. In hotcrm this reaches 17 currency summary: columns across 8 list views, plus the 2 Sales Home KPI tiles. The platform fix is objectui#10348 (merge 0651e7ab4, 2026-09-24). It is NOT in the 17.4.0 console (merge-base --is-ancestor exit 1, control exit 0) and NOT in cloud's current .objectui-sha efead6c6 (exit 1, control exit 0). Seed data does not change: 23 opportunities, won sum 1,290,000, pipeline 2,017,500 and 13 products are identical on both servers, and every seeded amount is a whole unit, so today the visible delta is the dropped '.00'. Non-integer totals would round to whole units: the product list's avg list_price 22,346.15 -> 22,346 is computed from the shipped formatter, not captured in the UI. (2) The order says 'if one [open PR] touches object definitions, report before editing'. Two do: draft #1950 (opportunity.object.ts) and draft #1956 (contract/quote.object.ts). Neither conflicts textually. The route itself works. scale is optional on currency at 17.4.0, and removing it parses on both versions. The exact 23-line deletion built in a throwaway worktree gives an artifact byte-identical to main's artifact with those 23 keys stripped. On that artifact 0 currency scale issues remain at runtime label 17.4.0, and at 17.5.0 the parse is OK with 0 issues.",
"tests": "Baseline main 2f7b232 (my worktree, untouched): pnpm validate EXIT=0, typecheck EXIT=0, lint EXIT=0, lint:i18n-gate EXIT=0, hygiene EXIT=0, hygiene:tokens EXIT=0, build EXIT=0, test EXIT=0 ('Test Files 173 passed (173)', 'Tests 3716 passed | 1 skipped (3717)'). The #1964 dev's two main failures (docs-object-term-consistency timeout, docs-revenue-approvals-navigation) did NOT reproduce in 1 run. Hypothesis 1, probe at installed @objectstack/spec 17.4.0: FieldSchema {type:'currency'} with no scale -> OK (scale undefined), with scale 2 -> OK; Field.currency({label}) emits no scale key; ObjectSchema.create with a scale-less currency field -> OK. Deletion: a scripted edit (only scale: N, lines whose nearest enclosing opener is Field.currency) removed 23 lines in 8 object files. A rescan found 0 currency scale left, with 5 formula, 6 number, 4 percent and 1 summary scale untouched. It ran in a throwaway detached worktree at 2f7b232 with pnpm build EXIT=0. The source-edit artifact equals main's artifact with the 23 keys stripped (every top-level section identical). Parse probe (objectstack 862b6ce dist, ObjectStackDefinitionSchema.safeParse(applyArtifactForwardConversions(...))). On main's artifact: runtime 17.4.0, authored-current, 63 issues (objects..scale 23, pages..assignedProfiles 6, dashboards type 16 / xAxis 9 / yAxis 9); runtime 17.5.0, converted-forward, 23 issues, all objects..scale. On the source-edit artifact: runtime 17.4.0, 40 issues, currencyScaleIssues=0 (dashboards 34 and assignedProfiles 6 remain, the families pending objectstack#20390); runtime 17.5.0, converted-forward (notices page-assigned-profiles-removed 6, dashboard-widget-chart-config-structure-removed 34, page-component-filter-record-to-rule-array 4), PARSE OK with 0 issues. UI: two objectstack dev servers with the dev seed admin on their own OS_HOME in scratch, ports 4801 (main) and 4802 (deletion). Served metadata crm_opportunity.amount had scale 2 on 4801 and scale absent on 4802. Readings are in the summary. Screenshots are in the PM scratch issue-1965/shots/ (home-kpi-hc1965b/a.png, opp-footer-hc1965b/a.png; b = before, a = after). Shipped-bundle reads: plugin-dashboard-d1o52lHr.js 'ie.scale??0' feeds format 0,0.00 vs 0,0; plugin-grid-DGXy_yQF.js 'r?.scale??0' feeds min/maxFractionDigits. Overlap: git merge-tree --write-tree of the deletion commit against #1956 head 6d8618e EXIT=0 and #1950 head 85e5dbd EXIT=0. Positive control (a same-line scale: 3 edit) EXIT=1. Branch verify chain: NOT MEASURED, reason: stop conditions fired before any branch edit. Servers stopped by their own PIDs, ports 4801/4802 free, browser sessions closed, probe worktree removed.",
"mcp_calls": "0",
"api_writes": "1 - POST /repos//issues/1965/comments (this os-dev-report). Plus 1 git push (the empty branch, still at 2f7b232). No PR, no PR assignee, no labels, no issue-assignee write.",
"open_questions": [
{
"question": "Removing scale changes what users see, until the console reading it moves past objectui 0651e7ab4. On hotcrm's own 17.4.0 runtime, and on cloud's current objectui pin efead6c6, currency totals in 17 grid summary footers and in the 2 Sales Home object-metric KPI tiles lose their 2 decimals. Accept that, or re-sequence?",
"options": [
"A: Land the 23-line deletion now, as ruled ('HotCRM 先删 scale'), and state the display window in the PR. Its cloud half closes when cloud#2441 moves .objectui-sha past objectui 0651e7ab4. The PM can keep cloud tenants from ever seeing it by shipping cloud#2332 and cloud#2441 in one deploy. The hotcrm-local half (pnpm dev / objectstack start at 17.4.0) closes at hotcrm's 17.5.x bump. Cost: until then, footers and KPI tiles show whole units ('.00' dropped on today's seed; cents rounded on real data).",
"B: Hold the deletion for hotcrm's 17.5.x upgrade PR, atomic with a console that takes the decimals from the currency. Cost: cloud#2332 cannot boot hotcrm on objectstack main until 17.5.x is published. The epic's critical path then waits on an objectstack release, which reverses the recorded '先删'.",
"C: Delete now and compensate in hotcrm with an explicit format on the 2 KPI tiles. Nothing is available for the grid footers. Cost: a hotcrm-side workaround for a platform display default (AGENTS.md §2 and §4 forbid it), and it covers only half the faces."
],
"recommendation": "A, with the one-deploy sequencing on cloud. Real business need: measured, the only thing today's seed loses is '.00'. In the grid, the footer then matches the cells, which already show whole units ('94,000'). The real cost is rounding of non-integer customer totals, and it lasts only until the pins move. Long-term soundness: the platform ruled that a currency's decimals are the currency's, and objectstack's own changeset names these exact two faces. The window is a pin-ordering artifact, not a hotcrm design choice, and B or C would build hotcrm policy around it. AI-proofing: hotcrm is the neighbour AI copies ('author the file the way its neighbours are authored'). Draft #1950 has already copied scale: 2 onto two NEW currency fields, so every day the key stays it keeps spreading a spelling that objectstack main refuses. Startup scope: A adds nothing; C adds a workaround surface. The ruling is recorded, so this is the ruling plus the PM's sign-off on the window, not a re-decision."
},
{
"question": "The file surface in the claim does not cover two comment-only edits that the deletion makes false. src/revenue/flows/quote-generation.flow.ts:79-86 says Field.currency({ scale: 2 }) and that the field refuses unrounded writes. test/flow-quote.test.ts:57-77 (the docblock and the title 'fields' 2-decimal scale') says the same. Extend the claim?",
"options": [
"A: Extend the claim to reword both comments in the same PR (comments only; the round() expressions and the value pins stay as they are)",
"B: Leave the comments and note them for a later PR"
],
"recommendation": "A. The comments would state a refusal that no longer exists at 17.4.0 after the deletion: objectql 17.4.0 dist/core.js:4692-4709 enforces max_scale only through def.scale. The rounding is still correct money handling, so only the stated reason changes."
}
],
"out_of_scope_findings": [
"carrier: draft PR #1950 (issue-1916 branch, blocked on the src/sales token ceiling) · noted, not filed: it adds scale: 2 to two NEW currency fields, expected_tender_amount and expected_signing_amount, in src/sales/objects/opportunity.object.ts. objectstack main refuses both, and they re-introduce this card's key family after this card lands. Its textual merge with the deletion is clean (merge-tree EXIT=0).",
"carrier: the PR that lands this card · noted, not filed: at the pinned objectql 17.4.0, deleting scale also lifts the max_scale write refusal on those 23 fields, so a currency write with more than 2 decimals is accepted. That is the 17.5 ruled contract arriving early. No hotcrm test pins the refusal (0 hits for max_scale under test/). Name it in the PR's Acceptance notes.",
"carrier: none (observation only) · the after-server's seed rows came up with owner_id null (My Leads empty), and the before-server's did not. Both boots logged 'Inline seed exceeded 8000ms budget ... continuing in background', and I logged in while the seed was still running. It is a race with the admin seed, unrelated to scale, and was not reproduced on purpose."
]
}

---

Generated by Claude Code

[hotlong]

Maintainer ruling on the display window (epic PM, session 786273a0-0246-4bb2-b026-bb37ba5d7295)

Ruling (maintainer, verbatim, epic session 2026-09-28): 「现在删，cloud 两次抬版本同一次部署（推荐）」

As presented, this is option A of the dev's report. Land the 23-line deletion now and state the display window in the PR. Cloud avoids the window by shipping the framework re-cut (cloud#2332) and the objectui pin move past objectui 0651e7ab4 (cloud#2441) in one deploy. That sequencing constraint is recorded on both cloud cards.

PM disposition of open question 2 (comment-only edits made false by the deletion). Option A. The claim's file surface is extended to reword two things, and nothing else changes: the round() expressions and the value pins stay as they are.

• src/revenue/flows/quote-generation.flow.ts:79-86
• the docblock and the title in test/flow-quote.test.ts:57-77

Findings disposition.

• Draft PR feat(opportunity): REQ-0006 qualification, the customer calendar, narrative and approval on status change #1950 re-adds scale: 2 on two new currency fields. Noted for that PR's author; the lint that would catch this is the platform's refusal once hotcrm moves to 17.5.
• The early max_scale lift belongs in the PR's Acceptance notes.
• The seed owner_id race is an observation only.

[hotlong]

os-dev-report
{
"issue": 1965,
"status": "done",
"branch": "claude/issue-1965-currency-fields-drop-scale",
"pr": "#1968",
"session": "786273a0-0246-4bb2-b026-bb37ba5d7295 (PM session; this dev ran as its subagent)",
"premise_still_valid": true,
"summary": "Draft PR #1968 (head 8d55819, assigned hotlong) implements option A as ruled in comment 5864798033. Commit fbc745d deletes scale from all 23 currency fields in 8 object files, using the verified drop-currency-scale.mjs: 23 deletions, 0 additions, 0 currency scale left. scale on number, percent, formula and summary fields is untouched. Commit 8d55819 rewords the two comments that the deletion made false, within the extended file surface. The first is quote-generation.flow.ts: the fields now accept a tail, and the rounding keeps whole cents. The second is the test/flow-quote.test.ts docblock and title (now 'rounds discount_amount and total_price to whole cents (#1206)'). round() and the value pins are unchanged. The same commit adds a patch changeset. The PR body carries the display window, with the measured before/after table and the ancestry readings: the fix objectui 0651e7ab4 is in objectstack main's console pin f8a9d0fb (exit 0), and not in the 17.4.0 console or in cloud efead6c6. It also carries the one-deploy constraint for cloud#2332 + cloud#2441. The max_scale lift, the draft #1950 note and card acceptance 3 are in Acceptance notes.",
"tests": "HEAD 8d55819. pnpm validate EXIT=0: 12 warnings, verdict lines identical to main 2f7b232. typecheck EXIT=0. lint EXIT=0: 5 warnings, identical to main. lint:i18n-gate EXIT=0 ('0 i18n/missing-* issues'). hygiene EXIT=0. hygiene:tokens EXIT=0 (src/revenue business semantics ~15,626 -> ~15,594). build EXIT=0. pnpm test EXIT=1 twice, and every failure was a timeout; the load average was 40-77 during the runs. Run 1: 3 failed files | 170 passed, 7 failed tests | 3709 passed | 1 skipped, all 'Test timed out in 5000ms/60000ms' in global-actions, lint-i18n-gate and source-token-ratchet. Run 2: 2 failed | 171 passed, 2 failed tests | 3714 passed | 1 skipped, timeouts in case-sla-matrix and source-token-ratchet. Isolated re-runs on the same HEAD: global-actions + lint-i18n-gate + flow-quote + source-token-ratchet gave 3 files passed, with 1 ratchet sandbox case timing out. source-token-ratchet alone gave 40/40 passed. case-sla-matrix alone passed. global-actions + source-token-ratchet + case-sla-matrix with --testTimeout=60000 gave 119/119 passed, EXIT=0. No assertion failed in any run. Main baseline: test EXIT=0, 173 files, 3716 passed | 1 skipped. Parse probe (objectstack 862b6ce dist, ObjectStackDefinitionSchema.safeParse(applyArtifactForwardConversions(...))) on the branch dist/objectstack.json. At runtime 17.4.0: authored-current, 40 issues, currencyScaleIssues=0 (pages..assignedProfiles 6, dashboards type 16 / xAxis 9 / yAxis 9). At runtime 17.5.0: converted-forward (page-assigned-profiles-removed 6, dashboard-widget-chart-config-structure-removed 34, page-component-filter-record-to-rule-array 4), PARSE OK with 0 issues. The branch artifact is identical, section by section, to main's artifact with only the 23 keys stripped, so the comment edits do not reach it. The UI before/after, bundle reads, ancestry legs and merge-tree overlap from round 1 are restated in the PR body. CI at report time: Check Changeset pass, Quality Checks pass, link-check pass, Label Pull Request pass; Build and Test (22.x), Playwright and Analyze Code in_progress. Cleanup: dev servers were stopped in round 1 (ports free); the worktree was removed after HEAD was confirmed pushed (node_modules deleted first, git worktree remove without --force, EXIT=0).",
"mcp_calls": "0",
"api_writes": "4 over the gh CLI. Round 1: 1 issue comment (POST /repos//issues/1965/comments, the needs_decision os-dev-report). Round 2: gh pr create --draft (PR #1968); gh pr edit --add-assignee hotlong on the PR; this os-dev-report comment on #1965, authorized by the PM as the extra write. Plus 3 git pushes: the empty branch, fbc745d and 8d55819. No labels written by me; the repo's Label Pull Request workflow labels PRs on its own. No issue-assignee write, no ready flip.",
"open_questions": [],
"out_of_scope_findings": [
"carrier: draft PR #1950 · noted, not filed (PM disposition: noted for that PR's author): it adds scale: 2 to the new currency fields expected_tender_amount and expected_signing_amount in src/sales/objects/opportunity.object.ts. objectstack main refuses both. Its textual merge with #1968 is clean.",
"carrier: none (observation only, per PM disposition) · the seed owner_id race: seed rows land with owner_id null when the admin logs in while the background seed ('Inline seed exceeded 8000ms budget') is still running."
]
}

---

Generated by Claude Code

[hotlong]

Review: ACCEPT (PR #1968 at 8d558193)

Implemented-by: os-dev subagent of session 786273a0-0246-4bb2-b026-bb37ba5d7295
Reviewed-by: epic PM, session 786273a0-0246-4bb2-b026-bb37ba5d7295 (objectstack-ai/cloud#2440)

Diff read by the reviewer.

• Exactly 23 one-line scale: N, deletions inside Field.currency({...}) across 8 object files. scale on number, percent, formula and summary fields is untouched.
• The two comment-only rewords are within the extended surface: quote-generation.flow.ts, and the docblock and title in test/flow-quote.test.ts. round() and the value pins are unchanged.
• A patch changeset.

Evidence re-read.

• The branch artifact is identical, section by section, to main's artifact with the 23 keys stripped.
• The objectstack main parse probe finds 0 currency scale issues at label 17.4.0. At a 17.5.0 label it parses with 0 issues. The 40 issues left at 17.4.0 are the chart / assignedProfiles families owned by Forward conversion never opens on unreleased main: spec still labelled 17.4.0 while main refuses 17.5.0 retirements, so artifacts built by the published 17.4.0 CLI are refused objectstack#20390.
• The pnpm verify chain passed with warnings identical to main.
• The local full pnpm test failed only with timeouts at load 40–77; every failing file passes in isolation or with a longer timeout. CI Build and Test (22.x) is the clean reading.

The display window and the one-deploy constraint for objectstack-ai/cloud#2332 + #2441 are stated in the PR body, as ruled.

Landing: ready + auto-merge (squash) when CI is green.

[hotlong]

Landed: PR #1968 merged as 5bec6eb093. Verified that hotcrm main contains it. Epic PM, session 786273a0-0246-4bb2-b026-bb37ba5d7295.