Repository navigation
docs(service): the case header holds no icon - #1710
Merged
Merged
Conversation
The case detail layout's header bullet listed "an icon" among the things the header carries, and closed the list with "That is the whole header". `icon` was removed from `page:header` in @objectstack/spec 17.0.0 (#6946, ADR-0087 D2) — deleted, not renamed, because no renderer ever read it — and no `page:header` under `src/pages/` authors one, so the enumeration promised an element the renderer has no way to draw. The exhaustiveness claim is what made it worth correcting: a list that says it is the whole header gives a reader no reason to doubt any item on it. This is a deletion, not a rewrite. The breadcrumb and the action buttons named in the same sentence are both real (`breadcrumb: true`; `actions` names `escalate_case`, `close_case` and `log_call`), so only the icon clause goes and the completeness claim is left standing — now true, and matching the component's properties block item for item. The Chinese faces drop the same item in their own register rather than being re-translated around the gap. The sibling detail-page docs were swept by behaviour rather than by the word "icon" — header-content descriptions, completeness assertions, and the other nouns the faces could have used. The difference set is empty: no account, lead or opportunity page carries this sentence in any locale. No `src/` metadata changed; the deletion comments in `src/pages/*.page.ts` are correct and are untouched. No gate and no test added. Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
os-steve
marked this pull request as ready for review
September 6, 2026 12:39
This was referenced Sep 6, 2026
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1701
Description
The case detail layout's Header bullet listed "an icon" among the things the
header carries, and closed the list with That is the whole header.
iconwasremoved from
page:headerin@objectstack/spec17.0.0 (#6946, ADR-0087 D2)— deleted, not renamed, because no renderer ever read it — and no
page:headerunder
src/pages/authors one. The enumeration promised an element the rendererhas no way to draw.
The exhaustiveness claim is what made it worth correcting. A list that says it is
the whole header gives a reader no reason to doubt any item on it, so the one
entry the renderer cannot draw was the entry a reader would hunt for longest.
This is a deletion, not a rewrite. The breadcrumb and the action buttons named
in the same sentence are both real, so only the icon clause goes and the
completeness claim is left standing — now true, and matching the component's
properties block item for item:
case_detail.page.tspage:headertitle: '{case_number} · {subject}'subtitle: '{crm_account}'breadcrumb: trueactions: ['escalate_case', 'close_case', 'log_call']Type of Change
Related Issues
Closes #1701
Filed from this card's expansion sweep, not fixed here: #1709.
Changes Made
content/docs/service/cases.mdx— "plus an icon, a breadcrumb and the action buttons" becomes "plus a breadcrumb and the action buttons".content/docs/service/cases.zh-Hans.mdx— 「此外只有一个图标、面包屑和几个动作按钮」 becomes 「此外只有面包屑和几个动作按钮」.content/docs/service/cases.zh-Hant.mdx— 「此外只有一個圖示、麵包屑和幾個動作按鈕」 becomes 「此外只有麵包屑和幾個動作按鈕」..changeset/case-header-holds-no-icon.md— new.One clause per face, three changed lines in total. Character-level diff on the two
Chinese faces is exactly 一个图标、 and 一個圖示、 removed — nothing else moved, so
the three faces stay structurally equivalent (same line, same bullet, same
sentence count, no table or blockquote touched). The Chinese faces keep their own
register rather than being re-translated around the gap.
⛔ No
src/metadata changed. The deletion-explaining comments insrc/pages/*.page.tsare correct and are untouched. No gate and no test added(AGENTS.md, Scope rule 3).
The expansion sweep — reported even though it is empty
The sentence is inherited, so it was searched for by behaviour, not by the word
icon: every page describing what a record header holds, every completenessassertion ("that is the whole …", 就这些 / 就這些 / 此外只有 / 再无其他 / 仅此而已),
and the other nouns the three faces could have used (图标 / 圖示 / 图示 / 头像 /
頭像 / 徽标 / 標誌 / avatar / logo / glyph / emblem / kicker / eyebrow / thumbnail),
across all 201
.mdxfiles.The difference set is empty. No account, lead or opportunity page carries this
sentence in any locale:
sales/leadshas no detail-layout section at all — no header sentence to be wrong.sales/accountshas "Account detail layout", but it describes only the tabs; it makes no header claim.sales/opportunitiesdoes have a Header bullet, but it is a different sentence with a different history — no icon, no completeness claim. It is wrong in its own way, which is filed assales/opportunitiesdescribes an opportunity header that carries a stage badge, amount, close date and owner —page:headercarries none of them (all three locales) #1709 rather than ridden along here: correcting it is a rewrite of the bullet (it conflatespage:header,record:pathandrecord:highlights), not this card's one-item deletion.iconhit incontent/docsis a legitimate one: FumadocsCard icon=props,Action.iconandObjectSchema.iconin code samples (both real properties), browser and nav chrome, the account's avatar-accent field, and 标志 used to mean flag.Provenance — all three faces got the clause in one commit, #946, the change
that rewrote this bullet away from an older stale enumeration at a time when
iconwas still believed to be a header property. It was never a shared template, which
is why it never spread and why deleting it here finishes it.
Testing
pnpm verifyfully green — the repo's whole chain, run in one go:validate→typecheck→lint→lint:i18n-gate→hygiene→hygiene:tokens→build→test.Checked before editing, as the card required: no
docs-*wording pin assertsthese sentences. The distinctive tokens ("whole header", 此外只有, 面包屑, 图标,
圖示, breadcrumb) have no assertion site anywhere under
test/; the onlypage:headerpin isaction-references.test.ts, which resolves action ids and isuntouched by prose. Nothing turned red, so no assertion needed relaxing.
Checklist
.changeset/case-header-holds-no-icon.md, with'hotcrm': patchfrontmatter.Why
'hotcrm': patchand not the empty-frontmatter formBoth forms are live in this repo, so the choice was measured rather than recalled.
The empty frontmatter is genuinely sanctioned —
.github/workflows/changeset-check.ymldocuments it as the "this PR releases nothing" declaration, on par with the
skip-changesetlabel — but it is not what this class of change uses. Across all203 changesets, the split is by kind, not by date: in September, changes that
touch
content/docsused'hotcrm': patch36 times against 2 empty ones(both the same security-page pair, 2026-09-03), while the 31 empty ones were
internal — guard headers, hook comments, test harnesses, pin rescopes. Every
content/docschange in the last three days took the patch form, including #1702,the immediately preceding change to this very bullet list.
content/docsis theshipped product documentation, so a correction to it is a change a reader sees, and
the release notes carry it.
Generated by Claude Code