chore(deps): upgrade @objectstack/* to 17.5.0 - #1970
Merged
Merged
Conversation
…ssignedProfiles pending) Move all 21 @objectstack/* dependencies to 17.5.0 together, with specVersion and engines.protocol at ^17.5.0 in objectstack.manifest.json and objectstack.config.ts. Regenerate pnpm-lock.yaml from the public registry. Adopt the 17.5.0 breaking changes that reach this app's metadata: - dashboards: drop chartConfig.type / xAxis / yAxis from 34 dataset-bound widgets. The spec refuses them, and every removed value agreed with the widget's own type / dimensions / values. Axis titles are lost. - close_case flow: the lookup screen field declares reference: 'crm_knowledge_article'. It is now required, and it gives the field a real picker. - sales home: the four object-metric filters use the ViewFilterRule array. - decision default flip (#15429): no edit. All 13 decisions that `os migrate meta --from 17` offers `mode: 'inclusive'` partition their out-edges, so first-match runs what every-true-edge ran. - admin docs: scheduled flows need OS_AUTOMATION_SCHEDULED_WORK_ENABLED. Re-scope the claims that named 17.4.0 (and four missed 17.3.0 claims) as the current pin, and add the changeset. NOT INCLUDED: removing page.assignedProfiles from six pages, which 17.5.0 refuses. This change was not applied in this session. Until it lands, validate, typecheck, lint, build and boot all fail on those six keys. Claude-Session: https://claude.ai/code/session_014VGCS11YUtYAiinRcdqQwL Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…sted page i18n Complete the @objectstack/* 17.5.0 upgrade started in the previous commit. `pnpm verify` is green again. - pages: delete `assignedProfiles` from app_launcher, home, utility_bar, lead_detail, opportunity_detail and case_detail. spec 17.5.0 refuses the key. It gated nothing on 17.4.0, since no renderer, route or metadata read ever read it, so page audience is unchanged. The two tests that check declared assignedProfiles are kept as they are. - contact: relabel the "Account & Role" section "Account & Title". The new `security-role-word` lint rule reserves "role", and the section holds the job title. Update the en bundle and the Contacts doc to match; zh/ja/es already said "job title". - i18n: add the 14 page keys that 17.5.0 `os lint` now requires for nested and slot components, in each of zh-CN, ja-JP and es-ES. `os i18n extract` does not scaffold page keys. - test: the SQL driver withholds the operator name from a refused filter's message. The `$regex` premise test now reads the full text through `withheldFilterDiagnosticOf` and also asserts that the public message does not name the operator. - changeset: describe all four. Claude-Session: https://claude.ai/code/session_014VGCS11YUtYAiinRcdqQwL Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Sep 29, 2026
…geset's i18n claims `os i18n extract` does scaffold page keys, but only with `--no-objects-only`, because its default covers objects alone. The i18n gate's failure hint gave the bare command, which does not produce the page keys that the 17.5 `i18n/missing-page` rule asks for. The hint now gives the full command and explains why. Correct the changeset on two points: - it said extract cannot scaffold page keys, which is wrong; - it said the nested components showed English before this change. A zh-CN browser check of Lead Detail on 17.5.0 found none of those labels drawn as visible text, so readers see no change. Claude-Session: https://claude.ai/code/session_014VGCS11YUtYAiinRcdqQwL Co-authored-by: Claude <noreply@anthropic.com>
…ouped-list known issue Delete the two tests that checked the key this upgrade retires. The maintainer made the call. - "assignedProfiles name real profiles" in test/metadata-references.test.ts. - "every related list is readable by every profile its page is assigned to" in test/authorization-coverage.test.ts. spec 17.5.0 refuses `page.assignedProfiles`, so no page can declare it and both tests ran over zero pages. Remove the helpers that only they used (the `profileNames` import, the local `pages` list) and the header comments that described their checks. The changeset now also records the known 17.5.0 issue: the Products, Knowledge Articles and Forecasts default lists fail in every group. It is fixed upstream (objectui#11105, PR objectui#11119) and lands with the next platform release. Claude-Session: https://claude.ai/code/session_014VGCS11YUtYAiinRcdqQwL Co-authored-by: Claude <noreply@anthropic.com>
hotlong
marked this pull request as ready for review
September 30, 2026 06:10
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves HotCRM from ObjectStack 17.4.0 to 17.5.0 (published to
lateston 2026-09-29) and adopts the 17.5.0 breaking changes that reach this app's metadata.pnpm verifyis green locally.Known issue: on 17.5.0, three default list views render an error in every group. It is fixed upstream (objectui#11119, merged) and reaches HotCRM with the next platform release. The changeset records it. See Known platform issues.
Type of Change
Changes Made
@objectstack/*go 17.4.0 → 17.5.0.specVersion/engines.protocolmove to^17.5.0inobjectstack.manifest.jsonandobjectstack.config.ts.plugin-reportsleaves the tree.chartConfig.type/xAxis/yAxiskeys (8271c81, #19363). Every removed value matched the widget binding. Eight charts lose their axis titles.lookupscreen field declaresreference: 'crm_knowledge_article'(2f1a6f6, #17913), so it is now a real picker. Verified in the browser.object-metricfilters use theViewFilterRulearray (4792049, #17257).page.assignedProfilesdeleted from six pages: app_launcher, home, utility_bar, lead_detail, opportunity_detail, case_detail.security-role-wordreserves "role". zh/ja/es already said "job title".os lintnow requires translations for nested and slot page components. There are 14 keys in each of zh-CN / ja-JP / es-ES.os i18n extract --no-objects-only. The bare command does not scaffold page keys.$regexpremise test now reads the full diagnostic viawithheldFilterDiagnosticOfand also asserts that the public message does not name the operator.OS_AUTOMATION_SCHEDULED_WORK_ENABLED=true.whats-newgets a dated 17.5.0 line.Testing
pnpm verify(validate → typecheck → lint → lint:i18n-gate → hygiene ×2 → build → test): green ate91e1b3.objectstack devon 17.5.0 was booted on a database that 17.4.0 created. It was ready in 16 s.os migrate planon a copy of that database: 0 destructive changes, 1 additive column.PATCH400 ondisplay_title— no longer reproduces.pnpm test:e2e: 16/16 on 17.5.0.Known platform issues (filed upstream, not worked around)
select=id,[object Object],…when a view'scolumnsare objects. The Products, Knowledge Articles and Forecasts default lists showINVALID_FIELDin every group. The same views work on 17.4.0.@objectstack/consolecarries it. HotCRM then needs only a pin bump.GET /api/v1/usage/storageon every page, which logs a 404 on a self-hosted runtime.Checklist
.changeset/objectstack-17-5-0.md)Additional Notes
The maintainer decided to merge now rather than wait for the platform release, with the known issue recorded in the changeset. The diff touches no governed path, so it lands through the merge queue once every check is green.
Open for the maintainer, not blocking this PR:
pnpm devturn onOS_AUTOMATION_SCHEDULED_WORK_ENABLED? Without it, Demo Bootstrap and every SLA, expiry and reminder flow stop.isolated, each scheduled flow must name one organization.Generated by Claude Code