Repository navigation
feat(accounts): the account record page header draws the company logo (#1199) - #2041
Merged
objectstack-fleet[bot] merged 2 commits intoOct 9, 2026
Merged
Conversation
crm_account declares `imageField: 'logo'`, the object-level picture the platform's record chrome draws beside the title in every record page header (ruled on the card: an object-level declaration, not a page:header prop; no placeholder). An account with no logo shows none. Placed after highlightFields rather than on the line under nameField so the `account.object.ts:25` citation in the performance-and-limits pages (searchableFields) stays true. Claude-Session: https://claude.ai/code/session_018Mk4tab2eCyY41UTWK7y7V Co-authored-by: Claude <noreply@anthropic.com>
The accounts page (en, zh-Hans, zh-Hant) now says the company logo sits beside the title at the top of the account's detail page, and that an account without one shows no picture and no placeholder there. Claude-Session: https://claude.ai/code/session_018Mk4tab2eCyY41UTWK7y7V Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 9, 2026
zhuangjianguo
pushed a commit
that referenced
this pull request
Oct 9, 2026
…ent-paths Claude-Session: https://claude.ai/code/session_018Mk4tab2eCyY41UTWK7y7V Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1199
Clause-②: no
What
crm_accountdeclaresimageField: 'logo'. The record chrome in the console that the 17.7.0 pin installs draws that field beside the title in the account record page header. An account with no logo shows nothing there. This is the one half-row the ruling (5933225770, letter A) left open: an object-level declaration, not apage:headerprop, and no placeholder.src/sales/objects/account.object.ts:30holds the declaration, with a three-line comment. It sits afterhighlightFields, not on the line directly undernameField.content/docs/reference/performance-and-limits*.mdxcitesaccount.object.ts:25(searchableFields) in three locales, and that citation is accurate today. A line undernameFieldwould have shifted it, and those pages are outside this card's file surface.content/docs/sales/accounts.mdx,.zh-Hans.mdxand.zh-Hant.mdx, the Branding row now says where the logo shows. It also says that an account without a logo shows no picture or placeholder there. The zh pages use the field's zh-CN pack label, as the page already does..changeset/1199-account-logo-in-header.md:patch, following the precedent of the feat(metadata): give four declared-but-unnamed fields the consumer they should already have #1831 logo placement.No dependency change: the 17.7.0 pin already carries both the spec key and the console reader.
Measured
Browser check. Dev server on port 47199 from this worktree, Chromium at
/opt/pw-browsers/chromium, signed in as the dev admin. I uploaded the logo through the console's New Account form: presigned upload 200, then storage PUT 200, thenupload/complete200, thenPOST /api/v1/data/crm_account201. That created accountnon6T7vBSIEhYoeL, whoselogo.urlis/api/v1/storage/files/7e2e2241-c8c3-4852-b8d5-23510cdc2713. Every probe is a DOM read of the record page:imageField[data-record-picture]origin/mainac162c9logologoPublish-time refusal (throwaway check, not kept). I swapped the value to
imageField: 'name'(atextfield) on disk throughablation-replace(anchor 1 to 0, blob changed), then ranpnpm validate. Result:VERDICT command-exit 1, with the message "imageFieldnamesname, atextfield on objectcrm_account, which is not a picture." The file was restored withgit checkout HEAD: blob equal to HEAD,git diff HEADempty.pnpm verifyonbb0e650. Run through the shared lock:os-verify-lock: VERDICT command-exit 0. Results by step:--strictpassed: 18 suggestions, no errors or warnings.lint:i18n-gate: 0 issues.hygiene:tokens: clean.src/salesbusiness semantics is about 56,926 of a 59,000 ceiling, against the dispatch's reading of about 56,921 onac162c9.No test added. This repo pins none of
crm_account's object-level display keys by value; the cards view'scoverField: 'logo'has no pin either. The platform refuses a wrongimageFieldat parse, as the check above showed. A test assertingAccount.imageField === 'logo'would only restate the source line.Acceptance notes
Observed, not fixed here:
Every account record header's title reads Account Detail, the page label, instead of the account's name. The slot authors
title: '{name}'. The subtitle and actions from the samepropertiesbag render correctly, and the lead, opportunity and contact headers show the record's name. This was already true onorigin/main. The logo now sits beside that title. Handed to the seat as a finding.The nine seeded accounts boot
pendingwith no approval request: Edit is disabled, and Recall approval answers "No pending approval request found for this record". An account created in the console does open itsaccount_approvalrequest. Handed to the seat as a finding.The accounts page's "Account detail layout" section lists seven tabs (Overview, Opportunities, Contacts, Cases, Activity, Contracts, Files). The record page shows Details, Related and Attachments. Handed to the seat as a finding; not edited here, because the file surface covers only the header placement.
These line citations were already stale on
origin/main:performance-and-limits*.mdxcitesaccount.object.ts:358for the logo; the logo is at:590.:442forindexes; it is at:684.opportunity_line_item.object.ts:196citesaccount.object.ts:244-245.No carrier.
When Industry is blank, the subtitle renders as "· Prospect", with a leading separator. Polish; no carrier.
Generated by Claude Code