Skip to content

fix(i18n): 五处 zh-CN help 串按 B1 跟 label 收口 (#846) #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinlianghui merged 1 commit into from
Aug 6, 2026
Merged

fix(i18n): 五处 zh-CN help 串按 B1 跟 label 收口 (#846) #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .changeset/help-strings-follow-labels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
---
'hotcrm': patch
---

Five simplified-Chinese help bubbles now use the words the locale pack's own
labels use. A help string explains a label, so where the two disagreed the help
followed the label.

`src/translations/zh-CN.ts` was internally inconsistent in three places, and each
one sent the reader looking for a word the product never puts on screen:

| field | help said | pack's label says |
| --- | --- | --- |
| `crm_account.name_normalized` | 线索**转换**的匹配键 | `convert_lead` 转化线索 / `is_converted` 已转化 |
| `crm_lead.company_normalized` | 线索**转换**的匹配键 | 同上 |
| `crm_opportunity.win_reason` | 将商机关闭为"**赢单**"时必填 | `stage.closed_won` 成交 |
| `crm_opportunity.loss_reason` | 将商机关闭为"**丢单**"时必填 | `stage.closed_lost` 失败 |
| `crm_opportunity.crm_campaign` | 带来此商机的**市场活动** | 营销活动 (on the same line) |

The two reason fields are the sharpest case: the help quotes a stage **by name**,
and neither quoted word is in the stage picklist. A rep reading "将商机关闭为
赢单时必填" then opens the stage dropdown and finds 成交. The campaign one is the
starkest: 「市场活动」 was a zero-label word — this help string was its only
occurrence left anywhere in the repository once the documentation moved to
「营销活动」.

**Only the words used as references moved; the pack's own outcome vocabulary did
not.** 赢单/丢单 are what this pack calls a win and a loss — `win_reason` 赢单原因,
`loss_reason` 丢单原因, `loss_details` 赢/丢单详情, 赢单数, 丢单数, 赢单概率 — so
those labels are untouched, exactly as the Chinese documentation kept them. What
changed is only the word each help string quotes as a **stage value**, which is a
different fact from what the field is called.

The other three locales were checked field by field and were already consistent,
so nothing outside zh-CN changed. `ja-JP` in particular already writes what this
change makes zh-CN write — `win_reason` is labelled 受注理由 while its help quotes
the stage as 「成立」, the exact `closed_won` option label. `en` and `es-ES` build
the campaign help from the label's own head word (`Campaign` / `Marketing
campaign that generated this opportunity`), and their lead-conversion help shares
a lexeme with the convert action (`conversion` / `Convert Lead`).

Display text only: no field, option value, label, view or behaviour changed, and
no documentation page rendered any of these five strings.

Fixes #846.
10 changes: 5 additions & 5 deletions src/translations/zh-CN.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const zhCN: TranslationData = {
},
renewal_owner: { label: '续约负责人 (CSM)' },
next_renewal_date: { label: '下次续约日期' },
name_normalized: { label: '客户名称（规范化）', help: '线索转换的匹配键：客户名称转小写、去除首尾空格、内部连续空白合并为一个空格。由 account_protection 钩子维护——请勿直接编辑。' },
name_normalized: { label: '客户名称（规范化）', help: '线索转化的匹配键：客户名称转小写、去除首尾空格、内部连续空白合并为一个空格。由 account_protection 钩子维护——请勿直接编辑。' },
display_title: { label: '显示名称' },
},
_views: {
Expand Down Expand Up @@ -397,7 +397,7 @@ export const zhCN: TranslationData = {
options: { suspected: '疑似重复', confirmed: '已确认重复' },
},
display_title: { label: '显示名称' },
company_normalized: { label: '公司名称（规范化）', help: '线索转换的匹配键：公司名称转小写、去除首尾空格、内部连续空白合并为一个空格。由 lead_duplicate_check 钩子维护——请勿直接编辑。' },
company_normalized: { label: '公司名称（规范化）', help: '线索转化的匹配键：公司名称转小写、去除首尾空格、内部连续空白合并为一个空格。由 lead_duplicate_check 钩子维护——请勿直接编辑。' },
next_followup_date: { label: '下次跟进日期' },
last_contacted_date: { label: '最近联系时间' },
},
Expand Down Expand Up @@ -922,7 +922,7 @@ export const zhCN: TranslationData = {
label: '竞争对手',
options: { competitor_a: '竞争对手 A', competitor_b: '竞争对手 B', competitor_c: '竞争对手 C' },
},
crm_campaign: { label: '营销活动', help: '带来此商机的市场活动' },
crm_campaign: { label: '营销活动', help: '带来此商机的营销活动' },
days_in_stage: { label: '当前阶段天数' },
stage_entry_date: { label: '进入当前阶段日期', help: '本商机进入当前阶段的日期。' },
is_private: { label: '私密' },
Expand All @@ -932,7 +932,7 @@ export const zhCN: TranslationData = {
},
approved_date: { label: '批准时间' },
win_reason: {
help: '赢单原因。将商机关闭为"赢单"时必填。',
help: '赢单原因。将商机关闭为"成交"时必填。',
label: '赢单原因',
options: {
better_product: '产品更优', better_price: '价格更优', relationship: '客户关系',
Expand All @@ -941,7 +941,7 @@ export const zhCN: TranslationData = {
},
},
loss_reason: {
help: '丢单原因。将商机关闭为"丢单"时必填。',
help: '丢单原因。将商机关闭为"失败"时必填。',
label: '丢单原因',
options: {
price: '价格过高', competitor: '输给竞争对手', no_budget: '无预算',
Expand Down
Loading