Repository navigation
docs(service): 把工单字段的三套分组与 Details 页签写实 (#958) - #974
Merged
Merged
Conversation
…ource (#958) `content/docs/service/cases` opened its field section with "the detail screen is organised into 6 sections". No screen in this app has those six. The six names are `crm_case`'s `fieldGroups` — the object's own filing scheme — while the detail screen and the form each declare three sections of their own. The section now keeps all six names, says what they are, and gives the three layouts as three tables. Five of the six field-group rows were also wrong on their own terms, and the Details tab carries 16 of the object's 28 fields rather than "all metadata fields" — the twelve it does not carry are named, First Response Date first among them. English, Simplified Chinese and Traditional Chinese. Documentation only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrPAGEgFDoHjphqYG4BMa
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #958
content/docs/service/cases三语的两族失实::55「详情屏幕分为 6 个分区」表与:147「Details 页签有所有元数据字段」。src/零改动,纯文档。一、stale-premise 复核:issue 正文有一条不成立
issue 说
Origin & Routing/Escalation/System三个名字「在src/里根本不存在,grep 零命中」。实测不成立:六个名字全部是
crm_case.fieldGroups的 label(src/objects/case.object.ts:16-23,另有src/translations/en.ts:688-694的译文),连「两个默认折叠」都对得上(escalation/system各带defaultExpanded: false)。所以这张表不是凭空捏造的分区名,而是照抄了对象的字段分组、却挂到了「详情屏幕」名下。这改变了改写口径:不是「点名说清不存在」,而是「点名说清它们是什么、真正归属在哪」——本 PR 按后者写。
issue 另一处小偏差一并更正:详情页
Description分区只有collapsible: true、没有collapsed,所以是可折叠但默认展开,不是 issue 写的「默认折叠」(FormSectionSchema里collapsible/collapsed是两个各自默认false的布尔)。其余前提均复核成立:详情页
record:details三个分区、表单type: 'tabbed'三个分区、description归Description分区、parent_case只在表单。二、字段清点(本轮自己重数,未照抄 issue 数字)
crm_case声明 28 个字段(grep -cE "^ [a-zA-Z_][a-zA-Z0-9_]*: (Field|F)\.")。与 issue 一致。escalated_date(它用了「至少有」,属可接受的保守表述)。12 个已在正文逐一列出。fieldGroups覆盖 27 个(priority_rank不属任何分组)。三、改了什么
:55一段拆成三张表,各自标清出处:fieldGroupsrecord:detailsform(tabbed)fieldGroups那张表的六行里,原文有五行连「作为分组描述」都是错的(parent_case属basic不属origin、status/type属basic不属sla、closed_date属sla不属resolution、System装的是internal_notes/is_closed而不是「审计跟踪、时间戳」——工单上没有任何叫「审计跟踪」的字段),只有Escalation一行原样正确。这些都按实况写出,不静默删名。:147从「所有元数据字段」改为「28 个里的 16 个」,并点名十二个缺席字段;其中first_response_date单独点出(同页上文刚用一整段讲它怎么打戳,读者顺着「所有元数据字段」去找必然扑空)。四、渲染优先级依据
「六个分组在这两个界面上都不渲染」不是推断:objectui 的
resolveDetailSections(packages/plugin-detail/src/synth/buildDefaultPageSchema.ts)的次序是「显式 sections 优先 → 否则由fieldGroups推导 → 否则平铺」,而详情页与表单都显式声明了自己的分区。同一文件的RecordDetailsComponentProps也证实渲染器吃的正是本仓这种对象形式的sections({ name, label, fields, collapsible, collapsed })。五、验证
六道门在
flock -w 7200 /tmp/os-heavy-verify.lock内串行,全绿:validate/typecheck/lint/hygiene/build/test退出码均为 0(test:71 文件、1631 通过、1 跳过)。守卫盲区如实说明:本次改动只碰
content/docs/**与.changeset/,六道门里没有任何一道会解析 MDX 正文的事实性断言(hygiene对content/只扫控制字节与文件体积)。所以改动前后都是 predicted GREEN,绿不构成对本 PR 正确性的任何证据——证据是正文里逐条给出的 file:line 实测。推送前另做控制字节自扫:
grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]'对三个 mdx 与 changeset 零命中。未起 dev server。
@objectstack/*版本、content/docs/releases/、src/均未触碰;PR #939 / #946 / #947 / #956 的落地行零回退(diff 每文件只有:55与:147两个 hunk)。六、范围外发现
已另立 #970(
metadata+finding,未认领、未进队列):crm_case三套分组互不相同、escalated_date三处写入零处展示,以及layout: 'auto'/columns字符串数字混用这一处 props 形状问题。与 #806(crm_lead同病、不同对象)同族但非重复;上游 objectstack#5611 已 closed,未重复登记。Generated by Claude Code