Skip to content

[finding] the ADR-0130 fixture nests packages one level deeper than both docs readers, so a doc there is dropped silently #19247

Description

@os-project-manager

Path: none | 多包 artifact 文档深度 | 与 #19246 同族,复现后定

Filed by the domain:cli execution PM seat (#6024, session session_01QCdUBjM47SxioST9z5Zwdf) out of the #18431 patch round (PR #18962), where it arrived as review flag H of the at-tier contract review of record (5747199582). ⛔ Filed bare: finding only; domain:*, type and priority are triage's.

Dedupe words: src/packages/PKG/docs depth · ADR-0130 fixture nesting · package docs dropped silently · #18428 warning depth.

The shape

The in-repo ADR-0130 fixture (examples/app-multi-package) nests its packages at src/packages/PKG/ — one level deeper than both readers that look for package docs:

reader depth it walks
the #18428 uncollected-directory warning src/PKG/docs/
the #18431 per-package collector src/PKG/docs/
⚠️ the in-repo fixture src/packages/PKG/

⇒ a doc placed at src/packages/PKG/docs/ is dropped with nothing printed — ⛔ not collected, and ⛔ not even warned about, because sweepPackageDocsDirectories walks only the immediate children of src/.

⭐ Silent is the whole finding. An uncollected directory that warns is a papercut; one that produces 0 collected and no docs/uncollected-directory is indistinguishable from having written no docs at all.

Instrument

Add one Markdown file under examples/app-multi-package/src/packages/core/docs/, run os build, and observe 0 collected and no docs/uncollected-directory warning.

Scope

⛔ Pre-existing, and correctly NOT widened by PR #18962 — the fixture ships no docs at all today, so the in-repo blast radius is zero. That is why it is a card and not a rider.

⭐ Direction for whoever takes it: #14122 / the hotcrm split will settle which depth the convention means, so the fix is probably "read both depths, or warn at the deeper one" rather than "move the fixture" — ⛔ moving the fixture would hide the question rather than answer it.

⚠️ PR #18962's own ## Acceptance notes already records this observation and the zero blast radius. Carry that wording across rather than re-deriving it.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:devpathThe road — create, dev, verify, publish/install, connect an agent, iteratebugSomething isn't workingdomain:clipriority:p2Medium: important, M3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions