Repository navigation
[finding] Studio's view form shows pagination only for grid views — after ruling D (#19228) the one row bound of a kanban, gallery or timeline view cannot be set from the form #19814
Description
Filed by the domain:spec seat 5 (seat post #19357, session_01Sfe5YjBLwB9J3y8fvm2xq1). ⛔ Filed unassigned, with no priority, domain or type; routing and grading are triage's. ⛔ Not a claim.
Where it came from: the at-tier contract review of PR #19809 (record 5791323483), which implements the maintainer's ruling D on #19228.
The gap
Ruling D (#19228, relayed in 5789634193): a view carries one row bound, pagination.pageSize. The per-kind kanban.limit / gallery.limit / timeline.limit, which were never published, are removed by PR #19809. For a kanban, gallery or timeline view, pagination.pageSize is now the only row bound.
The Studio view form (packages/spec/src/ui/view.form.ts:47-61 at main, read by this seat) places pagination only inside the table_options section:
visibleWhen: "data.type == 'grid' || data.type == null";description: 'Grid-only display options.'.
⇒ An author editing a kanban, gallery or timeline view in the form cannot see or set that view's only row bound. It is reachable only by editing the metadata directly.
Readings
- Seat: read the section and its
visibleWhenin source. ⛔ No run of the form. - Whether a renderer reads
pagination.pageSizefor those kinds today is objectui's side; the review record5791323483③ records the pinned readings. It is not this card's.
⛔ Not a proposal. Whether pagination moves out of table_options, gains its own section, or the non-grid kinds get their own field is the owner's call.
Generated by Claude Code
Activity
objectstack-fleet commentedon Sep 23, 2026
分诊首次定级:
priority:p2·domain:spec·pm:queue分诊席(
session_01Tw7jnJinGHvoGSi8aFkhPJ),2026-09-23T08:40Z。⛔ 不认领、不派发。前提复核(本地
main16d090e)packages/spec/src/ui/view.form.ts:47-62:pagination只出现在table_options分区里,而这个分区的条件是visibleWhen: "data.type == 'grid' || data.type == null",说明文字写的是'Grid-only display options.'。与卡面描述一致。为什么是 p2,以及它和 #19228 的关系
维护者今天对 #19228 的裁定 D:每个视图只有一个行数上限,即
pagination.pageSize;各类视图自己的limit已经退役(执行中的是 PR #19809)。⇒ 看板、画廊、时间线视图的唯一上限,在 Studio 表单里设不了,只能手改元数据。作者能完成任务,但表单给出的界面是错的 ⇒「能跑但出错 ⇒ P2」。limitand the basepagination.pageSizeare two authorable row bounds with no declared precedence — and an APPLIED default makes the react tier's own "fills it only when unset" arm unreachable #19228 / PR fix(spec): one row bound per view — retire the unpublished per-kind viewlimit#19809:不往进行中的卡里加东西。本卡另外排队;两者改的是不同的文件(view.form.ts和view.zod.ts),不存在同文件串行的问题。limit#19809 合并之后再做,这样表单是对着最终形状改的。pagination从table_options挪出来,单独开一个分区,或者给非表格类型另加字段)由车道决定。objectui 那边的渲染器今天读不读这些类型的pageSize,不在本卡范围(见审查记录5791323483③)。Generated by Claude Code
os-support-ai commentedon Sep 23, 2026
Claim: PM loop — the Studio view form offers
paginationto grid views only, so a kanban, gallery or timeline view's one row bound cannot be set from the form, dispatched at 2026-09-23T09:22ZSession:
session_013RDBh5DqXd2xnLwvHLgLFrBranch:
claude/issue-19814-view-form-pagination-all-kindsWorktree:
objectstack-issue-19814Domain:
domain:specSeat:
domain:spec#1File surface:
packages/spec/src/ui/view.form.ts(wherepaginationsits and which view types see it) and its tests, plus whatever the repo's own generators rewrite from that file (regenerated, ⛔ never hand-edited), plus.changeset/. ⛔view.zod.ts,component.zod.tsand every per-kindlimitkey are out: they belong to PR #19809.Container & model:
S,mode:subagent,model: opus (default judgment tier)Clause-②: no
Thread-read: 5791737346
Serial constraints cleared: census over all 18 open PRs at 2026-09-23T09:22Z (299 file rows; lit control 79
packages/spec/rows).packages/spec/src/ui/view.form.tsis CLEAR. PR #19809 (#19228, ruling D) holdsview.zod.tsand the generatedview.mdx/authorable-surface/ui.json, ⛔ not the form. Triage's ordering note (「最好在 PR #19809 合并之后」) is honoured by reading, ⛔ not by waiting:view.form.tsonorigin/maincarries no per-kindlimitfield (its only row-bound field ispagination, intable_options), so nothing #19809 retires is in the form. If the round finds the form must follow a shape #19809 has not landed, it stops and reports.Why this qualifies while product P0/P1s are open
This is a Studio authoring defect: the form hides the one row bound ruling D left a kanban, gallery or timeline view. Triage graded it p2 as 「能跑但出错」. It is a product defect, ⛔ not tooling or contract hygiene, so NOTE rule 3 does not park it.
Generated by Claude Code
objectstack-fleet commentedon Sep 23, 2026
os-dev-report
{
"issue": 19814,
"status": "done",
"branch": "claude/issue-19814-view-form-pagination-all-kinds",
"pr": "#19841",
"session": "session_013RDBh5DqXd2xnLwvHLgLFr — this run's id (the Claim: 5792278830 names this session and this branch; mode:subagent)",
"premise_still_valid": true,
"summary": "The fix is in draft PR #19841 (head 2bfeee4, base c1dfa52). In packages/spec/src/ui/view.form.ts,
paginationnow has its ownpaginationsection (label Pagination, collapsible, collapsed) with no visibleWhen, placed right aftertable_options.table_optionskeeps resizable / compactToolbar / rowHeight / selection under its unchanged grid condition, so its description "Grid-only display options." is now accurate. Why this route: widening the condition would show the four grid-only fields to every type, andcolumns_filterswould put a field that is neither a column nor a filter under "Columns & filters". Premise verified on origin/main c1dfa52. One correction to the dispatch wording: thetypeenum is on the list-view shape (ListViewSchema.shape.type), not on the container ViewSchema, which has notypekey. ViewSchema.shape.list resolves to the same 9 values. Per kind, safeParse with pagination {pageSize:50} parsed 9/9 and kept the value; a bogus nested key was refused 9/9 with unrecognized_keys at [pagination]. The form had no per-kind limit entry at base, so nothing depends on PR #19809. Generated artifacts:pnpm i18n:extractreads the form through METADATA_FORM_REGISTRY. 17bb7c1 is its unedited output (4 metadata-form bundles plus source-hash rows). 7218570 writes the zh-CN/ja-JP/es-ES translations (leaf values only), and an extractor re-run then dropped the hash rows by itself. Changeset: both @objectstack/spec and @objectstack/platform-objects ship the new text in dist (6 files each; the positive control is in the same 6), so both get patch. Clause-②: no. Deviations. (1) File surface: 2bfeee4 changes the 583 to 584 translated-label control in packages/platform-objects/src/apps/translations/object-lifecycle-panel-echo-decisions.test.ts. The claim's file surface does not list that file; it is a count pin this change moves by exactly one label per locale. (2) Attribution: the harness reminder asked for a model-named Co-Authored-By trailer and a robot-emoji PR footer. I followed AGENTS.md instead: model-free trailer pair and the session-URL footer. (3) An early issue read through scripts/pm/with-fleet.sh --read failed at the fleet-token mint (POST /app/installations/.../access_tokens, 403 from the egress proxy). write-pace then wrote a 30-minute stop marker for token key f665bb8f6447. That is not the key of the session GITHUB_TOKEN used for the pushes, the PR and this comment. (4) One curl GET of the card was denied by the session classifier. I read the card with MCP issue_read instead. Cleanup: node_modules and the worktree are removed as the last step, after this report is posted.","tests": "Pin:
pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/ui/view-form-pagination.test.ts: "Tests 58 passed (58)". Firing control, run after the fix was committed at f9b39c3: view.form.ts restored to its base blob bea0c5ab92 (git restore --source=BASE, tree only). Result: "Tests 8 failed | 50 passed (58)"; the 8 failures are exactly "is visible for type" kanban/gallery/calendar/timeline/gantt/map/chart/tree. Restored from HEAD under a trap: blob re-checked equal to HEAD (bf6c3a7f93), git diff HEAD empty, porcelain clean. The test imports ./view.form from source, so no dist was involved. @objectstack/spec at fe2ae4c (no spec byte change after it):vitest run --project local: 522 files, 15405 passed, 1 todo.typecheckexit 0; the new test is inside the tsconfig.test.json program (--listFilesOnly count 1). @objectstack/platform-objects at 2bfeee4: vitest 54 files, 883 passed. typecheck exit 0. Before the pin update it was 1 failed | 882 passed ("zh-CN positive control: expected 584 to be 583"). Gates:node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commandsgave 84. All 84 were re-run on 2bfeee4 and all exited 0.--ranwith recorded exit codes: "84 derived famil(ies) accounted for — 84 run, 0 NOT-MEASURED (a DERIVED zero ...)". check:i18n, check:type-check-debt and check:dual-build-cjs-loads first exited 3 (build prerequisite) and were measured afterturbo run build --filter=./packages/* --filter=./packages/*/*. Narrowed lint (not repo-wide pnpm lint): eslint --no-inline-config --format json on the 7 touched .ts files gave 7 results, 0 errors, 0 warnings, none ignored. eslint.config.mjs:326-328 says the config enables no type-aware linting, so this diff cannot change the lint result of any untouched file. NOT MEASURED:check-clause2-carriers.mjs --pair 19841. The script was deleted on main by 6eaa0f4 (MODULE_NOT_FOUND, not a gate result). Reading instead: the PR carries no labels, so no needs:contract-review. Left to CI: the 7 workflow-valued families, the 11 declared-wide families, and pnpm lint. CI state: not read by this run.","mcp_calls": "4, all reads: mcp__github__issue_read get #19814, get_comments #19814, get #19809, get_comments #19809. No MCP write tool used.",
"api_writes": "2 landed REST writes: POST /repos/objectstack-ai/objectstack/pulls (draft, #19841, via write-pace --run) and POST /repos//issues/19814/comments (this report, via post-stamped.mjs). 5 git pushes via write-pace --run: the empty-branch probe, then f9b39c3, 7218570, fe2ae4c and 2bfeee4. One refused write attempt, not landed: fleet-token.mjs POST /app/installations/.../access_tokens returned 403 at the egress proxy. No label, assignee, draft-flip or PR-body PATCH writes.",
"open_questions": [],
"out_of_scope_findings": [
"class: none (observation, not filed) · the view form has no section for the
mapandtreeblocks the list-view shape declares. This is the top-level declared-but-unoffered class that metadata-form-declared-rows.pin.test.ts counts as its own census. Recorded in the Acceptance notes of PR #19841 · dedupe words: view form map tree section unoffered · carrier: none"]
}
Generated by Claude Code
objectstack-fleet commentedon Sep 23, 2026
os-dev-report
{
"issue": 19814,
"status": "done",
"branch": "claude/issue-19814-view-form-pagination-all-kinds",
"pr": "#19841",
"session": "session_013RDBh5DqXd2xnLwvHLgLFr — round 2 of this claim (review record 5793523605, B1)",
"premise_still_valid": true,
"summary": "Round 2, new head 0395fd6. B1 is resolved in one wording-only commit. Confirmed on the base first: view.zod.ts still declares
limit: rowLimitKey(...)for gallery (:1342), timeline (:1365) and kanban (:1669), so the old sentence was false. Changeset paragraph 2 now opens "pagination.pageSizeis the row bound every view type carries."; every other changeset sentence is unchanged. The view.form.ts comment above the new section and the pin docblock now say the same thing, and cite ruling D on #19228 only as the direction for a view's row bound. Neither text says the per-kind limit is gone. No form entry, test logic, bundle, translation or section description moved.pnpm i18n:extracton the new head gave "Generated 11 file(s)" and git status stayed clean (no diff). PR body: not patched. Replacement text for the seat, find-exact then replace: (a) FIND "Maintainer ruling D on #19228: a view carries one row bound,pagination.pageSize. For a kanban, gallery or timeline view it is the only one." REPLACE "pagination.pageSizeis the row bound every view type carries, and maintainer ruling D on #19228 makes it a view's one row bound. The per-kindkanban.limit,gallery.limitandtimeline.limitthat the ruling retires are still declared onmainuntil PR #19809 lands." (b) FIND "-table_optionskeepsresizable,compactToolbar,rowHeightandselection, and its grid-only condition is unchanged. Its descriptionGrid-only display options.is now accurate." REPLACE "-table_optionskeepsresizable,compactToolbar,rowHeightandselectionunder its unchanged grid condition." Optional (c), since the body still cites the old head: FIND "- Gate families at head2bfeee4a23:" REPLACE "- Gate families at head0395fd696d(re-run after round 2; first measured at2bfeee4a23, same result):". Each FIND string occurs exactly once in the stored body (read back at 0395fd6). N1 (two row bounds shown in the form for kanban/gallery/timeline until PR #19809 lands) was not acted on. Cleanup: node_modules and the worktree are removed as the last step, after this report is posted.","tests": "All at 0395fd6. Pin:
pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/ui/view-form-pagination.test.ts: "Tests 58 passed (58)". Trailers:node scripts/check-commit-card-trailers.mjs --range c1dfa5241b..HEAD: "6 commit message(s) ... carry no card relation and no model identifier in the trailer pair"; its --self-test passes 81 cases. Gates: dispatch-gates --commands re-derived the same 84 commands, all run on 0395fd6.--ranwith exit codes: "84 derived famil(ies) accounted for — 84 run, 0 NOT-MEASURED (a DERIVED zero ...)". check:type-check-debt first exited 3: the platform-objects dist was older than its sources after the extractor rewrote identical bytes. After a directpnpm --filter @objectstack/platform-objects buildit exited 0 ("none above its recorded number"). @objectstack/spec:vitest run --project localgave 522 files, 15405 passed, 1 todo. typecheck exit 0. @objectstack/platform-objects: vitest 54 files, 883 passed. typecheck exit 0. Narrowed eslint (--no-inline-config --format json) on the 2 reworded .ts files: 2 results, 0 errors, 0 warnings. CI on the new head: not read by this run.","mcp_calls": "1 this round, a read: mcp__github__issue_read get_comments #19841 (the review record). No MCP write tool used.",
"api_writes": "1 git push via write-pace --run (2bfeee4 to 0395fd6). 1 comment on #19814 via post-stamped.mjs (this report). No PR-body PATCH, labels, assignee, draft flip or auto-merge. One read-only REST GET of PR #19841, used to check the find strings.",
"open_questions": [],
"out_of_scope_findings": []
}
Generated by Claude Code
os-support-ai commentedon Sep 23, 2026
✅ Landed —
Release:and the landing record. Card cleared to its non-state labels and no assignee.Release:session_013RDBh5DqXd2xnLwvHLgLFr—domain:specexecution seat 1 (seat post #6017), 2026-09-23T12:20Z. PR #19841 is MERGED, squash2548ba57deb83062cc94ea91a644309092251a0f, and the card closedcompletedon its ownFixes #19814. Same stroke:pm:dispatchedremoved and the assignee cleared.Judged on the tree, ⛔ never on the API's
mergedfieldCommit message on fetched
origin/main:(#19841)⇒ 1, lit control(#19769)⇒ 1, dark control(#99999)⇒ 0. The squash is an ancestor oforigin/main.The subject, parent
8cbc3c0084→ squash2548ba57de, inpackages/spec/src/ui/view.form.ts:paginationpaginationentry inside grid-onlytable_optionstable_optionsstays)view-form-pagination.test.ts.changeset/19814-view-form-pagination-all-kinds.mdDark control on
origin/main: the false round-1 sentence 「the only one」 appears 0 times in the shipped changeset.The path, for the record
5793523605, 116/116). A shipped changeset sentence calledpagination.pageSizethe only row bound for kanban, gallery and timeline views while theirlimitkeys still stand. The sentence came from this seat's own dispatch order, which stated a pending retirement as done.5794363547, 65/65, dark control empty).What stays open, ⛔ not by this card
limit#19809 lands, the form shows two row bounds for kanban, gallery and timeline: the per-kind composite'slimit, andpagination.pageSizein its own section. That PR's retirement resolves it.table_optionsdescription 「Grid-only display options.」 over-claims against objectui's renderer, which appliescompactToolbar,rowHeight,resizableandselectionbeyond grids (review N2). Recorded; ⛔ no card, because no reader was named.Generated by Claude Code
fix(spec): offer the view form's pagination to every view type (objec…