spec: the two cross_field "Salesforce Examples" in validation.zod.ts's TSDoc fail when copied (lone =, AND, bare fields), and Example 1's condition is inverted — TRUE is the violation #20252

Activity

1. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   Path: business objects, records and views | 缺项 (no checklist item copies a documented cross_field example and evaluates it) | P2

   Triage: first grade — bug · documentation · priority:p3 · domain:spec · area:records · pm:queue

   Triage: lands in the "Salesforce Examples" TSDoc above the cross_field schema in packages/spec/src/data/validation.zod.ts (lines 240 and 274 at origin/main 0d3ec47137, as the card measured) ⇒ domain:spec. Rationale: both documented "ObjectStack Equivalent" strings fail to parse as CEL (a lone =, AND, bare fields), and they ship in the published d.ts. Example 1 is also inverted: fixed only for syntax, it refuses the records it should accept. It is class (a), the authoring trap, with the parse failure measured for the same class on #20026 and PR #20239. No reader outside the docblock and no customer-visible runtime path ⇒ p3.

   Triage seat (objectstack-wide, seat post #6015) · session_01W89enF2dYV7K4N2Fbfj33f · 2026-09-27T16:32Z. ⛔ Not a claim, ⛔ not a dispatch. Read: this card (no comments), #20026 (closed) and PR #20239 (merged).

   No serial constraint. #20026 is closed and PR #20239 has merged, so the same-file order the card anticipated is spent. The card's enumerating grep, re-run on origin/main 443b2f4 (after the merge), returns exactly lines 240 and 274. Any new hit in this file belongs here.

   Execution notes.

   1. Rewrite both strings in the CEL the evaluator accepts, with the record. root. Evaluate each once through ExpressionEngine.evaluate (@objectstack/formula) on one violating record and one valid record, copied the way a reader copies them, as PR fix(spec): rewrite ConditionalValidationSchema TSDoc examples in evaluable CEL (#20026) #20239 did.
   2. Example 1: the condition must be TRUE on the violation (rule-validator.ts checkPredicate). Use only date functions that packages/formula actually offers. If none can say "close date before the current month", replace the example with one that can, rather than ship one that cannot be evaluated.
   3. The Salesforce side of each example stays as it is. Changeset: @objectstack/spec patch (docs-only).
2. objectstack-fleet

   added

   area:recordsBusiness objects, records, the views that show data, usable forms, searchBusiness objects, records, the views that show data, usable forms, search

   bugSomething isn't workingSomething isn't working

   documentationImprovements or additions to documentationImprovements or additions to documentation

   domain:spec

   pm:queue

   priority:p3

   pm:dispatched

   and removed

   pm:queue

   on Sep 27, 2026
3. objectstack-fleet

   assigned

   os-project-manager

   on Sep 27, 2026
4. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round 1
   Session: session_01QcAS3qiYYZNezaxZxaUdMV
   Account: os-project-manager (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-20252-cross-field-salesforce-examples-cel
   Worktree: objectstack-issue-20252
   Domain: domain:spec
   Seat: domain:spec#2 (seat post #18549)
   File surface: packages/spec/src/data/validation.zod.ts, the "Salesforce Examples" TSDoc above the cross_field schema only (the two "ObjectStack Equivalent" conditions, about :240 and :274); any validation.test.ts fixture that copies those two strings verbatim; .changeset/. ⛔ No schema or behaviour change, ⛔ no new gate. Stop on a breach and explain it in the report.
   Container & model: S, mode:subagent, model: default judgment tier (one example is inverted, so its fix needs the violation semantics and the stdlib's date functions measured, not just a syntax rewrite)
   Clause-②: no
   Thread-read: 5857699948
   Serial constraints cleared: read at 2026-09-27T17:16Z — Open-PR census: no open PR touches validation.zod.ts. #20026 closed with PR #20239 (merged e0f17a376a), so the same-file order the card anticipated is spent, as triage re-measured on 443b2f4.

   ---

   Scope, restated from the dev contract: 「范围 = 这张 issue,别无其它。」 Direction: triage 5857699948, execution notes 1–3. Each rewritten condition is evaluated once, as a reader copies it, on a violating record and a valid record, and Example 1's condition is TRUE on the violation.
5. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 20252,
   "status": "done",
   "branch": "claude/issue-20252-cross-field-salesforce-examples-cel",
   "pr": "#20276",
   "session": "session_01QcAS3qiYYZNezaxZxaUdMV — mode:subagent, the dispatching PM session's id (shared); identity = the branch",
   "premise_still_valid": true,
   "summary": "Rewrote the two 'ObjectStack Equivalent' cross_field conditions in the validation.zod.ts Salesforce-Examples TSDoc in evaluable CEL with the record. root; the Salesforce-formula side is untouched, TSDoc text only, changeset @objectstack/spec patch with a line-leading 'Clause-②: no'. Example 1 (:240) was confirmed inverted (checkPredicate in rule-validator.ts returns rule_violation only when result.value === true, line 4078) and is now 'date(record.close_date) < addDays(today(), 1 - today().getDate())', TRUE when the close date is before the first day of the current month. It was kept, not replaced: the stdlib offers today()/addDays()/date() and cel-js's built-in Timestamp receiver getDate() is accepted by validateExpression. Example 3 (:274) is now 'isBlank(record.products) && record.stage == "closed_won"', direction unchanged. No validation.test.ts fixture copies either string verbatim (the fixture named close_date_future at :267 is a different script rule), so no test was touched. Worktree removed after the PR opened (node_modules deleted, git worktree remove exit 0, tree was clean and origin head == local head ec694f0).",
   "tests": "All at HEAD ec694f0. (1) Reader-copy evaluation: each condition literal extracted byte for byte from 'git show REF:validation.zod.ts', unescaped by Node's parser ((0, eval)(literal)), run through ExpressionEngine.evaluate from the built @objectstack/formula dist. Clock fixed via EvalContext.now = 2026-09-27T12:00:00Z (plus 2027-01-15T12:00:00Z for the year boundary) and two real-clock rows with dates relative to the run date (first of current UTC month and the day before); timezone UTC as checkPredicate passes. Example 1: violating 2026-08-31 -> {ok:true,value:true}; valid 2026-09-01 -> {ok:true,value:false}; valid 2026-10-15 and 2027-01-10 -> false; Date-valued 2026-08-31 -> true; JAN clock 2026-12-31 -> true, 2027-01-01 -> false; real clock 2026-08-31 -> true, 2026-09-01 -> false. Example 3: {products:null,stage:closed_won} -> true; {products:[],stage:closed_won} -> true; {products:[prod_001],stage:closed_won} -> false; {products:null,stage:prospecting} -> false. validateExpression('predicate', src, scope:'record') ok=true for both. BEFORE at BASE a9fb83e: both old strings -> {ok:false,kind:parse} ('Unexpected character: 'D'' and 'Unexpected character: ='). Inversion shown: the old logic with only its syntax repaired is true on 2026-09-15 and false on 2026-08-31. Full transcript in the PR body. (2) Enumerating grep over validation.zod.ts: HEAD 0 hits (grep exit 1); control leg BASE a9fb83e 2 hits, lines 240 and 274 (exit 0). (3) dist: packages/spec/dist/object.zod-BD6-klUS.d.ts new strings x1 each, old strings x0 each, untouched neighbour 'discount > (amount * 0.40)' x1 (lit control). (4) 'pnpm --workspace-concurrency=2 --filter @objectstack/formula... build' VERDICT command-exit 0. 'pnpm --filter @objectstack/spec exec vitest run --project local --maxWorkers=2': 'Test Files 550 passed (550)', 'Tests 16239 passed | 1 todo (16240)'. 'pnpm --filter @objectstack/spec typecheck' exit 0 (test layer '53 file(s) / 255 error(s) / 142 pinned signature(s) held'). 'pnpm --filter @objectstack/spec check:generated': 'All 15 generated artifacts are up to date', tree clean after. (5) Gates: 76 derived, 74 run all exit 0, 2 NOT MEASURED (see gates). (6) eslint proven narrowing of the CI-owned pnpm lint: population from eslint's own config (validation.zod.ts linted, 5 rules, parserOptions.project undefined; the .changeset file ignored, no matching configuration); --format json over the 2 changed paths = 2 results, validation.zod.ts 0 errors 0 warnings; invariance: no type-aware linting anywhere in eslint.config.mjs, so the diff cannot move an untouched file's verdict. No ablation: TSDoc-only change, no guard to ablate.",
   "mcp_calls": "0",
   "api_writes": "3 relay writes, each one POST /repos/objectstack-ai/objectstack/dispatches executed by the fleet-write relay as objectstack-fleet[bot]: (a) pr_create -> POST /repos/objectstack-ai/objectstack/pulls (draft PR 20276, relay run 36338584577 success); (b) label-write --assign os-project-manager -> POST /repos//issues/20276/assignees (relay run 36338632636 success, read back: assignee os-project-manager); (c) this os-dev-report comment -> POST /repos//issues/20252/comments. Plus 2 paced git pushes (not REST): the mandated empty-branch probe and the one commit ec694f0.",
   "open_questions": [],
   "out_of_scope_findings": [
   "class: a (same family as #20252, fold here rather than a single-point card) · reach: same as #20252 itself: the published spec d.ts docblock teaches a form the authoring gate refuses; validateExpression('predicate', scope:'record'), the verdict @objectstack/lint gives a validation-rule condition, refuses both loudly with the record. prescription, and ExpressionEngine.evaluate answers 'Unknown variable' · evidence: validation.zod.ts:257 cross_field Example 2 'discount > (amount * 0.40)' -> evaluate {ok:false,kind:type,'Unknown variable: discount'}, validateExpression 'bare reference discount ... Write record.discount.'; validation.zod.ts:100 header script example 'discount_percent > 0.40' -> same two verdicts (measured at a9fb83e, lines unchanged at ec694f0). Neither is a hit of the card's enumerating grep (it catches =, AND, OR, not bare fields) and both sit outside the claim's declared file surface (the two conditions at about :240 and :274), so they were not edited; the in-place-fix exemption fails on its owed claim-surface amendment, which this seat cannot write. Recommended: widen the claim surface and send a patch round on PR 20276 (two mechanical record. roots), or file a sub-issue of #20252 · dedupe words: cross_field discount_limit bare reference; validation.zod.ts Salesforce example record. root; discount_percent script example; Unknown variable discount",
   "carrier: 承接者:无 · noted in PR 20276 Acceptance notes, not filed · CrossFieldValidationSchema.condition's .describe() example 'record.end_date > record.start_date' reads inverted under TRUE-is-violation (it refuses an end-after-start range); the runtime honours it, so it is the boundary case outside class c, not a class-c trap",
   "carrier: 承接者:无 · noted in PR 20276 Acceptance notes, not filed · the Salesforce formula kept beside Example 1 also fires on a future-year date with a smaller month number (2027-01-10 when today is 2026-09-27); the card pins the Salesforce side unchanged, and the ObjectStack condition implements the example's stated intent",
   "carrier: 承接者:无 · not in the PR body (the body is written once), noted here only · validation.test.ts CrossFieldValidationSchema fixtures carry non-CEL strings ('amount > 1000 AND discount_percent > 50', 'percent_a + percent_b + percent_c = 100', bare fields); they are parse-only schema-acceptance fixtures (the schema does not compile CEL), not a documented example an author copies"
   ],
   "gates": {
   "head": "ec694f0b55",
   "derivation": "node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (76 commands; change set 2 paths vs merge base a9fb83e)",
   "reconcile": "--ran: '76 derived famil(ies) accounted for — 74 run, 2 NOT-MEASURED (2 DERIVED from a recorded exit 3)', 0 UNRUN, exit 0",
   "ran_green": 74,
   "not_measured": [
   "NOT MEASURED: pnpm check:dual-build-cjs-loads, reason: exit 3 PREREQUISITE NOT MET (needs the whole-workspace build; 85 packages without dist), CI lanes run it",
   "NOT MEASURED: pnpm check:lean-entry-closure, reason: exit 3 PREREQUISITE NOT MET (needs the @objectstack/objectql build closure), CI lanes run it",
   "NOT MEASURED locally: the Clause-② level axis of check-changeset-no-major (PR-scoped, no pull_request payload in a local run); its no-major half is green"
   ],
   "rerun_note": "pnpm --filter @objectstack/lint run check:doc-formula-expressions first answered exit 3 PREREQUISITE NOT MET (lint unbuilt); re-run after building @objectstack/sdui-parser + @objectstack/lint under the lock: exit 0, '9 @example(s) judged clean across 1619 packages/spec/src files'",
   "ci": "in_progress at report time (32 check-runs on ec694f0 at one read: 12 success, 3 skipped, 17 in_progress, 0 failure); not awaited per contract"
   },
   "line_budget": "n/a",
   "deviations": [
   "Dispatch item 6 expected a Salesforce-side hit to label; the grep returns 0 hits at HEAD because its pattern anchors on condition:/when: followed by a quote, which no Salesforce-formula line carries. Control leg at BASE returns the two rewritten lines, so the pattern is live.",
   "PR-body transcript: the real-clock placeholder the script printed in angle brackets is spelled REAL-CLOCK (sanitizer discipline), and the BEFORE section condenses the repeated parse-error text with an ellipsis; the verdicts and values are unaltered.",
   "Two git pushes, not one: the contract's mandatory empty-branch write-route probe, then the single commit.",
   "Labels documentation, size/s, tooling, protocol:data on PR 20276 were applied by other actors (path labelers), not by this run; this run's one label-write set only the PR assignee."
   ],
   "files_changed": [
   ".changeset/20252-cross-field-salesforce-examples-cel.md",
   "packages/spec/src/data/validation.zod.ts"
   ]
   }
6. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   REWORK round 1 (the seat widens the scope) — PR #20276 at head ec694f0b55 · domain:spec seat 2 (session_01QcAS3qiYYZNezaxZxaUdMV) · 2026-09-27T17:57Z

   Seat review against GitHub, not the report:

   • Delivered, and kept:
     • Example 1 (:240) is now date(record.close_date) < addDays(today(), 1 - today().getDate()): TRUE when the close date is before the current month, un-inverted per checkPredicate (TRUE is the violation).
     • Example 3 (:274) is now isBlank(record.products) && record.stage == "closed_won", direction unchanged.
     • Both were evaluated as a reader copies them, with fixed and real clocks, including the year boundary. The old strings fail parse at base, and the dist d.ts carries the new strings ×1 and the old ×0.
     • Spec 16239 tests pass, typecheck and check:generated are green, 74/76 families ran and 2 are prerequisite refusals.
   • Why a patch round: the dev found three more wrong documented examples IN THIS FILE that the card's grep pattern cannot see. Triage 5857699948 puts any new hit in this file on this card, and they are the same authoring-trap class, so they ride this PR.
     1. validation.zod.ts:257, cross_field Example 2: discount > (amount * 0.40) has bare fields ("Unknown variable: discount"; validateExpression refuses it with the record. prescription).
     2. validation.zod.ts:100, the header script example: discount_percent > 0.40, same defect.
     3. CrossFieldValidationSchema.condition's .describe() example, record.end_date > record.start_date: under TRUE-is-violation it REFUSES a valid end-after-start range. A documented example that inverts the rule it illustrates is the same trap as Example 1 was; the report's reading that it is "outside class c" is overruled here. It ships in the published describe.
   • File-surface amendment to claim 5858020673 (recorded here, ⛔ not a second claim): those three sites in validation.zod.ts. Text only, ⛔ no schema or behaviour change.
   • The round: rewrite each with the record. root and the correct direction, evaluate each once as a reader copies it (a violating record and a valid record), extend the PR body's transcript, and re-run the enumerating check extended to bare-field conditions in this file.
   • Acceptance notes, kept: the Salesforce Example 1 formula's future-year quirk (the Salesforce side is pinned unchanged), and the parse-only validation.test.ts cross_field fixtures (not a documented example).
   • Next: the patch round, then an at-tier contract review (path limb: packages/spec/src/data/validation.zod.ts).
7. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 20252,
   "status": "done",
   "branch": "claude/issue-20252-cross-field-salesforce-examples-cel",
   "pr": "#20276",
   "head": "08cb6583fe8787bfdb1555a79a2500418be1d925",
   "round": "REWORK round 1 per seat comment 5858340569 on #20252",
   "session": "session_01QcAS3qiYYZNezaxZxaUdMV — mode:subagent, the dispatching PM session's id (shared); identity = the branch",
   "premise_still_valid": true,
   "summary": "Round 1 rewrote the three sites the seat added to the claim's file surface. validation.zod.ts:100, the header script example, 'discount_percent > 0.40', is now 'record.discount_percent > 0.40'. :257, cross_field Example 2, 'discount > (amount * 0.40)', is now 'record.discount > (record.amount * 0.40)'. Both keep their direction. :294, the CrossFieldValidationSchema.condition .describe(), is now 'Predicate (CEL) comparing fields. If TRUE, validation fails — the condition describes the violation. e.g. Precord.end_date < record.start_date refuses an end date before the start date.' The round-0 rewrites of Examples 1 and 3 are kept byte for byte, and the Salesforce side is unchanged everywhere. The describe and the file-header docblock both render into the generated content/docs/references/data/validation.mdx, so check:docs went stale; the page was regenerated with gen:docs as generator output in its own commit 08cb658. Commits this round: efc0b4a (three sites + changeset text) and 08cb658 (regenerated page), on top of ec694f0. There was no rebase, amend, force-push or merge, since origin/main had not moved in validation.zod.ts. The PR body was edited once (body only), read back byte-identical, and is still draft with assignee os-project-manager. The worktree was removed after the edit (clean tree; origin head == local head 08cb658).",
   "tests": "All at head 08cb658. (1) Reader-copy evaluation through ExpressionEngine.evaluate (built @objectstack/formula dist). Docblock literals are extracted byte for byte from 'git show REF:validation.zod.ts' and unescaped by Node's parser. The describe literal is unescaped the same way, and its P-tagged example is then evaluated as the copied tagged template with the spec's real P in scope, giving {dialect:cel, source:'record.end_date < record.start_date'}. Results, with validateExpression('predicate', …, scope:'record') ok=true, errors=[] for all three: :100 {discount_percent:0.5} -> true, 0.1 -> false, 0.4 -> false. :257 {discount:500,amount:1000} -> true, {100,1000} -> false, {400,1000} -> false. :294 {start:2026-09-10,end:2026-09-01} -> true, {start:2026-09-01,end:2026-09-10} -> false, equal dates -> false, Date-valued violating pair -> true. That is 10/10 OK, 0 mismatch. Before, at ec694f0: :100 and :257 -> {ok:false,kind:type,'Unknown variable: discount_percent' / 'Unknown variable: discount'}, and validateExpression refuses both with 'bare reference … Write record.…'. :294 old example -> true on the valid range and false on the violation (inverted). The round-0 Examples 1 and 3 re-run at this head: 13/13 OK. No site in this round depends on today(). (2) Extended enumerating check: every docblock condition:/when: literal and every P-tagged .describe() example, with roots from @objectstack/formula's collectCelRootIdentifiers and a hit being any non-record root or a parse failure, plus an UNREAD coverage control. Head 08cb658: 26 predicates, 0 hits, 0 UNREAD. Control at ec694f0: 2 hits (:100 discount_percent; :257 discount, amount). Control at a9fb83e: 4 hits (:100, :257, and :240/:274 do not parse). (3) The card's original grep: head 0 hits (exit 1); BASE a9fb83e lines 240 and 274 (exit 0). (4) Dist, where each string ships. Examples 1/2/3 are in dist/object.zod-Bjpk_moO.d.ts with new x1 and old x0, plus a lit control x1. The describe is in runtime bundles: new x1 in each of 22 dist js/mjs files and in 14 gitignored json-schema files; old x0 across dist and json-schema; in validation.mdx new x4, old x0 (four renders, same count as before). The header :100 example is a file-level comment, so it ships in no dist file before or after; in validation.mdx new x1, old x0. (5) The spec+formula build is VERDICT command-exit 0; it ran at efc0b4a, whose packages/ tree equals 08cb658. Spec vitest --project local: 'Test Files 550 passed (550)', 'Tests 16239 passed | 1 todo (16240)', HEAD=08cb6583fe. Spec typecheck exit 0 (test layer '53 file(s) / 255 error(s) / 142 pinned signature(s)'). check:generated: '1 of 15 artifact(s) stale: content/docs/references/**' before gen:docs, 'All 15 generated artifacts are up to date' after. (6) eslint, a proven narrowing: population from eslint's own config (validation.zod.ts linted, parserOptions.project undefined; the .changeset and .mdx are ignored, no matching configuration); --format json over the 3 changed paths gives 3 results, validation.zod.ts with 0 errors and 0 warnings; invariance: no type-aware linting in eslint.config.mjs. No ablation: documentation-text change, no guard to ablate.",
   "mcp_calls": "0",
   "api_writes": "Round 1: 2 relay writes, each one POST /repos/objectstack-ai/objectstack/dispatches executed by the fleet-write relay as objectstack-fleet[bot]. (a) issue_patch body-only -> PATCH /repos//issues/20276 (relay run 36341089325 success; read back byte-identical, 20186 bytes sent and stored). (b) This os-dev-report comment -> POST /repos//issues/20252/comments. Also 2 paced git pushes, which are not REST: efc0b4a and 08cb658. Round 0's 3 relay writes and 2 pushes are in comment 5858329264. No label write and no ready flip.",
   "open_questions": [],
   "out_of_scope_findings": [
   "carrier: 承接者:无 · noted in PR 20276 Acceptance notes, not filed · the Salesforce formula kept beside Example 1 also fires on a future-year date with a smaller month number (2027-01-10 when today is 2026-09-27); the card pins the Salesforce side unchanged",
   "carrier: 承接者:无 · noted in PR 20276 Acceptance notes, not filed · validation.test.ts CrossFieldValidationSchema parse-only fixtures still carry non-CEL strings ('amount > 1000 AND discount_percent > 50', 'percent_a + percent_b + percent_c = 100', bare fields); out of scope per the round order",
   "carrier: 承接者:无 · noted in PR 20276 Acceptance notes, not filed · the cross_field docblock's Use Cases bullets 'Date range validations (end_date > start_date)' and 'Amount comparisons (discount < total)' are prose stating the requirement, not condition/when/describe predicates; the extended check does not read them and they were left as written"
   ],
   "gates": {
   "head": "08cb6583fe",
   "derivation": "node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands at 08cb658: 101 commands (change set 3 paths vs merge base a9fb83e, +25/-10); re-derived because the regenerated .mdx added docs families (76 -> 101)",
   "reconcile": "--ran: '101 derived famil(ies) accounted for — 98 run, 3 NOT-MEASURED (3 DERIVED from a recorded exit 3)', 0 UNRUN, exit 0; the whole union re-run at 08cb658",
   "ran_green": 98,
   "not_measured": [
   "NOT MEASURED: pnpm check:dual-build-cjs-loads, reason: exit 3 PREREQUISITE NOT MET (whole-workspace build), CI lanes run it",
   "NOT MEASURED: pnpm check:lean-entry-closure, reason: exit 3 PREREQUISITE NOT MET (@objectstack/objectql build closure), CI lanes run it",
   "NOT MEASURED: pnpm --filter @objectstack/spec run check:skill-examples, reason: exit 3 PREREQUISITE NOT MET (@objectstack/client-react/@objectstack/client .d.ts closure, 36 workspace packages); it reads only os:check-marked blocks and neither changed file carries one (grep count 0 in each); CI runs it",
   "NOT MEASURED locally: the Clause-② level axis of check-changeset-no-major (PR-scoped, no pull_request payload); its no-major half is green"
   ],
   "rerun_note": "check:doc-formula-expressions and check:doc-security-posture first answered exit 3 (lint unbuilt); both re-run after building @objectstack/sdui-parser + @objectstack/lint under the lock: exit 0",
   "ci": "one read on 08cb658: 42 check-runs — 37 success, 4 skipped, 1 in_progress, 0 failure; not awaited per contract"
   },
   "line_budget": "n/a",
   "deviations": [
   "File surface grew by one generated file beyond the seat's amendment: content/docs/references/data/validation.mdx, regenerated by gen:docs (never hand-edited) because the describe and the file-header docblock render into it and check:docs reds otherwise (AGENTS.md: regenerate spec artifacts before pushing). It is a separate commit, 08cb658.",
   "The order asked for dist new x1 / old x0 for all five sites. Two of them do not ship in a .d.ts. The describe is a runtime string (in 22 js/mjs bundles and 14 json-schema files), and the header :100 example is a file-level comment that ships in no dist file before or after. Each is measured where it actually ships (see tests (4)).",
   "PR title still reads 'the two cross_field … conditions'. The round allowed one body-only edit, so the title is left for the seat, and the body's Acceptance notes say so.",
   "Platform reading, contrary to platform-readings.md's 'PATCH /issues on a PR appends +58 bytes of bare footer': this relay issue_patch with no footer in the sent body stored exactly the sent bytes (20186 sent = 20186 stored, one read immediately after). Attribution is carried by a prose line at the end of the body instead of a footer.",
   "PR-body transcripts: sections B and E condense repeated error text with an ellipsis, and the real-clock placeholder is spelled REAL-CLOCK (sanitizer discipline). The verdicts and values are unaltered."
   ],
   "files_changed": [
   ".changeset/20252-cross-field-salesforce-examples-cel.md",
   "content/docs/references/data/validation.mdx",
   "packages/spec/src/data/validation.zod.ts"
   ]
   }
8. objectstack-fleet commented on Sep 27, 2026

   

   objectstack-fleetbot

   on Sep 27, 2026

   ContributorAuthor

   More actions

   ACCEPT — PR #20276 at head 08cb6583fe · domain:spec seat 2 (session_01QcAS3qiYYZNezaxZxaUdMV) · 2026-09-27T18:46Z

   Seat review against GitHub, not the report:

   • Shape: base main, Fixes #20252 and a standalone Clause-②: no line. 3 files, +25/−10.
   • Delivered: triage's direction 5857699948, plus the three sites that REWORK round 1 (5858340569) added.
     • Five ObjectStack predicates in packages/spec/src/data/validation.zod.ts are now evaluable CEL rooted at record.: :100, :240, :257, :274, and the .describe() at :294.
     • Example 1 and the describe example are un-inverted, so each condition is TRUE on the violation. That is what checkPredicate enforces (rule-validator.ts:4078).
     • The Salesforce formulas are byte-identical.
     • content/docs/references/data/validation.mdx is regenerated, not hand-edited.
   • At-tier contract review: PASS 73/73, recorded on the PR as 5858687632 at this head.
     • Every predicate was probed as a reader copies it, on a violating record and a valid one.
     • Example 1 was probed across the month, year and timezone boundaries.
     • Clause-②: no and a patch bump are confirmed.
   • CI: no failing check. check-expected-skips is OK (every skip is on the roster).
   • Landing: check-governed-merges says it is NOT governed (+25/−10). The driver-free merge-tree against origin/main is clean. It was flipped to ready with auto-merge in this window.
   • Acceptance notes:
     • The note that the title still reads "the two cross_field …" is stale, because the seat retitled the PR. Dropped as moot.
     • The reviewer's boundary flags stay out of scope, per triage:
       • the parse-only fixtures in validation.test.ts;
       • the Use-Cases bullets at :221-222, which state requirements, not conditions.
       • Dropped: prose, no condition: literal, and the describe now states the direction.
9. objectstack-fleet

   closed this as completedin #20276on Sep 27, 2026
10. objectstack-fleet commented on Sep 27, 2026

    

    objectstack-fleetbot

    on Sep 27, 2026

    ContributorAuthor

    More actions

    Landing record — PR #20276 merged through the merge queue at 2026-09-27T19:08Z as e6b7d8c861 · domain:spec seat 2 (session_01QcAS3qiYYZNezaxZxaUdMV) · 2026-09-27T19:15Z

    • Verified by content on origin/main: e6b7d8c861 is an ancestor. In packages/spec/src/data/validation.zod.ts, all five ObjectStack predicates read as evaluable CEL rooted at record.:
      • :100 record.discount_percent > 0.40
      • :240 date(record.close_date) < addDays(today(), 1 - today().getDate())
      • :257 record.discount > (record.amount * 0.40)
      • :274 isBlank(record.products) && record.stage == "closed_won"
      • :294, the describe: "If TRUE, validation fails — the condition describes the violation."
    • Card: closed completed by Fixes #20252. pm:dispatched is stripped in this act; bug, documentation, domain:spec, priority:p3 and area:records stay.
    • Review chain:
      • REWORK round 1 5858340569: the seat widened the scope to three more sites in the file.
      • At-tier PASS 73/73 on the PR at 08cb6583fe, the landed head.
      • ACCEPT 5858699016.
    • Closing-keyword audit: the body and the squash message name #20252 only, and nothing else closed in the window.
    • Unblocked: none. No open pm:blocked card carries Blocked-by: #20252.
11. objectstack-fleet

    removed

    pm:dispatched

    on Sep 27, 2026
12. akarma-synetal

    added a commit that references this issue on Sep 28, 2026

    fix(spec): rewrite the cross_field and script examples in validation.…

    ...

    e6b7d8c