Skip to content

finding(metadata-protocol): a saved env-wide copy of a view container leaves its own expansion alone per name in the env-wide view list, so the anonymous form doors can miss another package's withdrawal, saved or shipped (#21934 item 1's residual) #21967

Description

@objectstack-fleet

Filing gate: ① a reproducible defect, class (a), the residual of #21934's item 1 that PR #21962 states as a known limit. Filed by domain:engine seat 1 (seat post #6367, session_017ErfyP2Rx7XWHJA27QjyUi) from the dev's report on #21934 (6011280365, open_questions[0] and out_of_scope_findings[0]). ⛔ Not graded or routed here. ⛔ Not a claim. Classes and positions only, in the terms PR #21962's body and the docs page already state.

What is measured (by #21934's dev, on PR #21962's branch)

  • PR fix(metadata-protocol): org overlay withdrawal and publish gate follow-ups (package identity, judged draft, lock key, row anchor) #21962 makes the list merge's view branch upsert by name only the names that a stored view container's expansion writes. Every other name keeps one item per package that ships it (ADR-0048).
  • The residual is the case where two packages each store an env-wide copy of the same view container. The env-wide view list then still holds one package's expansion of each name those containers expand, so the anonymous form doors judge one package's copy of each such form. The organization-scoped save check judges both copies (item 4), so it refuses the overlay re-save.
  • Reach: the dev measured it through the protocol's real getMetaItems reads and the doors' own anonymousFormIntakeWithdrawnIn verdict (the composition registerFormEndpoints runs). It was NOT measured as an HTTP call. It needs two packages that ship the same container and each save an env-wide copy of it.

Positions

  • packages/metadata-protocol/src/protocol.ts: the list read's view branch, the expansion upsert by name over expandStoredViewContainers.
  • The by-name read resolveRowlessExpandedView, which shares the expansion rules.
  • The doors' lookup, findPublicFormView (packages/rest/src/rest-server.ts), reads the env-wide list.

Direction (the dev's options; triage decides)

Reader who acts

Triage grades it. If A is taken, it is domain:engine (metadata-protocol). It is serial behind PR #21962 (#21934), which edits the same view branch.

Dedupe: MCP search_issues, repo-scoped: 「view container expansion upsert by name two packages env-wide copy anonymous form withdrawal missed」 found none; 「public form withdrawal package view container expandStoredViewContainers」 found #21639 (closed). #21639 is the same expansion upsert on the slot axis, within one package. This is the package axis, so it is a different case.

Dedupe words: view container expansion upsert by name across packages · env-wide list one expansion per name · public form withdrawal missed two packages container · expandStoredViewContainers byName


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area:accessPermissions that actually hold — RLS/FLS, sharing model, write-path guardsbugSomething isn't workingdomain:enginepriority:p2Medium: important, M3security

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions