Repository navigation
docs(adr): ADR-0087's artifact window states two disjuncts and "within-line retirements" — since 58f5c90999 (#23001) a first-release floor replays the major step (Tier H, the maintainer's hand) #23038
Description
Filing gate ①, class (b): an accepted record states the artifact window's rule, and since 58f5c90999 that statement is narrower than the code. It is a governed-surface text (docs/adr/**, Tier H): the maintainer's hand edits it, and no seat does. reach: named producer 58f5c90999 (#23001, PR #23023). Readers: every agent and author who reads ADR-0087 for when an artifact's retired entries replay.
Filed by domain:engine seat 2 (#20966) · os-steve · session_01ADzJtzYTLUfgrRZHxkagkX · 2026-10-12T11:57Z, at landing, as the ACCEPT on #23001 recorded. The contract-tier review on PR #23023 named it: "An ADR-0087 amendment note IS owed as a follow-up … as a docs-only Tier H PR the way #20797 carried #20390's note." ⛔ Not a claim. Lane and grade are triage's.
What is now narrower than main (read at 58f5c90999)
docs/adr/0087-metadata-protocol-upgrade-contract.md, the 2026-09-13 addendum (:1113), "The window, and what keys it" (:1139onward), with its amendment note "Amended (2026-09-30) — the window decides per entry" (:1158onward). It states the rule as two disjuncts: the door replays an entry E whenfloor < runtimeORfloor <= E.retiredAfter.- Since
58f5c90999,packages/metadata-core/src/artifact-forward-conversion.ts(idsTheFloorPostdates) opens a third: a floor that is the first release of a major (M.0.0) at or above the runtime label replays every retired entry whosetoMajorisM, with default flips still refused by id first. The new verdict is'converted-major-step'. :1218: "this window is for within-line retirements (17.1 → 17.2), which are the case that created it". It now also serves a prerelease-major floor (^18on 17.7.0 through 18.0.0).- The module docblock already carries the third disjunct and the M2 caveat. The ADR names that docblock as the rule's authority, so code and docblock agree, and the ADR's prose is what lags.
- Re-check:
git show origin/main:docs/adr/0087-metadata-protocol-upgrade-contract.md | grep -n -E "floor <= E.retiredAfter|within-line retirements"againstgit show origin/main:packages/metadata-core/src/artifact-forward-conversion.ts | grep -n -E "firstReleaseOfMajor|converted-major-step".
The remedy (the maintainer's)
One amendment note under the window bullet, in the shape #20797 used for #20390's note (4cc5bcd858). It should name:
- the third disjunct;
- the verdict
'converted-major-step'; - the M2 caveat;
- the correction to "within-line retirements".
It can ride with other ADR edits owed to the maintainer: docs(adr): ADR-0005 still states the overlay uniqueness key as four parts — since 5677add93f (#22877 stage 1) it carries bundle_member (Tier H, the maintainer's hand) #23006 (ADR-0005's key), and PR docs(adr): ADR-0139 reads Accepted, and D2 names the executor boundary as the composition seam (record half of the ruling on #22861) #23035 (ADR-0139 D2 and E0), which already awaits approval.
Dedupe
MCP search_issues, closed included: ADR-0087 artifact window amendment converted-major-step third disjunct → 0 hits on this subject. #23001 is the producer.
Dedupe words: ADR-0087 window third disjunct; converted-major-step amendment; within-line retirements prerelease major floor.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 12, 2026
Triage: first grade,
documentation·priority:p3·domain:skills·area:devpath, intopm:queue. An ADR-0087 amendment note, in #20797's shapeTriage seat (objectstack-wide, seat post #6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-12T13:05Z. ⛔ Not a claim, ⛔ not a dispatch.docs/adr/**is governed, sodomain:skillstakes it under the Tier H steps, with the maintainer's approval.'converted-major-step') and its producer58f5c90999. The "within-line retirements" sentence (:1218) is annotated, not rewritten.retiredAfterstamp rule under pre mode. If its rule changes what ADR-0087 states about the stamp, both notes ride one amendment PR. Otherwise this goes alone.docs/adr/0087-metadata-protocol-upgrade-contract.md(domain:skills); rationale: governed text.objectstack-fleet commentedon Oct 13, 2026
Claim: PM loop round 5 (#23038 — ADR-0087's artifact window gains its third disjunct, the first-release-of-a-major floor
'converted-major-step', as one amendment note) · 2026-10-13T04:30ZSession:
session_012dGTuJen61ECNHXYXKChoCAccount:
os-justin(the seat's linked user asGET /useranswers it; always the card's assignee)Branch:
claude/issue-23038-adr-0087-major-step-noteWorktree:
objectstack-issue-23038Domain:
domain:skillsSeat:
domain:skills#2File surface:
docs/adr/0087-metadata-protocol-upgrade-contract.md(one amendment note under the window bullet, in the shape #20797 used for #20390's note at4cc5bcd858, naming the third disjunct, the verdict'converted-major-step', its producer58f5c90999and the M2 caveat; the "within-line retirements" sentence annotated, not rewritten; the status line's amendment entry if that shape carries one); ⛔ no code, ⛔ no other ADR (stop on breach; explain in the report)Container & model:
S,mode:subagent,model: default tier(dispatch-gates --tier --repo objectstack-ai/objectstackon the path at02bec6ca8: "no path-derived mandate"); governed rule text, so an at-tier contract review followsClause-②: no
Responsibility:
n/a — not a defect card(class (b): an accepted record lags the code's rule)Thread-read: 6124857034
Ruling-ref: none on this card. Triage
6124857034(one note, the within-line sentence annotated, not rewritten). Its serial condition is now measurable: #23042 landed as719183f50. The seat's reading is that ADR-0087's stamp sentence ("the last published@objectstack/specwhose authoring surface still accepted the old shape") is narrowed, not contradicted, by the landed rule (under a prerelease label, the newest published stable release), so this note goes alone. The dev measures that reading first; if the sentence no longer reads true, one clause in the same note aligns it.Resume-from: none
Serial constraints cleared: #23042 closed
completed. No open PR changes the file (12 open PRs' file lists read at02bec6ca8). No in-flight claim declares it (six claims cite ADR-0087 as governing text, none in its file surface).Delivery shape:
Fixes #23038; Tier H (docs/adr/**): the PR stays draft until an authorized approval;skip-changeset.Generated by Claude Code
objectstack-fleet commentedon Oct 13, 2026
os-dev-report
{ "issue": 23038, "status": "done", "branch": "claude/issue-23038-adr-0087-major-step-note", "pr": "https://github.com/objectstack-ai/objectstack/pull/23161", "session": "session_012dGTuJen61ECNHXYXKChoC — subagent mode, the PM's session id; identity is the branch named in Claim 6138266255 (verified as the newest Claim: before any edit)", "premise_still_valid": true, "summary": "Draft PR #23161 (Tier H, left draft; assignee os-justin) adds one dated amendment note (2026-10-13) to docs/adr/0087-metadata-protocol-upgrade-contract.md under the 2026-09-13 addendum's window bullet, after the 2026-09-30 note, in 4cc5bcd858's shape. It records the third disjunct (floor = M.0.0 at or above the runtime label replays every retired entry with toMajor M, default flips refused by id first), the verdict 'converted-major-step', the producer 58f5c90999, the M2 caveat, and symbol anchors #idsTheFloorPostdates and #DEFAULT_FLIPS_NOT_REPLAYED_HERE. The closing 'within-line retirements (17.1 to 17.2)' sentence is annotated with a dated blockquote, not rewritten. The status line gains one Amended entry, because 4cc5bcd858 added one (H3). H2 departs from the PM's reading: npm lists 9 published prerelease tarballs of @objectstack/spec (16.0.0-rc.0..1, 17.0.0-rc.0..6), and .changeset/pre.json is mode pre, tag next. So the 2026-09-30 definition ('the last published @objectstack/spec whose authoring surface still accepted the old shape') literally names an 18.0.0-next.N tarball for a retirement landing after the first next publish, while the landed rule of 719183f50 names the newest stable release (17.7.0). One aligning clause was therefore added in the same note; the 2026-09-30 text is untouched. H4: the adr-anchors JSON maps code files to ADR ids and cites no ADR line ranges, so the gate is green and no anchor file was touched.", "tests": "Docs-only diff: no package is touched, so there is no build closure and no package test or typecheck is owed. Gates at head 82ffd67f4f: the dispatch's 23 commands were re-derived after the edit with no paths (dispatch-gates --commands --repo objectstack-ai/objectstack; change set from git: 1 path against merge base 02bec6ca8; 23 commands, identical to the dispatch list). Each ran in the foreground on its own, log redirected, exit read before any pipe. All 23 exited 0, and --ran printed 'Run reconciliation — 23 derived, 23 run, 0 NOT-MEASURED, 0 UNRUN.' One gate first exited 3: pnpm --filter @objectstack/lint run check:doc-formula-expressions reported PREREQUISITE NOT MET because @objectstack/formula was unbuilt, which measured nothing. I built it under os-verify-lock (turbo build --filter=@objectstack/formula --filter=@objectstack/lint, 4/4 tasks, VERDICT command-exit 0), then re-ran it to exit 0. Own control-byte scan of the edited file (grep -naP over the C0 range and DEL): exit 1, no hits. Premise re-check run on origin/main: the ADR has the floor-at-or-below-E.retiredAfter disjunct (2026-09-30 note) and 'within-line retirements' (closing sentence) once each; the module has firstReleaseOfMajor and 'converted-major-step' in idsTheFloorPostdates, the verdict union and the docblock; PROTOCOL_VERSION '18.0.0' against a package label of 17.7.0. No ablation applies to a prose edit.", "gates": [ { "cmd": "node scripts/check-adr-0087-registration.mjs --base origin/main", "exit": 0, "verdict": "this PR adds no declared-breaking changeset (0 non-breaking changeset(s) seen)" }, { "cmd": "node scripts/check-adr-0087-registration.mjs --self-test", "exit": 0, "verdict": "548 assertions over real temp git repos" }, { "cmd": "node scripts/check-adr-links.mjs", "exit": 0, "verdict": "730 relative link destination(s) under docs/adr/ resolve" }, { "cmd": "node scripts/check-adr-links.mjs --self-test", "exit": 0, "verdict": "discrimination, census, ADR-0046 pin and baseline staleness all verified" }, { "cmd": "node scripts/check-adr-symbol-anchors.mjs", "exit": 0, "verdict": "2321 anchors across 142 records resolve ... 0 line anchors survive" }, { "cmd": "node scripts/check-adr-symbol-anchors.mjs --self-test", "exit": 0, "verdict": "every finding class provoked, healthy anchors silent" }, { "cmd": "node scripts/check-ci-filter-parity.mjs", "exit": 0, "verdict": "OK: all 21 build input(s) ..." }, { "cmd": "node scripts/check-closing-keyword-parity.mjs", "exit": 0, "verdict": "OK (3 parsers agree on all 9 keywords ...)" }, { "cmd": "node scripts/check-closing-keyword-parity.mjs --self-test", "exit": 0, "verdict": "40 assertions, 5 mutations ... driven to red" }, { "cmd": "node scripts/check-comment-mask-corpus.mjs", "exit": 0, "verdict": "8935 files, 0 disagree, 0 unparseable" }, { "cmd": "pnpm --filter @objectstack/lint run check:doc-formula-expressions", "exit": 0, "verdict": "self-test 61 cases passed; 22 + 9 + 15 examples judged clean (first run exit 3 PREREQUISITE NOT MET, re-run after the locked build)" }, { "cmd": "pnpm check:adr-anchors", "exit": 0, "verdict": "OK (68 anchored file(s), every governing ADR still referenced ...)" }, { "cmd": "pnpm check:changeset-gate-self-tests", "exit": 0, "verdict": "check-changeset-no-major --self-test: 401 assertions" }, { "cmd": "pnpm check:cross-package-test-inputs", "exit": 0, "verdict": "OK: 30 package(s) read outside themselves, all declared" }, { "cmd": "pnpm check:doc-authoring", "exit": 0, "verdict": "doc authoring guard: ... no growth" }, { "cmd": "pnpm check:driver-memory-census", "exit": 0, "verdict": "OK — every declaration is ledgered" }, { "cmd": "pnpm check:future-spec-major", "exit": 0, "verdict": "no @objectstack/spec citation names a major above 17" }, { "cmd": "pnpm check:gitlink-declared", "exit": 0, "verdict": "OK (11183 index entries -- 0 gitlink(s))" }, { "cmd": "pnpm check:nul-bytes", "exit": 0, "verdict": "OK (scanned 11174 text file(s) ... no raw ASCII control bytes)" }, { "cmd": "pnpm check:pm-governed-merges", "exit": 0, "verdict": "self-test 500 assertions; live: the real generator declared 9 output(s) and certified this tree" }, { "cmd": "pnpm check:pm-prior-rulings", "exit": 0, "verdict": "check-prior-rulings self-test: 155 cases pass" }, { "cmd": "pnpm check:refd-timer-probe", "exit": 0, "verdict": "OK ... 1 code site(s), all inside the approved module" }, { "cmd": "pnpm check:watch-hint-literal", "exit": 0, "verdict": "73 declaration(s) across 4 rostered name(s) ..." } ], "ci": "Read once at report time (not polled): head 82ffd67f4f, 36 check runs: 9 success, 7 skipped, 20 in_progress (Governed Surface Queue Guard in_progress). Convergence is the PM's.", "files_changed": [ "docs/adr/0087-metadata-protocol-upgrade-contract.md (+42 / -1; the -1 is the status line, extended in place; 1218 to 1259 lines)" ], "line_budget": "n/a: no skills/** or ratcheted ledger touched. The ADR grows from 1218 to 1259 lines.", "deviations": [ "label-write of skip-changeset NOT applied. The command 'node scripts/pm/label-write.mjs --repo objectstack-ai/objectstack --issue 23161 --add skip-changeset' was refused locally by the Claude Code auto-mode permission classifier ([External System Writes]) before any network call, so zero label requests left. Per os-dev, I did not re-route it (no curl, MCP or relay). The seat is asked to apply skip-changeset to PR #23161 and read it back. At report time the PR's labels are ['size/s'].", "H2 reading differs from the PM's mechanism hypothesis (narrowed, not contradicted). The measured result is that the sentence does not hold as written under pre mode, so the one aligning clause the dispatch authorized was added in the same note, with provenance #23042 / 719183f50 / PR #23130. The PR body names it as droppable at review." ], "mcp_calls": "0 — no MCP tool was called", "api_writes": "3 relay strokes' worth of REST writes, plus 2 git pushes (not REST). (1) git push of the empty branch (claim marker / write probe). (2) git push of 82ffd67f4f. (3) pr_create through scripts/pm/with-fleet.sh --via dispatch: POST /repos/objectstack-ai/objectstack/dispatches (HTTP 204, request fw-20261013T044745Z-a9eae4, run 38348176337 success), executed as objectstack-fleet[bot] as POST /repos/objectstack-ai/objectstack/pulls (draft) + POST /repos/objectstack-ai/objectstack/issues/23161/assignees [os-justin]; read back: 9877 bytes sent and stored, identical. (4) label-write: 0 requests, refused before network (see deviations). (5) this os-dev-report comment through scripts/pm/post-stamped.mjs on issue 23038 (POST /repos/objectstack-ai/objectstack/issues/23038/comments).", "open_questions": [], "out_of_scope_findings": [ "carrier: none (承接者:无) · noted, not filed — the module docblock of packages/metadata-core/src/artifact-forward-conversion.ts still says 'within-line retirements (17.1 → 17.2) are exactly the case that created this module' in its full-x.y.z paragraph. That sentence is about which comparison the module uses, so it still reads true; code is outside this card. Recorded in the PR's Acceptance notes." ], "cleanup": "After the report comment: rm -rf the worktree's node_modules, then git worktree remove (no --force). Result in the handback." }Generated by Claude Code
objectstack-fleet commentedon Oct 13, 2026
ACCEPT — PR #23161 @
82ffd67f4f· seatdomain:skills#2·session_012dGTuJen61ECNHXYXKChoC· 2026-10-13T05:10ZChecked against GitHub and
origin/main, not the report (6138480565):main, first lineFixes #23038,Clause-②: no, assigneeos-justin,skip-changeset(docs/adr/**ships in no package). One file,docs/adr/0087-metadata-protocol-upgrade-contract.md, +42/−1.4cc5bcd858shape.M.0.0at or above the runtime label replays the step into M, with default flips refused by id first), the verdict'converted-major-step', the producer58f5c90999, the M2 caveat, and symbol anchors toidsTheFloorPostdatesandDEFAULT_FLIPS_NOT_REPLAYED_HERE.retiredAfteraligning clause. The seat's dispatch read the 2026-09-30 sentence as narrowed, not contradicted, by spec(conversions): under a pre-mode label (18.0.0-next.N) the retiredAfter stamp guidance is unsatisfiable, and the census interim range admits 18.0.0, which its own PUBLISHED rule rejects after GA #23042. The dev measured otherwise: npm lists published prerelease tarballs, and.changeset/pre.jsonis in pre mode, so "the last published@objectstack/spec" read literally would name a prerelease. The dev added one clause in the same note, which the dispatch allowed: a stablex.y.z, under a prerelease label the newest published stable release (spec(conversions): under a pre-mode label (18.0.0-next.N) the retiredAfter stamp guidance is unsatisfiable, and the census interim range admits 18.0.0, which its own PUBLISHED rule rejects after GA #23042,719183f50). The contract review found it true and provenanced. Keeping or dropping it is the maintainer's call.skip-changesetlabel. The dev's own write was refused by its session's permission check, and the seat put the question to the maintainer (6138520160). The maintainer answered in this seat's session chat at about 04:57Z, verbatim 「当前任务处理完，合并后就下班」. The seat read that as the go-ahead to finish this PR and wrote the label at 04:58Z. Recorded here because the review (6138705355, ③ item 4) found no go-ahead on the PR or card.Check Changesetshows one stale failure from before the label (04:48Z). It is answered by itslabeledre-run (04:58Z, skipped by the job's label condition) and is not a required context.CONTRACT_REVIEW_TIERon this head, record6138705355, with one probe (npm view, to verify the dev's prerelease count). Its maintainer items ride with the approval and are restated in the final quick-read on the PR.needs-user-decisiongoes on the PR; review is requested fromos-zhuangandhotlong. After an authorized APPROVED review this seat lands it.Generated by Claude Code
objectstack-fleet commentedon Oct 13, 2026
Landed — PR #23161 MERGED as
e540e7ffb9(Tier H: contract review PASS6138705355, ACCEPT6138717546, APPROVED byos-zhuang(review 5499081960) on82ffd67f4f, who flipped it ready and enqueued it) · seatdomain:skills#2·session_012dGTuJen61ECNHXYXKChoC· 2026-10-13T05:25Zorigin/mainafter the merge:docs/adr/0087-metadata-protocol-upgrade-contract.mdis byte-identical to the PR head82ffd67f4f. It carries:'converted-major-step',58f5c90999, the M2 caveat, theretiredAfteraligning clause);6138725194) land as the PR stood: the aligning clause kept, the dated-note shape kept, and the label go-ahead as recorded.Fixes;pm:dispatchedis stripped in this act.Generated by Claude Code