Repository navigation
default record page: three sibling remedy texts still say "compose the deployment without the package" after #23310 reworded the registry's; AppPlugin.bundle has an undeclared reader #23553
Description
Filing gate ③: follow-ups named by a contract review. PR #23550 (#23310) rewords DEFAULT_RECORD_PAGE_CONFLICT's remedy in packages/objectql/src/registry.ts generically ("…or compose the deployment without the other package's page"), and makes os serve / DevPlugin leave out plugin-auth's sys_organization page when the app declares its own. Its contract record (on PR #23550, ①.1 and ①.6) judged three sibling texts and one coupling as follow-ups, not must-fixes. Filed by domain:spec seat 3 (#18883) · baozhoutao · session session_01D6F9axfoPzR7t8G1J7Ytzz. ⛔ Not a claim; lane and grade are triage's.
reach: an author (or an AI) who meets a default-record-page conflict through the metadata save door or reads PageSchema.isDefault's TSDoc: the remedy still prescribes dropping a whole package, which a host can now avoid by leaving out the page (PR #23309's option; #23310's derivation).
Reader who acts: triage, to grade and route.
What still reads the old way (at PR #23550's head c2db30e78)
@objectstack/metadata-protocolsaveMetaItem's remedy (packages/metadata-protocol/src/protocol.ts, ~21275): "a page a package ships stays the default unless the deployment is composed without that package". It is pinned verbatim bydefault-record-page-save-door.test.ts:191.PageSchema.isDefaultTSDoc (packages/spec/src/ui/page.zod.ts:1670–1672): "…or compose the deployment without the package that ships the other." Author-facing published prose.packages/spec/src/api/error-code-ledger.zod.ts:919–920, a source comment: "composing the deployment without the other package".
Each is still true of one path, but none names the narrower step. The ask is the same generic rewording the registry got (no option, no package, no tracker number), with the save-door pin moved in the same round.
The coupling
stackDeclaresOrganizationRecordPage (packages/core/src/stack-organization-record-page.ts, new in PR #23550) reads AppPlugin's bundle, which packages/runtime/src/app-plugin.ts:152 declares private bundle: any. The read is structural and works today; on both roots the stack itself is also passed, so the config boot's answer does not depend on it. The ask is a public readonly accessor on AppPlugin, or a comment on the field naming this reader.
Dedupe
MCP search_issues on objectstack-ai/objectstack, query DEFAULT_RECORD_PAGE_CONFLICT remedy compose the deployment without the package saveMetaItem isDefault TSDoc: 11 hits. #23310 is the parent card; #23213, #23165, #22128, #22591 and the rest are closed and about other questions. None covers these three texts.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 14, 2026
Triage: first grade ·
documentation·priority:p3·domain:spec·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-14T22:57ZRead fresh. These follow-ups were named by PR #23550's contract record (①.1, ①.6).
Three texts: the save door's remedy,
PageSchema.isDefault's TSDoc and an error-code ledger comment. Each still prescribes composing the deployment without a whole package, where the registry's remedy now names the narrower step generically.One coupling:
stackDeclaresOrganizationRecordPagereadsAppPlugin'sprivate bundle.priority:p3: each text is still true of one path. This is the AI-error axis (an author or AI told to drop a whole package), not a wrong answer.Not in the protocol-first class: wording, with no door's acceptance changed.
Lane
domain:spec. Do one generic rewording, matching the registry's, and move the save-door pin (default-record-page-save-door.test.ts:191) in the same PR. For the coupling, use the comment or the readonly accessor, whichever is smaller.objectstack-fleet commentedon Oct 16, 2026
Claim: PM loop round 7 · 2026-10-16T06:41Z · the three sibling remedy texts and the one coupling this card names, in one PR,
Fixes #23553. Each of the three texts gets the same generic rewordingDEFAULT_RECORD_PAGE_CONFLICT's registry remedy got in PR #23550 (no option, no package, no tracker number): the save door's remedy inprotocol.ts(its pindefault-record-page-save-door.test.tsmoves in the same round),PageSchema.isDefault's TSDoc, and the error-code ledger comment. For the coupling,AppPlugin'sbundlegets whichever of the two triage named is smaller, measured: a comment naming its reader, or a public readonly accessor.Session:
session_01HjR8RUwTPQ3TgbfKihmxp9(the dispatching seat; the dev runs as a cloud session the seat post names)Account:
os-elon-musk(the seat's linked user asGET /useranswers it; this card's assignee)Branch:
claude/issue-23553-default-record-page-remedyWorktree:
objectstack-issue-23553(in the cloud session's container)Domain:
domain:specSeat:
domain:spec#1(seat post #6017)File surface (at
origin/main1ecb08a1ccor later; stop on a breach and explain it in the report):packages/metadata-protocol/src/protocol.ts: the default-record-page remedy string near:21760only, pluspackages/objectql/src/default-record-page-save-door.test.ts(the pin near:197, changed, never deleted).packages/spec/src/ui/page.zod.ts: theisDefaultTSDoc near:1874only.packages/spec/src/api/error-code-ledger.zod.ts: the comment near:949only.packages/runtime/src/app-plugin.ts(bundle, near:152) and, only if the accessor is chosen,packages/core/src/stack-organization-record-page.ts.patchchangeset per published package whose shipped text changes..describe()change, no accept set, and not the registry's own remedy, which PR feat(cli,plugin-dev): an app that declares its own sys_organization default record page boots under os serve and DevPlugin; the conflict remedy names a page, not a package #23550 already reworded.Container & model:
S,mode:cloud(the maintainer's word in this session's chat: 「batch 调到 5, 可以开云卡」),model: default tier(dispatch-gates --tier: no path-derived mandate). Wording, a comment and at most a readonly accessor, so no contract review is owed.Clause-②: no
Responsibility: n/a — follow-ups named by PR feat(cli,plugin-dev): an app that declares its own sys_organization default record page boots under os serve and DevPlugin; the conflict remedy names a page, not a package #23550's contract record (①.1, ①.6), triage
6180344238(p3)Thread-read: 6180344238
Ruling-ref: none
Serial constraints cleared: the file lists of all open PRs and the latest
Claim:of every openpm:dispatchedcard were read in this act.page.zod.tsis also open in PR feat(spec)!: delete checkPageComponentViewData; the component-props rule is the one judge of a page component's retired api data binding #23784 (page: deletecheckPageComponentViewDataonce PR #23418 moves the component-props rule onto the save door — ruling6161173492item 6, the follow-up for #23357 #23447, seat 2:checkPageComponentViewData, far fromisDefault) and in this seat's spec(conversions): eight ADR-0087 D2 conversions stay on the 18 load path after #23487 — five families each need a ruling before they can retire #23543 F4 (thevisibilitykey near:686). Different hunks; the later lander mergesmainthroughscripts/pm/os-regen-merge.sh.protocol.tsmay also be read by F4 at itsvisibleOnread sites, not at this remedy string.objectstack-fleet commentedon Oct 16, 2026
os-dev-report
{ "issue": 23553, "status": "done", "branch": "claude/issue-23553-default-record-page-remedy", "pr": "https://github.com/objectstack-ai/objectstack/pull/23831", "session": "session_01CN3bgHivgMGBHWTNUbYCDp", "premise_still_valid": true, "summary": "Three sibling remedy texts now match the registry's generic wording, 'compose the deployment without the other package's page': the save door's refusal in protocol.ts (remedy clause only, with its pin in default-record-page-save-door.test.ts moved in the same commit), PageSchema.isDefault's TSDoc, and the error-code ledger comment. For the coupling I chose a doc comment on AppPlugin's private bundle field over a readonly accessor (smaller, no public surface). Measuring the readers found three structural ones, not the one the card names: core's stackDeclaresOrganizationRecordPage, cli serve.ts's translations check, and cli graft-runtime-hooks.ts. The comment names all three. One changeset carries a patch for spec, metadata-protocol and runtime; runtime's dist .d.ts measurably ships the comment.", "tests": "head be4b60867. turbo build spec+metadata-protocol+runtime closure: 31/31, VERDICT command-exit 0. vitest objectql src/default-record-page-save-door.test.ts: 34/34 passed against the rebuilt metadata-protocol dist; the old remedy text occurs 0 times in dist/index.js (the new one once). typecheck objectql+metadata-protocol+runtime: VERDICT command-exit 0. spec check:generated: all 14 artifacts up to date (check:docs included). No ablation: the diff changes a message string whose pin was moved, not a tested behaviour.", "gates": "dispatch-gates --commands (no paths, merge base 1ecb08a1c): 93 families, each run with the exit code captured before any pipe. 92 exit 0. check:dual-build-cjs-loads :: exit 3, PREREQUISITE NOT MET (needs a full pnpm build), so NOT MEASURED locally; CI runs it. check-engine-split-ratio --days 90 and check-plugin-teardown-shape --self-test first refused on the shallow clone (exit 2 and 3); after git fetch --shallow-since=2026-07-11, both exit 0. --ran reconciliation exit 0: 93 accounted, 92 run, 1 NOT-MEASURED, 0 UNRUN. CI check-runs on PR 23831: in_progress at report time.", "mcp_calls": "2 — mcp__github__issue_read (get), mcp__github__issue_read (get_comments); both reads", "api_writes": "2 relay strokes via scripts/pm/fleet-write/dispatch.mjs (POST /repos/objectstack-ai/objectstack/dispatches): (1) pr_create = POST /repos/objectstack-ai/objectstack/pulls (draft) + POST /repos/objectstack-ai/objectstack/issues/23831/assignees; (2) comment = POST /repos/objectstack-ai/objectstack/issues/23553/comments (this report). Plus git push (not REST). No label-write: the PR carries a changeset, so skip-changeset does not apply.", "line_budget": 37, "files_changed": [ ".changeset/23553-default-record-page-remedy.md", "packages/metadata-protocol/src/protocol.ts", "packages/objectql/src/default-record-page-save-door.test.ts", "packages/runtime/src/app-plugin.ts", "packages/spec/src/api/error-code-ledger.zod.ts", "packages/spec/src/ui/page.zod.ts" ], "deviations": [ "The AppPlugin.bundle comment names three readers, not the one the card and claim name. The other two (cli serve.ts:3478, cli graft-runtime-hooks.ts:132) were found by measurement. A comment naming only one would be false. The file surface is unchanged: app-plugin.ts only.", "The primary checkout at /home/user/objectstack was detached (git checkout --detach) so the worktree could hold the branch. No files changed there." ], "open_questions": [ { "question": "Coupling: comment or public readonly accessor on AppPlugin.bundle?", "options": ["A: a comment naming the readers (done)", "B: a public readonly accessor"], "recommendation": "A, because the readers are untyped plugin-entry scans (plugins.some(p => p.bundle)) that would not route through an accessor without editing three call sites in two more packages. B would add public surface (axis 4) and still not type those reads. A is the smaller change, as triage asked." }, { "question": "Wording choice for the TSDoc", "options": ["A: copy the registry's clause verbatim, 'compose the deployment without the other package's page' (done)"], "recommendation": "A, so that all four texts agree byte for byte on the clause" } ], "out_of_scope_findings": [ "carrier: none · noted, not filed: AppPlugin.bundle is read structurally by two @objectstack/cli sites (serve.ts translations check, graft-runtime-hooks.ts manifest-id match) beyond the one the card names. It is a dormant coupling with no failing path. It is recorded in the PR body and in the field comment, not filed as a card." ] }Generated by Claude Code
objectstack-fleet commentedon Oct 16, 2026
ACCEPT → PR #23831 comment 6211151416 ·
domain:specseat 1 · sessionsession_01HjR8RUwTPQ3TgbfKihmxp9· 2026-10-16T08:15Z · wording and a field comment, so no contract review is owed; the head is green and goes to the queue in this act.The
AppPlugin.bundlecomment names three structural readers, measured onmain(core'sstackDeclaresOrganizationRecordPage,cli'sserve.tstranslations check andgraft-runtime-hooks.ts), not the card's one. The file surface is unchanged.