Activity

1. huangyiirene

   added

   bugSomething isn't workingSomething isn't working

   finding

   on Aug 11, 2026
2. hotlong

   added

   pm:queue

   domain:engine-core

   and removed

   finding

   on Aug 12, 2026
3. hotlong commented on Aug 12, 2026

   

   hotlong

   on Aug 12, 2026 – with Claude

   Contributor

   More actions

   Triage: promoted finding → pm:queue + domain:engine-core (gate lands in packages/objectql — ObjectRepository/ObjectQL.update by-id branch). Deterministic three-witness reproduction, two sibling paths already gate correctly (#4435 protocol, #5138 callData), so this is bringing the third path onto an established invariant — queue, not a decision.

   Two constraints carried into dispatch, from the card's own (excellent) scope notes:

   1. Placement question is settle-first, not settle-during: engine-level gate vs repository-level gate turns on who else relies on engine.update()'s resolve-null contract — the dev measures the caller set FIRST and picks the placement that changes no other caller's observed behavior; if every placement changes some caller's contract, that's a fork to report, ⛔ not a silent pick. delete gets checked in the same card (callData 的 ObjectQL 兜底路径对「记录不存在」给三种不同答案(get→200 null / update→500 / delete→200 deleted:true) #5138's own comment names it as historically worst).
   2. Serial constraint with [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571: this card is [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571's corrected successor, and [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571 is currently pm:dispatched in this same lane. Before dispatch, the engine-core seat must read [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571's claim/branch state — if its dev is mid-flight on the old (wrong) attribution, redirect or land one card and close the other as superseded; two devs on this surface is the isSystem 写入仍可产生悬空 lookup 引用——需要一条只报告不拦截的巡检（#4441 残留） #4551 shape. ⛔ The previous-binding behavior is ruled-correct (ADR-0058 Addendum II) and must not be touched.

   Plus the card's own assertion requirement: the dogfood fixture that currently passes 23/23 while logging the error gets an assertion so this class cannot travel green again.

   Size/model suggestion: M, mode:cloud, model: opus (contract-measurement step before code).

   ---

   Generated by Claude Code
4. huangyiirene

   added

   pm:dispatched

   and removed

   pm:queue

   on Aug 12, 2026
5. huangyiirene

   self-assigned this

   on Aug 12, 2026
6. huangyiirene commented on Aug 12, 2026

   

   huangyiirene

   on Aug 12, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Claim: PM loop (engine-core seat #6019, 2026-08-12 shift)
   Session: session_01VGAePF7iGGUYUT8oX1cVgx
   Branch: claude/issue-7867-action-body-notfound-gate
   Worktree: objectstack-issue-7867 (mode:cloud — own clone)
   Domain: domain:engine-core
   Labels: pm:queue → pm:dispatched (atomic, with the assignee, in one write)
   File surface: packages/objectql/src/engine.ts (ObjectRepository.update/.delete and/or ObjectQL.update()'s by-id branch — placement is the card's settle-first question, see below) + a new pin under packages/objectql + an assertion on the dogfood fixture + changeset
   Container & model: M, mode:cloud, model: opus — matching the triage seat's own sizing; the contract measurement before the code is judgment work, not mechanical

   Serial constraints cleared — including the one triage named

   The engine.ts hot-file queue is empty. Its three serial holders this shift have all landed: #7738 (PR #7833), #7642 (PR #7868), #7707 (PR #7883). Verified against the repo's open PR set just now, not from this seat's ledger: 6 PRs are open repo-wide (#7782, #7813, #7892, #7879, #7851, #6208) and none of them touches packages/objectql. This card takes the file.

   Triage's constraint 2 — #5571 — is satisfied, and here is the evidence rather than an assurance. #5571 is still labelled pm:dispatched, so on the labels alone this would read as a live claim on the same surface. It is not. Its dev finished on 2026-08-11 and delivered a step-1 reproduction only, by design: its own report states "No files landed. Both probes were written, run, and deleted; worktree is clean and the branch carries no commits," and "packages/objectql/src/engine.ts was read only." There is no branch, no PR, and nothing to collide with — the residual pm:dispatched is a label this seat owes an update on, not a dev in flight. This card is that dev's deliverable, so the "#4551 shape" triage was guarding against is structurally impossible here: the two cards are sequential halves of one investigation, not two devs on one surface.

   The dispatch also carries triage's own instruction on the other half: land this card, and #5571 closes as superseded (this seat's recommendation of 2026-08-11T22:23Z stands; ⛔ the closure grade is the triage seat's call, not this seat's).

   ⛔ Settle the placement BEFORE writing the fix — it is a fork to report, not a pick to make

   The card names this precisely and the dispatch inherits it as a stop condition. Measure the caller set of engine.update()'s resolve-null-on-missing-row contract first, then choose:

   • if exactly one placement leaves every other caller's observed behaviour unchanged, take it and show the caller enumeration that proves it;
   • if every placement changes some caller's contract, that is a needs_decision fork — report it with the caller list and the cost of each side, ⛔ do not pick silently and ⛔ do not widen into a fourth bespoke 404 site.

   ObjectRepository.delete is in scope in the same card, per #5138's own record that delete was the worst of the three.

   ⛔ Inherited invariants — do not touch

   • if (priorRecord) hookContext.previous = … is correct (ADR-0058 Addendum II / Script validation rules are silently skipped when their predicate fails to evaluate — fail-open is the wrong direction for a validation #4649, never fabricate). [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571 carried the opposite attribution for six triage rounds and the reproduction measured it wrong. The binding is not the defect and must not be loosened.
   • ⛔ Not "extend [17.x] 批量写按行语义实现:hook 按行触发 + record-change trigger 按行绑定 previous/record(#4800/#4862 拍板 A) #5038's specialization" — beforeUpdate hook 在 multi:true 批量更新上拿不到 ctx.previous —— sys_fetch_previous_update 依赖 input.id;引擎已为校验取 priorRows 却不喂 hook(17.0.0-rc.2) #5574 retired that diagnostic by fixing the producer; the not.toMatch pins it cited no longer exist. The producer here is the missing existence gate.
   • The HookConditionError bypass of onError/async is the settled hook 的 condition 求不出值时:全局 fail loud —— 抛错并中断该次操作(方案 B 已拍板;Blocked-by #4770) #4775 ruling — out of scope.
   • Locate every site by symbol. [观察,机制未确认] 对不存在的记录 id 走 action body 更新时,afterUpdate hook 的 condition 读 previous 报 400 HookConditionError,而非干净的 not-found #5571 burned five successive anchor corrections; treat every line number on either card as drift-prone.

   The assertion is part of the deliverable, not a nicety

   packages/qa/dogfood/test/showcase-anonymous-deny-surfaces.dogfood.test.ts currently passes 23/23 while logging this exact error through a required 3-shard gate. A fix that lands without an assertion leaves the next instance of this class free to travel green the same way.

   ---

   Generated by Claude Code
7. huangyiirene commented on Aug 12, 2026

   

   huangyiirene

   on Aug 12, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Dispatched mode:cloud: session session_01LRQ39odXrHFtxM777obo8t (created 2026-08-12T08:03Z, model: claude-opus-5, outcome branch = the claim branch). Report expected as an <!-- os-dev-report --> comment here at draft-PR time.

   The two stop conditions were written into the brief verbatim, not paraphrased: the placement fork halts implementation and comes back as needs_decision with the caller enumeration if every placement changes some caller's contract, and the previous-binding invariant is marked do-not-touch with its provenance (ADR-0058 Addendum II / #4649) so the dev cannot rediscover #5571's refuted attribution from the symptom.

   ---

   Generated by Claude Code
8. huangyiirene

   added a commit that references this issue on Aug 12, 2026

   test(plugin-audit): the #5860 SKIP_OBJECTS pin measures the read, not…

   ...

   c6354ad
9. huangyiirene commented on Aug 12, 2026

   

   huangyiirene

   on Aug 12, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Landed as a draft PR. premise_still_valid: true — measured, not read.

   Branch claude/issue-7867-action-body-notfound-gate, dedicated worktree, session session_01LRQ39odXrHFtxM777obo8t.

   Re-measured before touching anything (not inherited from #5571's report). On a live bootStack(showcaseStack), authenticated, one id, one object, one process:

   POST  /actions/showcase_task/showcase_mark_done/<ghost>
     BEFORE 400 {"code":"VALIDATION_ERROR","message":"HookConditionError: … reads 'previous', which is not bound …"}
     AFTER  404 {"code":"RECORD_NOT_FOUND","message":"Record <ghost> not found in showcase_task","httpStatus":404}
   PATCH /data/showcase_task/<ghost>
     BEFORE 404   AFTER 404   (unchanged — this path already gated)
   

   And the CI witness the card cites reproduces verbatim when the fix is reverted — hook-wrappers.ts:642 → triggerHooks → engine.ts, plus [BodyRunner] sandboxed action threw.

   ---

   1. Step 1 — the caller enumeration, and the placement

   The contract, stated precisely

   engine.update()'s by-id branch resolved rather than threw when the row was absent. It never meant "null ⇒ not found": protocol.updateData's own note records that the post-write readback is also null when the write moves the row out of the caller's row scope. So the contract at issue is resolve-instead-of-throw, and nothing else.

   Caller set, by symbol (git grep, not memory)

   git grep -nE "\b(ql|engine|dataEngine|objectql)\??\.\s*update\(" -- 'packages/**/src/**' 'apps/**' 'examples/**' → ~130 non-test call sites across 51 files. Classified by shape:

   class	shape	what it observes on a missing row today	changed by an engine-level gate?
   1 — read-then-write (the overwhelming majority)	find/findOne → update({id: row.id}) — settings-service.upsertRow, suspended-run-store, metadata-store.updateFile, seed-loader, every plugin-security tryUpdate, the pinyin/summary/BU backfills, cascadeDeleteRelations	cannot reach a missing row except under a concurrent-delete race	no
   2 — already gated upstream	protocol.updateData (#4435), callData's ObjectQL fallback (#5138)	404 already — they probe before calling the engine	no (engine gate never fires; they throw first)
   3 — already catching	plugin-security's tryUpdate (catch { return false }), auth-manager's .catch(() => undefined) on sys_session	swallowed	no observable change
   4 — id arrives from the wire, unprobed	rest-server.ts's /data/batch (op.id ?? data?.id, update and delete arms); examples/app-showcase's recalc-endpoint (body.id ?? body.recordId)	reported SUCCESS for a write that touched nothing — the batch pushed null into its results array and answered 200; the showcase endpoint answered 200 {"success":true,"data":{id,estimate_hours}}	yes — and this is the defect, one layer up

   Class 4 is the only class that changes, and both members were exhibiting the same defect the card is about. Neither relies on the silent no-op in the sense of needing it — both were reporting success for a row that was never there, which is exactly the shape #4435/#5138 removed from their own paths. After the gate: the batch route's write throws inside its transaction, so the batch rolls back and fails instead of reporting a partial success — and rest-server.ts's error mapper routes it to a clean 404 RECORD_NOT_FOUND (it matches on error.code === 'RECORD_NOT_FOUND' and on the Record <id> not found in <object> message shape, both of which this error carries). ⚠️ That last hop is read from the mapper, not measured end-to-end — packages/rest's suite passing is what I have, and no test pinned the old silent-success. The showcase endpoint's own catch maps every throw to 500, so it now answers 500 with the true message instead of 200 with a false one; that endpoint's error mapping is its own concern and I did not change it (observation §6).

   ⚠️ Correction to my own first pass: I initially classified class 4 as empty from the read-then-write shape of the ~130 grep hits. Re-reading the two wire-fed sites is what found them. No caller was found that depends on the quiet resolve.

   options.upsert is accepted by ENGINE_UPDATE_OPTION_KEYS but the engine never reads it and no production caller passes it (declared-but-unenforced — observation §6, not fixed here).

   The two placements, and what each changes

   • ObjectRepository — caller set is ScopedContext.object(): hook ctx.api (buildHookApi, 5 dispatch sites) and action-body ctx.api (buildActionApi → createContext). It closes one of the three action-body write faces. The other two — buildEngineRepoFacade (the no-createContext fallback in body-runner.ts) and buildActionEngineFacade's ctx.engine.update(), which examples/app-todo's action handlers actually use — call ql.update(…) directly and keep the defect. It also makes ql.update(o,{id}) and ctx.api.object(o).update({id}) answer one ghost id two different ways.
   • ObjectQL.update()/delete() by-id branch — the one point all three faces funnel through.

   Verdict: the engine — and here is why this is a report, not a silent pick. Neither placement leaves literally everything unchanged, so I am giving you both sides rather than asserting one:

   • Engine (chosen). Changes exactly two callers' observed behaviour (class 4), and in both the old behaviour was a false success — the very defect. Costs the update() 的前置行门是全局的(hooks.get('afterUpdate').length > 0),任一对象注册 afterUpdate 就让所有对象的单 id update 多付一次读 #5284/delete() 的按对象前置行门在任何 kernel 托管引擎上恒真 —— ObjectQLPlugin 自带的 sys_fetch_previous_delete 以 object: '*' 注册在 beforeDelete #5929/plugin-audit 的 5 个 hook 全部无 object 注册 ⇒ 引擎「按对象」需求门(#5284 单 id / #5038 批量)在 audit 启用时恒真 #5860 read-narrowing (§3). Closes all three action-body faces and keeps one answer for one question.
   • ObjectRepository (rejected). Keeps all three narrowings green and leaves class 4 untouched — but closes one of three faces, leaves ctx.engine.update() (which examples/app-todo uses) and the repo-facade fallback with the original defect, and makes ql.update(o,{id}) and ctx.api.object(o).update({id}) disagree about one ghost id.

   I did not treat this as a needs_decision halt because the fork the card described — "a resolve-null-on-missing-row contract that other callers may rely on" — did not materialise: no caller relies on it; two callers were merely lying because of it. The genuine cost is the read-count one in §3, which is a different question from the one the stop condition was written for, and it is the thing to overrule me on if you disagree.

   ⛔ Not a fourth 404 site: recordNotFoundError moved to @objectstack/core (the lowest package all three producers already depend on) because engine.ts cannot import @objectstack/metadata-protocol — ADR-0076 D2's boundary ratchet (core-boundary.ratchet.test.ts) forbids it in the /core closure. metadata-protocol re-exports it, so every existing importer is byte-identical. Same move engineCanRollBack made, for the same reason. No error code minted — RECORD_NOT_FOUND is already in the ADR-0112 ledger (spec/src/api/errors.zod.ts).

   ObjectRepository.delete was measured the same way and is fixed in the same card.

   2. What changed

   1. packages/objectql/src/engine.ts — a not-found gate in the by-id branches of update() and delete(), throwing recordNotFoundError before triggerHooks('before*'). That ordering is the fix, not a detail of it: no handler is ever dispatched for a record nobody read, which is what removes the reported symptom at its producer.
   2. packages/core/src/utils/record-not-found.ts (new) + metadata-protocol re-export — one envelope, three producers.
   3. packages/runtime/src/sandbox/quickjs-runner.ts — status joins the sandbox error passthrough allowlist. Without it the engine's 404 reached the wire as { code: 'RECORD_NOT_FOUND', httpStatus: 400 }: the right diagnosis at the wrong status. domains/actions.ts already honoured .status first — the number simply never crossed the VM boundary. Finite numbers only; the allowlist's security assertion widened with it (a recordNotFoundError's own object property still does not cross).
   4. Three read-count pins rewritten in place — update() 的前置行门是全局的(hooks.get('afterUpdate').length > 0),任一对象注册 afterUpdate 就让所有对象的单 id update 多付一次读 #5284's and delete() 的按对象前置行门在任何 kernel 托管引擎上恒真 —— ObjectQLPlugin 自带的 sys_fetch_previous_delete 以 object: '*' 注册在 beforeDelete #5929's in packages/objectql, and plugin-audit 的 5 个 hook 全部无 object 注册 ⇒ 引擎「按对象」需求门(#5284 单 id / #5038 批量)在 audit 启用时恒真 #5860's in @objectstack/plugin-audit (found by the full-repo run, not by my grep — see §5). None deleted; each records what changed and why.

   Inherited invariants — untouched, as instructed. if (priorRecord) hookContext.previous = … is kept verbatim (with a comment saying why it stays even though the gate now makes it always-true). Nothing extends #5038's message specialization. HookConditionError's onError bypass (#4775) is not touched.

   3. ⚠️ The cost the PM should weigh: the #5284 / #5929 / #5860 read-narrowing is retired

   A by-id update/delete now reads its prior row unconditionally. #5284, #5929 and #5860 had narrowed that read to "does anything CONSUME the prior row?". (#5860 is plugin-audit's, and I found it only when the full-repo run went red — see §5; my by-symbol grep of packages/objectql could not have.)

   They are mutually exclusive, and I measured it rather than argued it (RV3 below): with the narrowing restored and the gate in place, existing rows 404 — Record 1 not found in doc — because the skip means the engine never looks.

   Measured cost of the retirement: #5929's own prose enumerates the global delete-side registrants (plugin-sharing, service-storage, plugin-auth, plugin-audit — all registering with no object, hence matching every object), so on any kernel loading them the demand was already true for every object and the narrowing skipped nothing there. The read is genuinely new only for a bare @objectstack/objectql/core embedder whose object has no hook, no prior-reading rule and no roll-up — which is buying a 404 it did not have.

   What survives, and is still pinned: all three cards' dispatch halves — the per-object hasHooksFor question, excludeObjects subtraction, and the retirement of sys_fetch_previous_update/_delete (the kernel pin still asserts the builtin is absent, and its read count is 1, not the 2 a reintroduced builtin would cost). None of #5284, #5929, #5860 is an ADR; I grepped docs/adr/** for this surface — ADR-0058 governs the ordering and the never-fabricate rule, both preserved.

   This is the one thing I would overrule myself on if the PM disagrees. The alternative is the repository-level placement, which keeps all three narrowings green and fixes one of three faces.

   4. Reverse verification — predictions written before each run

   Each change reverted alone, on a committed base so reverts are isolated.

   #	reverted	predicted	actual
   RV1	update() gate	the 4 ghost-id update cases + 2 relocated pins go red; delete-side and predicate cases stay green	✅ 7 red, exactly those. Also emitted the card's CI signature verbatim (unevaluableConditionError → triggerHooks → engine.ts). One deviation: the unhooked case resolved null rather than throwing VALIDATION_FAILED on the stub schema — i.e. the more basic form of the defect (RESOLVED: null, the card's own P3 headline). Red where predicted, for a slightly different reason than predicted.
   RV2	delete() gate	the 6 delete-side cases go red; update-side green	✅ exactly 6 red, update-side green
   RV3	unconditional read → #5284 narrowing restored	the 2 read-count pins go red	✅ and more than predicted: 10 red, including false 404s on existing rows (Record 1 not found in doc, and the roll-up recompute's parent update). This is the evidence that the skip and the gate cannot coexist.
   RV4	sandbox status passthrough	dogfood 404 case red at 400; /data case green	✅ expected 400 to be 404
   RV5	update() gate, dogfood level, passthrough left in	dogfood 404 case red at 400, with the HookConditionError back in the log	✅ — and this one I had to redo: my first attempt's git checkout had also reverted the sandbox change, so it was not isolated. Re-run properly against a committed base.
   RV6	host→VM status marshalling	the 3 status-carrying runtime cases red; the two contrast cases green	✅ expected undefined to be 404, and the allowlist case red at ['code','message','name']
   RV7	unconditional read, measured against plugin-audit's #5860 pin	the sys_job_queue read-count case goes red	✅ red — plus a second case (no audit row is written) red with it, because the false-404 breaks the write. ⚠️ First attempt measured nothing: plugin-audit resolves objectql's dist, so the revert needed a rebuild. Redone.

   5. Gates — real output

   Green, seen green:

   gate	result
   pnpm --filter @objectstack/objectql test	189 files / 3347 tests passed
   pnpm --filter @objectstack/runtime test	139 files / 2133 tests passed
   pnpm --filter @objectstack/core test	32 files / 773 tests passed
   pnpm --filter @objectstack/metadata-protocol test	74 files / 1082 tests passed
   pnpm --filter @objectstack/dogfood test	93 passed / 1 skipped files, 596 passed / 3 skipped tests
   pnpm typecheck (repo-wide)	126 tasks successful
   pnpm build (repo-wide)	71 tasks successful
   pnpm check:error-code-casing	✓ 17 self-test cases; no lowercase codes in 3716 files
   pnpm check:nul-bytes	✓ 7281 files scanned
   pnpm check:empty-changeset	✓
   pnpm --filter @objectstack/rest test	93 files / 1524 tests passed
   pnpm --filter @objectstack/plugin-audit test	12 files / 201 tests passed
   pnpm --filter @objectstack/plugin-security test	50 files / 1001 tests passed
   pnpm --filter @objectstack/plugin-sharing test	17 files / 454 tests passed
   pnpm --filter @objectstack/spec test	381 files / 10031 tests passed
   pnpm --filter @objectstack/cli test	113 files / 1247 tests passed
   pnpm check:published-files / check:cross-package-test-inputs / check:engine-double-contract / check:route-envelope / check:durability-log-level	✓ all

   check:generated does not exist as a script and nothing generated moved (no packages/spec/api-surface change — the new export is in @objectstack/core, which carries no surface baseline).

   The repo-wide pnpm test — read this part carefully, it is not a clean green

   I ran it three times and it is flaky on this container under load, so I am giving you the runs rather than a verdict.

   • Run 1 (contaminated — I had a build and a second vitest going alongside it): 22 tasks failed, including objectql. Every one of them re-passed standalone.
   • Run 2 (still contaminated — I edited a runtime test file mid-run): 9 tasks failed. Only ONE produced an actual Test Files … failed line (@objectstack/lint, 3 cases in lazy-deps/runtime-lazy-deps — module-load-timing tests, and my diff does not touch that package; they pass standalone). The other eight, objectql included, were killed mid-file — ELIFECYCLE with no summary, the worker-crash signature.
   • Run 3 (clean, --concurrency=3, nothing else running): objectql 189 files / 3347 tests passed in-run, and lint 71/71. Three tasks failed: plugin-audit — a real one, see below — plus spec and plugin-webhooks, both killed mid-file again and both green standalone (spec 381/10031, plugin-webhooks 5/45).

   ⛔ So I am not reporting pnpm test as green — I did not see it go green. What I did instead: every package that failed to summarise in run 3 was re-run standalone and reported above, and every package my diff can touch is in that list. CI's verdict is yours to call, not mine.

   The one real failure run 3 found, and what I did with it

   @objectstack/plugin-audit › [#5860] a SKIP_OBJECTS object no longer forces the prior-row read › single-id update() on sys_job_queue pays ZERO prior reads → expected 1 to be +0.

   A third read-narrowing pin, outside packages/objectql, that my grep of §3 missed. Same family as #5284/#5929 and rewritten the same way: #5860's actual acceptance criterion — the per-object demand gate judges a SKIP_OBJECTS object unhooked — is unchanged and still asserted directly by the sibling case (hasHooksFor is false for all five events) and by the "no audit row is written" case. The number is now 1, and it still holds down what the file cares about: one read, the engine's — not the two a reintroduced audit-side read would cost.

   RV7 (reverting to the narrowing, after rebuilding objectql's dist — plugin-audit tests resolve the built package, so a src-only revert measures nothing; I caught that on the first attempt): the case flips to red, and a second case goes red with it because the false-404 breaks the write entirely. Same coupling RV3 found.

   6. Found and deliberately NOT fixed — observations, not riders

   1. options.upsert is declared-but-unenforced on engine.update(). It is in ENGINE_UPDATE_OPTION_KEYS and in DataEngineUpdateOptionsSchema, it is not in ENGINE_DRIVER_PASSTHROUGH_KEYS, and ObjectQL.update() never reads it — so a caller passing { upsert: true } gets it silently ignored. No production caller passes it (only spec's own schema tests). PD chore: version packages #10 shape; worth its own enforce-or-remove card.
   2. Engine doubles are looser than the producer about existence. Five recording drivers in packages/objectql answered findOne: () => null while backing update, so a by-id write reached the driver against a row that did not exist. I fixed the five my change surfaced, but check:engine-double-contract only covers the three-way dispatch verdict — existence is not in its slice. Widening that gate is its own card.
   3. ObjectRepository.updateById/deleteById bypass foldEngineOptionAliases' alias handling by constructing { where: { id } } directly — harmless today, noted only because it is the shape a future alias change would miss.
   4. examples/app-showcase's recalc-endpoint maps every throw to 500, so the truthful not-found now surfaces as a 500 rather than the 404 the platform produced. The endpoint is an example specimen for the one-call row-action shape, its catch predates this card, and rewriting an example's error mapping is not this card's scope — but it is the one place where the fix's answer is degraded on the way out. Worth a small follow-up.
   5. plugin-security's fix(security)[P0]: enforce RLS on by-id writes — close member-edits-others'-records hole (#1985) #1994 by-id write pre-image re-read is skipped for isSystem callers, which is why the defect only ever surfaced on the action path (action bodies run elevated). That is the documented posture, not a bug; recorded because it explains why REST callers never saw the 400.

   ---

   PR: #7989 (draft — not marked ready, no auto-merge, not enqueued).

   Recommend closing #5571 as superseded, per its own dev's recommendation.

   ---

   Generated by Claude Code
10. huangyiirene commented on Aug 12, 2026

    

    huangyiirene

    on Aug 12, 2026 – with Claude

    CollaboratorAuthor

    More actions

    PM ruling on the placement — engine placement UPHELD. PR #7989 is not landing yet; one job is red and the run is unfinished.

    Engine-core seat #6019, session_01VGAePF7iGGUYUT8oX1cVgx. You asked to be overruled if I disagreed. I don't — and here is the reasoning, so it is on the record rather than in my head.

    Why not halting was the right call, even though the card named a fork

    The stop condition was written against a specific hazard: "a resolve-null-on-missing-row contract that other callers may rely on." Your enumeration answered that question directly — no caller relies on it. Classes 1–3 cannot observe the change; class 4's two members were lying because of it, reporting success for a write that touched nothing. A fork condition that measures as empty is not a fork, and halting on it would have been ceremony.

    ⭐ And the part that makes the enumeration trustworthy is that you corrected yourself in public: "I initially classified class 4 as empty from the read-then-write shape of the ~130 grep hits. Re-reading the two wire-fed sites is what found them." A clean sweep of 130 sites with no class-4 members is exactly the answer a hurried grep produces, and it would have been the wrong one.

    The real cost, which is mine to weigh — and I take it

    The genuine trade is not the one the card anticipated. It is: a not-found gate that fires before triggerHooks('before*') requires a read, and the #5284/#5929/#5860 narrowing exists to make that read zero. RV3 settles that they cannot coexist — with the narrowing restored and the gate in place, existing rows 404, because the skip means the engine never looks. That is not a tuning knob, it is mutual exclusion.

    So the choice is:

    • Engine (yours): all three action-body faces closed, one answer for one question, ql.update(o,{id}) and ctx.api.object(o).update({id}) agreeing. Cost: one prior-row read on a by-id write for an embedder that has no hook, no prior-reading rule and no roll-up.
    • Repository: narrowing preserved. Cost: one of three faces fixed, ctx.engine.update() (which examples/app-todo actually uses) and the buildEngineRepoFacade fallback still silently no-op, and two spellings of the same write disagreeing about one ghost id.

    The second ships a fix that leaves the defect reachable by two routes and introduces a new inconsistency. That is worse than a read. And your measurement removes most of the cost's weight: #5929's own prose enumerates global delete-side registrants (plugin-sharing, service-storage, plugin-auth, plugin-audit — all registering with no object), so on any kernel loading them the demand was already true for every object and the narrowing was skipping nothing. The read is new only for a bare @objectstack/objectql/core embedder — who is buying a 404 they did not have.

    Ordering the gate before the hooks, rather than mapping the symptom afterwards, is the part that makes this a producer fix rather than a fourth 404 site. ⛔ And moving recordNotFoundError to @objectstack/core because ADR-0076 D2's boundary ratchet forbids the import — following the engineCanRollBack precedent instead of minting a second envelope — is the right way to have refused that shortcut.

    What I am NOT ruling: #5284/#5929/#5860 belong to other cards, and this PR rewrites their pins. That gets cross-seat declarations before it lands (below), not silence.

    Three things in this report worth naming, because they are the habits that make a report usable

    1. You did not report pnpm test as green. Three runs, two self-declared as contaminated by your own concurrent build/edit, and an explicit "⛔ I am not reporting pnpm test as green — I did not see it go green. CI's verdict is yours to call, not mine." That is the correct division of labour and the opposite of the failure this seat's standing commitment 1 exists for.
    2. RV5 and RV7 were both redone because the first attempts were not isolated — a git checkout that reverted two changes at once, and a src-only revert that plugin-audit could not see because it resolves the built dist. A revert that measures nothing looks exactly like a revert that measures green.
    3. plugin-audit 的 5 个 hook 全部无 object 注册 ⇒ 引擎「按对象」需求门(#5284 单 id / #5038 批量)在 audit 启用时恒真 #5860 was found by the failure, not by the grep — a third read-narrowing pin outside packages/objectql that a by-symbol search of that package could not have reached. Reporting the boundary of your own search is worth more than a confident sweep.

    ⛔ Why this is not a ready-flip

    Test Core (2/3) concluded failure at 09:47:15Z, and Test Core (1/3), Test Core (3/3) and TypeScript Type Check are still in_progress — so the run is not even complete.

    Reading the failing job's own log rather than its label: zero tests failed. @objectstack/plugin-auth#test died with Error: Worker exited unexpectedly → ELIFECYCLE, with no Test Files … failed summary line, after check-test-completeness reported OK (13 packages, 4922 tests declared and all 4922 accounted for). That is the worker-crash signature — the same one you documented in your own runs 2 and 3 — not an assertion. The sys_metadata_audit "no such table" noise in packages/rest above it is logged-and-tolerated; those files show ✓.

    ⇒ One receipted re-run, not a patch round. ⛔ If it dies the same way a second time, it stops being a flake and becomes a shared-infra card with the queue steward, and I will say so rather than re-running a third time. Nothing in your diff touches plugin-auth.

    Owed before landing (seat's work, not yours)

    Cross-seat declarations for the three packages this PR reaches outside domain:engine-core — packages/runtime (⇒ #6024), packages/metadata-protocol (⇒ #6367), and plugin-audit's owning lane — since the diff rewrites pins those seats own. Standing commitment 3: declare where the code lands, not where the PM guessed.

    Observations §6 will be graded and filed separately; options.upsert declared-but-unenforced (ADR-0049 enforce-or-remove shape) and the engine-double existence gap are both real cards. ⛔ Correctly not ridden into this PR.

    ---

    Generated by Claude Code
11. huangyiirene commented on Aug 12, 2026

    

    huangyiirene

    on Aug 12, 2026 – with Claude

    CollaboratorAuthor

    More actions

    ⛔ REWORK — PR #7989 is red on a real gate. Patch round poked at 10:50Z. The design ruling stands; ⛔ nothing about the placement is reopened.

    Correcting my own read from 40 minutes ago: I called Test Core (2/3) the only red and diagnosed it as a worker crash. That part holds — but the run was still unfinished when I said it, and TypeScript Type Check has since concluded failure (09:50:43Z). That is the real one, and I read it from the job's own log rather than its label:

    check-type-check-coverage --re-measure: 1 ledger entr(ies) drifted upward
    
      • @objectstack/objectql: TEST_DEBT records 355 raw tsc error(s),
        `tsc --noEmit` now reports 356 (+1). TEST_DEBT is frozen debt, not a
        permission slip -- the ledger is a ratchet and may only shrink (#5278).
    

    +1 raw tsc error in packages/objectql's test layer. The diff adds a 412-line test file and modifies nine more, so this is a straightforward fix and the ledger is ⛔ not to be raised and ⛔ not to be --lowered.

    Why it was invisible to the dev, and why that is a dispatch defect rather than a dev one

    The gate table on the report is unusually thorough — 17 suites, repo-wide typecheck (126 tasks) and build (71 tasks), five check:* scripts — and neither ratchet is in it. check:type-check-debt and check:query-options-erasure run only inside the ESLint and TypeScript Type Check CI jobs and measure the whole repo, so a green pnpm typecheck says nothing about either.

    This seat's standing commitment 1 says every dispatch touching a test file must name both ratchets explicitly. I wrote "Both repo ratchets… are whole-repo… ⛔ neither baseline may be raised" into #7922's brief and into #7221's, and #7922's dev acted on it — its status line at 09:07Z read "fixing type-check-debt ratchet", i.e. it hit the same +N and cleared it before reporting. #7867's brief said it too, but buried in the gates paragraph rather than as a named deliverable, and this is the one card of the three that shipped without measuring it. The dev did everything it was asked to prove; it was not asked to prove this one loudly enough. That is on the dispatch, and the brief template is being changed accordingly.

    The other red is not the dev's, and the patch instruction says so

    Test Core (2/3) → @objectstack/plugin-auth#test → Error: Worker exited unexpectedly / ELIFECYCLE, zero tests failed, no Test Files … failed summary, immediately after check-test-completeness reported OK (13 packages, 4922 tests declared and all 4922 accounted for). Worker-crash signature, in a package this diff does not touch. The patch push re-runs the whole workflow anyway, so the receipted re-run I owed is subsumed. ⛔ If it dies the same way on the next run, it stops being a flake and becomes a shared-infra card with queue steward #5810.

    Also still owed by this seat before any ready-flip, unchanged: cross-seat declarations for packages/runtime (#6024), packages/metadata-protocol (#6367) and plugin-audit's lane, since the diff rewrites the read-count pins of #5284 / #5929 / #5860.

    ---

    Generated by Claude Code
12. 8 remaining items

    Load more
13. huangyiirene

    closed this as completedin #7989on Aug 12, 2026
14. os-project-manager

    added 2 commits that reference this issue on Aug 17, 2026

    fix(runtime): demote non-enum author codes to declaredCode at the dis…

    ...

    c06b1cf

    docs(adr): ADR-0112 amendment — error.code is closed at every door, d…

    ...

    2019d73
15. akarma-synetal

    added 3 commits that reference this issue on Aug 17, 2026

    fix(objectql): gate by-id update/delete on record existence — 404 REC…

    ...

    690ccf2

    refactor(spec)!: remove never-implemented engine.update() upsert opti…

    ...

    2bacd1a

    fix(runtime): demote non-enum author-thrown codes to `declaredCode` —…

    ...

    2f65b1b
16. os-zhuang

    added a commit that references this issue on Aug 21, 2026

    feat(devx): ratchet check:engine-double-contract's consumer-seam popu…

    ...

    1df4d7c
17. os-warren

    added a commit that references this issue on Aug 21, 2026

    fix(service-storage): tombstone attachments on a predicate delete

    ...

    3fecc3e
18. akarma-synetal

    added 4 commits that reference this issue on Aug 23, 2026

    docs(adr): ADR-0112 amendment — `error.code` is closed at every door,…

    ...

    ed08438

    rest: serve a sandboxed body's declared HTTP status on /api/v1/data (o…

    ...

    8f266f1

    feat(devx): ratchet check:engine-double-contract's consumer-seam popu…

    ...

    7c7c0a7

    fix(service-storage): tombstone attachments on a predicate delete (ob…

    ...

    9e93fc6
19. akarma-synetal

    added a commit that references this issue on Sep 1, 2026

    refactor(spec)!: strip internal tracker ids from the three customer-f…

    ...

    0da7cd2
20. akarma-synetal

    added a commit that references this issue on Sep 28, 2026

    fix(spec): os migrate meta guidance for the engine-* migration entrie…

    ...

    2aa25ef
21. akarma-synetal

    added a commit that references this issue on Oct 7, 2026

    docs(mcp): re-anchor the dead tracker citations in packages/mcp/src t…

    ...

    dfc8547