Skip to content

test(objectql): sweep the dataset type, judged in a tenant that declares its object #19857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 2 commits into from
Sep 24, 2026
Merged

test(objectql): sweep the dataset type, judged in a tenant that declares its object #19857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df9bb3
test(objectql): sweep the dataset type, judged in a tenant that decla…
claude Sep 23, 2026
b244ec4
test(objectql): declare the sweep's tenant once, above both of its users
claude Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 98 additions & 29 deletions packages/objectql/src/metadata-validation-sweep.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
*
* 1. A spec-conformant payload → expect `success: true`.
* 2. A deliberately broken payload (missing required field) →
* expect `invalid_metadata` + status 422 + structured `issues[]`.
* expect `invalid_metadata` + status 422 + structured `issues[]`, and
* (#19586) the refusal must be the SCHEMA's, naming the broken field —
* never an author-time gate rule, which throws the same envelope.
*
* Types without a Zod schema in the central registry (today only
* `rag_pipeline` among the URL-map kinds — `theme`/`webhook` and their
Expand Down Expand Up @@ -42,6 +44,43 @@ import {
getMetadataTypeSchema,
} from '@objectstack/spec/kernel';

// [#19586] The tenant every fixture is judged in, declared ONCE. The runtime
// publish gate resolves references against a live universe, and since `find`
// is mocked to `[]` below and nothing is read back, this harness's universe is
// exactly what `makeProtocol` registers. Each document here is used twice: a
// clone is seeded into every harness's registry, and the document itself is
// the `valid` payload of its own row, so the tenant cannot drift from what
// those rows publish.
//
// Declared here rather than read out of `FIXTURES`, so a row stays removable:
// deleting the `dataset` fixture brings its `no fixture (skipped)` note back
// and leaves the tenant intact, where a seed read from `FIXTURES.dataset`
// would crash every row on the missing key.
const SWEEP_ACCOUNT: any = {
name: 'sweep_account',
label: 'Account',
// [#8310] The runtime object door requires an authored OWD
// (`security-owd-unset` refuses absence), so a "valid" object
// fixture must author its posture.
sharingModel: 'private',
// [#19542] `stage` joins `amount` so the dataset seeded into this
// harness's live universe is COHERENT with the object this tenant
// declares — its one dimension is over a field `sweep_account` really
// has. The `report` fixture groups by that dimension.
fields: {
amount: { name: 'amount', label: 'Amount', type: 'number' },
stage: { name: 'stage', label: 'Stage', type: 'text' },
},
};

const SWEEP_ACCOUNT_METRICS: any = {
name: 'sweep_account_metrics',
label: 'Account Metrics',
object: 'sweep_account',
dimensions: [{ name: 'stage', label: 'Stage', field: 'stage', type: 'string' }],
measures: [{ name: 'amount_sum', label: 'Amount', aggregate: 'sum', field: 'amount' }],
};

function makeProtocol() {
const registry = new SchemaRegistry({ multiTenant: false });
// [#19542] The live resolution universe this harness hands the runtime
Expand All @@ -58,13 +97,16 @@ function makeProtocol() {
// a report binding a dataset nobody declares is still refused, which is the
// #19542 door working. The dimension and measure names are exactly what the
// `report` fixture's `rows` / `values` select.
registry.registerItem('dataset', {
name: 'sweep_account_metrics',
label: 'Account Metrics',
object: 'sweep_account',
dimensions: [{ name: 'stage', label: 'Stage', field: 'stage', type: 'string' }],
measures: [{ name: 'amount_sum', label: 'Amount', aggregate: 'sum', field: 'amount' }],
});
//
// [#19586] The OBJECT that dataset is over joins it, for the same reason
// one door further on: since the dataset door opened (#19143) a dataset's
// `object` resolves against this universe, and with no object registered
// the `dataset` fixture was refused `object-reference-unknown` on
// `datasets.sweep_account_metrics.object`. That refusal kept this type's
// row at `no fixture (skipped)`. ⛔ Still not a relaxation: a dataset over
// an object this tenant does not declare is refused exactly as before.
registry.registerObject(structuredClone(SWEEP_ACCOUNT));
registry.registerItem('dataset', structuredClone(SWEEP_ACCOUNT_METRICS));
const mockEngine: any = {
registry,
find: vi.fn().mockResolvedValue([]),
Expand All @@ -81,28 +123,17 @@ function makeProtocol() {
interface Fixture {
valid: any;
invalid: any;
/** Field name the invalid payload removes (for human-readable assertion). */
/**
* The field the invalid payload breaks. ASSERTED, not just printed
* (#19586): the 422 counts only when the schema's own issue names this
* field, at the top level or as the last segment of a nested path.
*/
invalidatedField: string;
}

const FIXTURES: Record<string, Fixture> = {
object: {
valid: {
name: 'sweep_account',
label: 'Account',
// [#8310] The runtime object door requires an authored OWD
// (`security-owd-unset` refuses absence), so a "valid" object
// fixture must author its posture.
sharingModel: 'private',
// [#19542] `stage` joins `amount` so the dataset seeded into this
// harness's live universe is COHERENT with the object this tenant
// declares — its one dimension is over a field `sweep_account` really
// has. The `report` fixture groups by that dimension.
fields: {
amount: { name: 'amount', label: 'Amount', type: 'number' },
stage: { name: 'stage', label: 'Stage', type: 'text' },
},
},
valid: SWEEP_ACCOUNT,
invalid: { label: 'No Name' },
invalidatedField: 'name',
},
Expand Down Expand Up @@ -176,10 +207,27 @@ const FIXTURES: Record<string, Fixture> = {
invalid: { label: 'No name' },
invalidatedField: 'name',
},
// [#19586] Runtime-creatable since the #19143 door, and until this fixture
// its row printed `no fixture (skipped)`. The valid document is the
// tenant's own dataset over `sweep_account` (see `SWEEP_ACCOUNT_METRICS`).
// The invalid one is the same document minus `measures`, so the only thing
// the schema can refuse it for is `measures`, and `runOne` asserts that it
// is the schema refusing, never a gate rule on `object`.
dataset: {
valid: SWEEP_ACCOUNT_METRICS,
invalid: {
name: 'sweep_account_metrics',
label: 'Account Metrics',
object: 'sweep_account',
dimensions: [{ name: 'stage', label: 'Stage', field: 'stage', type: 'string' }],
},
invalidatedField: 'measures',
},
report: {
// ADR-0021 single-form: a report binds a dataset + selects values by name.
// The bound dataset is the fixture directly above, and its dimension and
// measure names are what `rows` / `values` select.
// The bound dataset is the fixture directly above (`SWEEP_ACCOUNT_METRICS`,
// which `makeProtocol` seeds into every harness's universe), and its
// dimension and measure names are what `rows` / `values` select.
valid: {
name: 'sweep_report',
label: 'Sweep',
Expand Down Expand Up @@ -311,7 +359,11 @@ const FIXTURES: Record<string, Fixture> = {
tools: ['sweep_tool'],
},
invalid: { name: 'sweep_skill', label: 'Sweep' },
invalidatedField: 'description',
// [#19586] `tools`, not `description`: the payload drops both, but
// `description` is optional on a skill, and the schema's only issue is
// at `tools`. The label named a field whose absence refuses nothing,
// and nothing read it until `runOne` started to.
invalidatedField: 'tools',
},
};

Expand Down Expand Up @@ -358,7 +410,24 @@ async function runOne(type: string, fx: Fixture | undefined): Promise<Row> {
invalidRejected = hasSchema ? 'fail' : 'ok';
} catch (e: any) {
if (e?.code === 'INVALID_METADATA' && e?.status === 422 && Array.isArray(e?.issues)) {
invalidRejected = 'ok';
// [#19586] The envelope alone cannot say WHICH door refused: the
// runtime author-time gate throws the very same `INVALID_METADATA` /
// 422 / `issues[]`. A broken fixture refused there — say for an
// `object-reference-unknown` in this harness's small universe —
// would read `ok` while proving nothing about the schema. So the
// refusal counts only when it is the SCHEMA's and names the field
// the fixture broke: a gate issue always carries its `rule` and a
// stack-rooted path (`datasets.NAME.object`), a schema issue carries
// neither.
const issues: any[] = e.issues;
const gateRules = issues.map((i) => i?.rule).filter(Boolean);
const named = issues.some(
(i) => !i?.rule
&& typeof i?.path === 'string'
&& (i.path === fx.invalidatedField || i.path.endsWith(`.${fx.invalidatedField}`)),
);
if (gateRules.length === 0 && named) invalidRejected = 'ok';
else invalidNote = `422 is not the schema refusing \`${fx.invalidatedField}\`: ${JSON.stringify(issues)}`;
} else {
invalidNote = `unexpected error: ${e?.code ?? 'unknown'} ${e?.status ?? ''} ${e?.message ?? ''}`;
}
Expand Down
Loading