docs(changeset): the admin-audit changeset notes that rows written before the release keep their metadata (#21198) - #21300
objectstack-fleet[bot] wants to merge 1 commit into
Conversation
…he release keep their metadata, as ruled (#21198) Adds one sentence to the pending changeset for the admin identity ledger rows: the rows written before the release keep the values their metadata already holds, because the ledger is append-only (ADR-0052). This is the note owed by the maintainer's ruling on the card; no code changes. Claude-Session: https://claude.ai/code/session_01DiCSbmJrkzNhuEAier4VoJ Co-authored-by: Claude <noreply@anthropic.com>
|
Record for the landing rule:
Generated by Claude Code |
|
Closing unmerged: the changeset this PR edits has shipped. ·
Ruling Also recorded: no CI ever ran on this PR (its Generated by Claude Code · https://claude.ai/code/session_01DiCSbmJrkzNhuEAier4VoJ |
Refs #21198
Clause-②: no
This PR edits a pending changeset it did not add, on the maintainer's confirmation (ruling
5942375063, 「同意264」), soCheck Changesetis red by design under #17712. That job is not a required context (the seven inscripts/check-required-contexts.mjsREQUIRED_CONTEXTS, line 368, do not name it;AGENTS.md:518-522lists the same seven) and it does not run onmerge_group(.github/workflows/pr-automation.yml:41-43triggers onpull_requestonly; the file has zeromerge_groupoccurrences). The job's own text says the red is the point (pr-automation.yml:728-730). No label and no changeset of this PR's own is added to turn it green.The change
One sentence, appended to the last paragraph of
.changeset/21174-admin-audit-metadata.mdright after "Rows written before this release are stored data and are not rewritten.":1 file, +1/-1. No other line of that file and no other file changes.
Why
Ruling 甲 on #21198 (comment
5942375063), Execution section:Premise checked on
origin/mainat4e6dc2338: the changeset is still onmainandpackages/plugins/plugin-auth/CHANGELOG.mdhas no21174hit, so no release has consumed it. PR #21195 merged as55012df30. None of the 16 open PRs at the time of the check (the Version Packages PR #20639 included) lists the file. The card stays shut asnot_planned; this PR carries no closing keyword for it.Wording check
docs/adr/0052-audit-is-not-the-activity-feed.md:36reads "sys_audit_log(immutable, append-only, retained, security-gated)", and:80reads "immutable, compliance-grade". The code declares it too:packages/plugins/plugin-audit/src/objects/sys-audit-log.object.ts:22hasmanagedBy: 'append-only'.sys_audit_logrows written before the security(plugin-auth): the compliance-ledger row an admin create-user writes carries a withheld user field's value in its decision metadata, which a ledger reader withheld that field is served #21174 change stay as they are, and that no one-time migration rewrites them.Gates
Run at head
98cd8b924, fromnode scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands(19 commands, no paths):check:nul-bytes,check:published-files,check:changeset-gate-self-testsamong them).node scripts/check-empty-changeset.mjs --base origin/mainexits 1: it prints "This PR changes a changeset it did not add" for.changeset/21174-admin-audit-metadata.md. That is the by-design red above and the only red.check-changeset-fixed.mjs(its roster lives under.changeset) andpnpm check:required-contexts("7 required context name(s) pinned").Acceptance notes
docs/adr/0052-audit-is-not-the-activity-feed.md:3) reads "Proposed (2026-06-16) — partially implemented", while the ruling calls it accepted. The sentence cites the ADR only for the property it declares (the ledger is append-only), not for the ADR's status, so it stays true either way. Noted, not edited:docs/adr/**is a governed surface and outside this card.Generated by Claude Code