Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/spec-last-six-dead-citation-anchors.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
'@objectstack/spec': patch
---

Six provenance comments in `src/data/` and `src/ui/` were re-anchored

Clause-②: no

Six comment and docblock lines in `src/data/datasource.zod.ts`, `src/data/filter.zod.ts`,
`src/data/value-roundtrip-conformance.ts` and `src/ui/component.zod.ts` cited tracker numbers
that no longer resolve on GitHub. Each now cites the commit in this repository's history that
decided the matter, and the datasource comment also says in words which refusal it means: a
credential written into mongo's `options` passthrough. The live numbers beside them stay.
Comments only: no type, schema, export or runtime behaviour changes.
5 changes: 3 additions & 2 deletions packages/spec/src/data/datasource.zod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,9 @@ export const DatasourceSchema = lazySchema(() => strictObject(
// `MongoConfigSchema` (a config-level refinement sees only `config`;
// `credentialsRef` sits on the datasource), so both run here, where both
// halves are visible at once. They compose independently with the config
// gate above: a config also violating #8082/#8336/#9040 reports those
// issues too, each at its own path.
// gate above: a config also violating #8082/#8336, or the refusal of a
// credential in mongo's `options` passthrough (commit 24206416a), reports
// those issues too, each at its own path.
//
// The two arms split on the connect path's OWN branch test, not on key
// presence: `buildMongoUrl` opens `if (explicit) return explicit;`, so a
Expand Down
2 changes: 1 addition & 1 deletion packages/spec/src/data/filter.zod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ export const RangeOperatorSchema = lazySchema(() => z.object({
* @see https://github.com/objectstack-ai/objectstack/issues/4706 (the ruling)
* @see https://github.com/objectstack-ai/objectstack/issues/5702 (the SQL family — landed)
* @see https://github.com/objectstack-ai/objectstack/issues/6520 (the JS faces — landed)
* @see https://github.com/objectstack-ai/objectstack/issues/17590 (the membership reading — the SQL family landed)
* @see commit e04a0aff2 (the membership reading, landed with the SQL family)
* @see https://github.com/objectstack-ai/objectstack/issues/7398 (the refusal whose prescription this spelling is)
*/
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/spec/src/data/value-roundtrip-conformance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
* belongs in this table and the case that proves it belongs in this file.
*
* @see https://github.com/objectstack-ai/objectstack/issues/12393 (this table)
* @see https://github.com/objectstack-ai/objectstack/issues/12380 (the measured boundary set)
* @see commit 4045b954d (the measured boundary set)
* @see https://github.com/objectstack-ai/objectstack/issues/9276 (the value class deliberately excluded)
*/

Expand Down
6 changes: 3 additions & 3 deletions packages/spec/src/ui/component.zod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ export const PageHeaderProps = strictObject({
* How many header actions render as inline buttons before the rest fold into
* the overflow menu — desktop and mobile budgets (#4001 batch A).
*
* Declared on the #5611/#5775/#6276 rule, for the same reason and by the same
* Declared on the #5611 / #5775 / commit 78f0be872 rule, for the same reason and by the same
* evidence: the renderer has always read them and the schema had not caught
* up. `containers.tsx:1358` resolves
* `schema?.maxVisible ?? schema?.properties?.maxVisible` (and the `mobile*`
Expand Down Expand Up @@ -748,7 +748,7 @@ export const PageTabsProps = strictObject({
* comment invites the override: *"Authors who want the strip even at length 1
* can pass `properties.alwaysShowStrip: true`"* (`containers.tsx:637`, read as
* `schema?.properties?.alwaysShowStrip === true`). Declared on the same
* #5611/#5775/#6276 rule as `page:header`'s action budget: the delivered,
* #5611 / #5775 / commit 78f0be872 rule as `page:header`'s action budget: the delivered,
* invited shape is the contract, and a closed schema that rejected it would
* be the declaration disagreeing with the renderer in the direction that
* costs the author.
Expand Down Expand Up @@ -4552,7 +4552,7 @@ export const ObjectMetricPropsSchema = lazySchema(() => strictObject({
* equally true of `page:header`'s `icon`, which is REFUSED precisely because
* no render path reads it. Vocabulary does not separate the two verdicts; a
* read point does (#9397 closed premise-overtaken re-deriving one from
* scratch; #9881/#9972 recorded the accordion and tab items). This is the
* scratch; #9881 / commit 60e0f900a recorded the accordion and tab items). This is the
* same record for the metric tile.
*
* The key is LIVE at the objectui pin this repo builds against
Expand Down
Loading