Skip to content

fix(metadata-protocol)!: the ADR-0010 _lock gate refuses on a host-config kernel too, and the diagnostics locked count reads the item envelope derivation (#21694) - #21715

Merged
objectstack-fleet[bot] merged 7 commits into
mainfrom
claude/issue-21694-lock-door-read-agree
Oct 4, 2026
Merged

objectstack-fleet[bot] merged 7 commits into
mainfrom
claude/issue-21694-lock-door-read-agree

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #21694
Clause-②: no (narrowing)

Arm 1a: no recorded reason exempts a host-config kernel

I measured H1 before writing any code.

So the gate refuses on every topology, as packagedBaseRefusal does. I kept no exemption for the declared package-author channel either. No ADR or comment records one for L3, and no assembly in this repository declares that channel (git grep finds 0 non-test declarations). H3 (arm 1b) is not taken.

What changed

Only packages/metadata-protocol/src/protocol.ts changes at runtime.

  1. The gate. lockWriteRefusal and assertLockAllowsDelete lose the short-circuit. publishMetaItem (through promoteDraftForPublish) and rollbackMetaItem already call them unconditionally, so those two verbs now refuse on a host-config kernel too.
  2. The two call sites inside if (this.environmentId !== undefined). saveMetaItem and deleteMetaItem asked the gate inside that block, behind their package doors, so removing the short-circuit alone would not reach them. The gate moves out of the block, and it keeps its rank on both kernels: it runs only when packagedBaseRefusal admits the write.
    • On an environment kernel the package door has already thrown by that point, so nothing changes there.
    • On a host-config kernel the package door is the repository's (SysMetadataRepository.assertAllowed, at the write), so a packaged base it refuses keeps that answer.
    • Without the rank, a packaged app or object that declares _lock would answer ITEM_LOCKED on a host-config kernel and NOT_OVERRIDABLE on an environment kernel. That would be a new topology split in the refusal code. Ablation 2 below pins it.
  3. The count. getMetaDiagnostics().stats[type].locked now counts items whose servedLockState(...) reports a lock other than 'none'. That is the same derivation getMetaItem and getMetaItemLayered publish. The field's docblock says so.

No packages/spec/src/** file is touched, so no contract review is owed on that ground. No governed surface is touched.

Reach: correcting the card's "no shipped producer"

Triage graded p3 on the premise that "every protection.lock in platform-objects is on object". Three apps carry one too: setup, studio and account (packages/platform-objects/src/apps/*.app.ts, protection.lock: 'full'). app has supportsOverlay: true, so the #6960 carve-out lets a removal past the package door, and only the _lock gate stood behind it.

  • At the base (16d241a). I ran the real ObjectStackProtocolImplementation over an in-memory double, without an environmentId. Deleting a packaged app that declares _lock: 'full' answered success. An environment kernel answered 403 ITEM_LOCKED.
  • On this branch, on a live showcase. I started a fresh dev server (pnpm dev -- --fresh -p 38694) and signed in as the seeded admin. DELETE /api/v1/meta/object/sys_organization answered 200 ("No customization overlay found"), where an environment kernel answers 403 NOT_OVERRIDABLE, so the server is host-config.
    • GET /api/v1/meta/app/setup answers lock: full, editable: false, deletable: false.
    • DELETE /api/v1/meta/app/setup answers 403 ITEM_LOCKED ("app/setup is locked (_lock=full, source=artifact)").

The grade is the seat's call. This corrects the premise behind it.

What moves (H2)

  • The dev server's own boot. The fresh showcase boot above logged no ITEM_LOCKED, no "is locked (_lock=" and no "metadata store could not be read" (0 hits in 72 lines). Nothing the boot writes is refused.
  • examples/**. No example declares _lock or protection: (git grep: 0 hits).
  • Writers that now meet the gate on a host-config kernel, as they already did on an environment kernel:
    • os migrate meta --stored --apply (migrateStoredMetadata): a row whose effective lock refuses the write is reported failed instead of rewritten.
    • deletePackage and discardPackageDrafts: a locked item becomes a failed[] row.
    • duplicatePackage.
    • plugin-security's permission-set projection.
    • service-automation's flow-credential migration.
    • the /automation doors, which write through saveMetaItem and deleteMetaItem.
  • A host-config deployment that relied on writing a _locked item. Its saves, publishes, rollbacks and deletes are refused now, as on an environment kernel. A stored row that declares full can no longer be written or removed through /meta on any kernel. The ADR-0010 §3.8 override path is not implemented, and that is unchanged here.
  • Fail-closed read. On a host-config kernel the gate's own sys_metadata read now runs first. A failed read is answered 503 SERVICE_UNAVAILABLE, with the driver error on cause (getEffectiveLock 的 overlay 读用裸 catch,sys_metadata 读失败时保护闸门 fail-open(_lock 落成 'none',写/删被放行) #5706), before anything is written. A delete used to reach the store and answer with the driver's code or a 500.
  • NOT MEASURED: the cloud control-plane assembly. It is outside this repository, and if it declares package-author and writes _locked items through saveMetaItem, it now meets the gate.
  • Tests that moved: 14 cases in 6 files, all fixtures, none a product regression. Each one leaned on the bypass:
    • metadata-protocol/protocol.delete-rewrap-envelope.test.ts (4 cases). The fault was injected into the first sys_metadata read, which is now the gate's own read and fails closed with a 503. The fault now arms once the lock verdict is in, so it lands on the probe read this file pins.
    • objectql/protocol-lock-enforcement.test.ts (1 case). It pinned the bypass itself. It now pins ITEM_LOCKED on save and delete, and asserts no update or delete reached the engine.
    • objectql/plugin.authoring-channel.test.ts (1 case). The bare new ObjectQLPlugin() kernel had no driver, so the gate's read failed closed with a 503 before the authoring gate could answer. It now registers a memory driver, as serve.ts does, and also asserts that nothing is stored.
    • objectql/protocol-meta.test.ts (1 case). "Fail fast when findOne is unavailable" now asserts the gate's 503 SERVICE_UNAVAILABLE, with cause being the driver error. The test title loses its "500".
    • objectql/protocol-publish-package-drafts.test.ts (3 cases). The double stubbed assertLockAllowsWrite, but since The lock/conflict denial audit rows roll back with the batch on publishPackageDrafts — a refused item in a package publish still leaves no trail #8594 the publish path asks lockWriteRefusal. The stub moves to lockWriteRefusal.
    • objectql/protocol-registry-shadow.test.ts (4 cases). The suite wrote its overlay row through a PUT that the bypass admitted. The row is now written before the package's lock arrives, which is the pre-dating overlay that the envelope graft exists for. The two removal cases use no-overlay, because full now refuses removal on every kernel, and the first case also asserts that a further PUT is refused.

The count's cost (H4)

servedLockState makes no store read. It is resolveLockState (pure), plus two packagedBaseRefusal calls (registry lookups, which build an Error only for a refused item), plus isArtifactBacked (registry). The list items already carry the merged artifact protection (mergeArtifactProtection in getMetaItems), which is the same document shape the item read derives from. So the sweep stays bounded at one registry walk per item, and the store reads are unchanged.

One authority (H5)

I grepped packages/metadata-protocol/src and packages/rest/src (non-test) for _lock readers.

  • What remains. getEffectiveLock remains for the doors, servedLockState for the read and now for the count, and mergeArtifactProtection copies the envelope.
  • What went. The declared-_lock count was the only second predicate, and it is gone.
  • rest. It has none.
  • runtime. The /automation doors ask packagedBaseRefusal, then write through saveMetaItem and deleteMetaItem, so the _lock gate covers them.
  • One same-family disagreement is left, and it is not topological. It is in the acceptance notes and the report.

Pins

packages/metadata-protocol/src/protocol.lock-door-read-agree.test.ts runs the real doors and the real reads. Each refusal asserts code and status (ADR-0112).

  1. Pin 1, host-config.
    • An overlay view row is tried with each of the four _lock states. Save and delete do what editable and deletable say: ITEM_LOCKED/403 where the read says no, and admitted past the gate where it says yes. Admission is proved by spying on the gate (reached, answered null).
    • A publish of a full row is refused.
    • A packaged app declaring full is refused on delete with ITEM_LOCKED/403. Its save keeps NOT_OVERRIDABLE/403, and the gate is not reached.
  2. Pin 2, both kernels. stats[type].locked equals the number of items whose getMetaItem envelope reads locked, for flow, action, app and view.
    • Lit control: the tiles are {flow: 1, action: 1, app: 2, view: 2}.
    • A count of declared _lock would give {0, 0, 1, 2}. The flow, action and second app are locked by the package door alone.
  3. Pin 3, environment kernel, unchanged. An overlay full row is refused ITEM_LOCKED on save and delete, and a no-delete row passes the gate on save and is refused on delete. A packaged app keeps NOT_OVERRIDABLE on save and ITEM_LOCKED on delete, the same codes the host-config kernel now gives.

Reverse verification

Both ablations ran from the committed fix (HEAD 2ec0a2c), through scripts/ablation-replace.mjs, inside a script with an EXIT INT TERM trap that restores from HEAD. The pin file imports ./protocol.js (source), so no rebuild is in the path. The predicted direction was declared before running.

  1. Ablation 1 restored the short-circuit in both helpers and the declared-_lock count.
    • The anchors landed on disk: the gate anchor went from 2 to 0 with 2 markers on disk, and the count anchor from 1 to 0 with 1 marker. The blob went from 185d1380a0d0 to 5b338f26488f.
    • The result was as predicted. In pin 1, 5 cases went red, and the _lock=none control stayed green. Both pin 2 cases went red. All 3 pin 3 cases stayed green. Total: 7 failed, 4 passed (11).
  2. Ablation 2 removed the rank at both call sites (true || before packagedBaseRefusal).
    • The anchor went from 2 to 0, with 2 markers on disk.
    • Only the packaged-app case went red, because the save answered ITEM_LOCKED instead of NOT_OVERRIDABLE. Pin 3's environment twin stayed green. Total: 1 failed, 10 passed.

Restore. After each ablation the blob equals the HEAD blob 185d1380a0d0, git diff HEAD on the file is empty and git status --porcelain is empty. The tool proved this on each leg, and so did the trap.

Tests

On the merged head 4265c6b (after #21706):

  • @objectstack/metadata-protocol: vitest run, 211 files passed and 3 skipped, 3589 tests passed and 19 skipped. typecheck (tsc --noEmit) is green, and --listFiles shows it compiles 214 test files, including both test files touched here.
  • @objectstack/objectql: vitest run --project local, 372 files and 7458 tests passed. typecheck (tsc, tsconfig.scripts, check:test-typecheck) is green.

On 2ec0a2c (before the second merge of main, which touched neither package's lock path):

  • @objectstack/rest (--project local): 260 files, 4897 tests passed, 326 skipped.
  • @objectstack/runtime (--project local): 321 files, 4563 tests passed, 19 skipped.
  • @objectstack/plugin-security (the 7 files that call the write verbs): 150 tests passed.
  • @objectstack/service-automation (2 files): 24 tests passed.

These four were run because the order asked to measure which tests move. They are downstream consumers, and this is not a public-surface change.

Gates

Run on head 4265c6b, after the final commit. Each command's exit code was captured before any pipe.

  • Derived set. node scripts/pm/dispatch-gates.mjs --commands (no paths) derives 74 families. All 74 exit 0, and the --ran reconciliation reads "74 derived, 74 run, 0 NOT-MEASURED, 0 UNRUN". These include check:adr-0087-registration (the no-migration-prescription disposition is accepted), check:empty-changeset, check:changeset-no-major (its level axis is PR-scoped and reads this body in CI), check:engine-double-contract, check:nul-bytes, check:doc-authoring, check:cross-package-test-inputs, check:test-source-alias, check:published-files and check:dts-closure.
  • check:engine-double-contract. At first it asked for the new pin file's findOne double to be recorded. --write added one row to scripts/engine-double-contract.pinned.json, with "0 added or grown, 0 lost", and that row is committed here.
  • Artifact-roster block. The derivation prints 54 roster commands outside its total, and all 54 were run. 51 exit 0. check-closing-target-claim, check-partof-closing-keyword and check-single-claim-paths exit 2 NOT WIRED, because they read a pull request (PR_NUMBER / PR_BODY). I ran the body gate locally against this body before opening the PR, and the other two run in CI on this PR.
  • The four symbol-anchor sweeps, which no path derives for a source change. All four exit 0:
    • check:adr-symbol-anchors: 2167 anchors across 140 records resolve.
    • check:scripts-symbol-anchors: 3760 anchors across 282 scripts resolve.
    • check:spec-docblock-symbol-anchors: 4877 anchors across 1865 spec sources resolve.
    • check:adr-anchors: green.

NOT MEASURED locally, owned by CI:

  • the Dogfood Regression Gate. The live showcase checks above cover its door for the setup app.
  • the Temporal Conformance live-database job.
  • the whole-workspace type-check lanes.
  • the full pnpm lint.

Acceptance notes

  • Same family, not topological (reported, not filed). An env-wide view row declares _lock: 'full'. An org-scoped read (getMetaItem with organizationId: 'org_a') serves that row and reports lock: full, editable: false. The _lock gate for an org_a save admits, because getEffectiveLock's overlay limb looks up organization_id = org_a only. Measured on both kernels with the protocol over a double: the save went on to validation. This is the door and the read disagreeing on the org axis, and ADR-0010 §3.3 rejects overlay writes under full. The report names it for the seat.
  • Pre-existing on a host-config kernel, untouched here.
  • Two lockSource vocabularies. The door's sentence names the limb (source=artifact or source=overlay), while the envelope carries the declared MetadataLockSource (package for the setup app). This is pre-existing.
  • The [finding] The layered metadata read reports lock none, editable true and deletable true for packaged flows and actions that the write doors refuse with NOT_OVERRIDABLE #21670 table. Its host-config door is the repository gate alone, and its items declare no _lock, so it stays valid. The _lock limb on that kernel is covered by pin 1 here.

Generated by Claude Code

claude added 7 commits October 4, 2026 08:47
…logy, and the diagnostics locked count reads the envelope's derivation

Claude-Session: https://claude.ai/code/session_017ErfyP2Rx7XWHJA27QjyUi
Co-authored-by: Claude <noreply@anthropic.com>
…e diagnostics count agreeing on both topologies

Claude-Session: https://claude.ai/code/session_017ErfyP2Rx7XWHJA27QjyUi
Co-authored-by: Claude <noreply@anthropic.com>
…fault past the lock gate; add the changeset

Claude-Session: https://claude.ai/code/session_017ErfyP2Rx7XWHJA27QjyUi
Co-authored-by: Claude <noreply@anthropic.com>
…etired _lock bypass

Claude-Session: https://claude.ai/code/session_017ErfyP2Rx7XWHJA27QjyUi
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the size/l label Oct 4, 2026
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests tooling labels Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/metadata-protocol, touching 5 documentable anchor(s).

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/api/wire-format.mdx (via /api/v1/meta/* (route, a path literal in a comment in ObjectStackProtocolImplementation))
  • content/docs/concepts/metadata-lifecycle.mdx (via ObjectStackProtocolImplementation (symbol, a top-level class), saveMetaItem (symbol, a method of class ObjectStackProtocolImplementation))
  • content/docs/deployment/validating-metadata.mdx (via saveMetaItem (symbol, a method of class ObjectStackProtocolImplementation), /api/v1/meta/* (route, a path literal in a comment in ObjectStackProtocolImplementation))
  • content/docs/kernel/cluster.mdx (via saveMetaItem (symbol, a method of class ObjectStackProtocolImplementation), /api/v1/meta/* (route, a path literal in a comment in ObjectStackProtocolImplementation))
  • content/docs/kernel/services-checklist.mdx (via deleteMetaItem (symbol, a method of class ObjectStackProtocolImplementation), saveMetaItem (symbol, a method of class ObjectStackProtocolImplementation))
  • content/docs/permissions/authorization.mdx (via saveMetaItem (symbol, a method of class ObjectStackProtocolImplementation))

⛔ 4 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v15.mdx (via /api/v1/meta/* (route, a path literal in a comment in ObjectStackProtocolImplementation))
  • content/docs/releases/v16.mdx (via ObjectStackProtocolImplementation (symbol, a top-level class))
  • content/docs/releases/v17/17-0.mdx (via ObjectStackProtocolImplementation (symbol, a top-level class))
  • content/docs/releases/v17/17-1.mdx (via getMetaDiagnostics (symbol, a method of class ObjectStackProtocolImplementation))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • the SDK route bridge reached 54 of 206 client-bound route-ledger rows — the other 152 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 152: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 97 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 11 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 9d91f583dfa7a0655ff0f5f00564b09a0c481d55 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 540569d3a37990b588cb17efff34b4ebb9306013 — the merge of head 4265c6bc044b05ae8be1c669f3458da30c01df42 into base 9d91f583dfa7a0655ff0f5f00564b09a0c481d55, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 540569d3a37990b588cb17efff34b4ebb9306013 && git checkout 540569d3a37990b588cb17efff34b4ebb9306013
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 9d91f583dfa7a0655ff0f5f00564b09a0c481d55 4265c6bc044b05ae8be1c669f3458da30c01df42 && git checkout -B drift-repro 9d91f583dfa7a0655ff0f5f00564b09a0c481d55 && git merge --no-ff 4265c6bc044b05ae8be1c669f3458da30c01df42

node scripts/docs-audit/affected-docs.mjs --json 9d91f583dfa7a0655ff0f5f00564b09a0c481d55

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 9d91f583dfa7a0655ff0f5f00564b09a0c481d55 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

ACCEPT — PR #21715 at head 4265c6bc04

domain:engine#1 · session_017ErfyP2Rx7XWHJA27QjyUi · read at 2026-10-04T10:13Z. The os-dev report is on #21694. Judged against GitHub and the branch, not against the report.

  • Shape: draft, base main, assignee os-project-manager.

    • The first lines are Fixes #21694 and Clause-②: no (narrowing), the arm-1a line the claim named.
    • The closing-keyword scan finds #21694 only. Every other number in the body appears with no verb next to it.
  • Scope: 10 files, +481/-45:

    • protocol.ts;
    • one new pin file;
    • six re-aimed fixture files;
    • the engine-double ledger (one row, written by the gate's own --write);
    • the changeset.

    No packages/spec/src/** file is touched. A local git merge-tree against origin/main 9d91f583df is clean.

  • H1 decides arm 1a, and the seat accepts it.

  • The diff, read:

    • The short-circuit is removed from lockWriteRefusal and assertLockAllowsDelete.
    • The saveMetaItem and deleteMetaItem gate calls move out of the environmentId !== undefined block (removing the short-circuit alone would not have reached them). They are guarded by packagedBaseRefusal(...) === null, so their rank below the package door is the same on both kernels.
      • On an environment kernel that door has already thrown when it refuses, so the guard is always true there and nothing moves.
      • On host-config, a packaged base the repository door will refuse keeps NOT_OVERRIDABLE. Ablation 2 pins that rank.
    • getMetaDiagnostics counts servedLockState(...).lock !== 'none'. servedLockState and isArtifactBacked are synchronous registry reads, so the sweep makes no extra store read per item, as the changeset says.
  • The fixtures, re-aimed and not loosened (the seat read every hunk):

    • protocol-lock-enforcement pinned the bypass ("environmentId=undefined bypasses L3"). It now pins enforcement: ITEM_LOCKED / 403 on save and delete, and no engine write.
    • protocol-registry-shadow keeps its subject, the overlay-then-artifact envelope graft. The row is written before the artifact's lock arrives, and the removal cases use 'no-overlay', with each change explained inline.
    • delete-rewrap-envelope arms its fault only after the lock verdict, so it still lands on the probe read it pins.
  • The dev corrected the card's premise, and the seat acknowledges it. Triage graded p3 on "every protection.lock in platform-objects is on object". The platform's setup, studio and account apps declare protection.lock: 'full'.

    • On a live fresh showcase from this branch (host-config), DELETE /api/v1/meta/app/setup now answers 403 ITEM_LOCKED. At base it passed the package door, and a PUT of those apps' overlay was admitted while the read said editable: false.
    • So there is a shipped producer on the flagship's own boot shape. The fix is landing, so the grade has no queue effect left; the correction stands on record here and on the card.
  • Clause-②: no (narrowing) — accepted. The door refuses on one more topology what it already refused on the other. Nothing widens, no code is added, and there is no packages/spec path, so no contract review is owed.

  • Changeset, checked sentence by sentence:

  • Evidence:

    • metadata-protocol: 3589 tests pass. objectql: 7458 pass. Both typechecks are green on the final head.
    • rest, runtime, plugin-security and service-automation were measured one merge earlier; the later merge moved the hook branch and droppedFields, not the lock path. Accepted.
    • The new pin file has 11 cases.
    • Ablation 1 restored the short-circuit and the declared-_lock count: pins 1 and 2 went red (7 cases), and pin 3 and the _lock=none control stayed green.
    • Restores were proved by blob equality and an empty git diff HEAD and status.
    • A base probe at 16d241a6af showed the asymmetry, and the live showcase showed 0 lock refusals and 0 store-read failures at boot.
  • Gates:

    • dispatch-gates --ran: 74 derived, 74 run, every one exit 0.
    • The artifact-roster block is green, including the 3 PR-context guards after pr_create.
    • The four symbol-anchor sweeps exit 0.
    • One transient red, caused by the dev's own probe file, is accounted for.
  • CI: read by the seat at landing.

Out-of-scope findings:


Generated by Claude Code

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 37196374827 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Console Pin Gate — 失败步骤: Build the Console SPA at the pinned objectui SHA

    ✗ Built console still carries the PUBLISHED @objectstack/spec.
    

↳ 失败原因 是判读的关键:超时(Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言(AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError。 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

  • ⚠️ 本次没有可用的聚合签名(日志里没有能解析出测试文件名的 FAIL 行)—— 这不是「没有同签名的其他 PR」,是这一轮没测到。跨 PR 聚合本次不可用,请手工比对其他 PR 的同类评论。
  • ⚠️ 24h 评论账本没读完(超过 5 页仍未读到窗口尽头),所以上面的「不同 PR 数」是下界,不是全量。

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 13 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/l tests tooling

Projects

None yet

2 participants